From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1DC6840653 for ; Thu, 27 Jan 2022 07:46:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A618068B1E3; Thu, 27 Jan 2022 09:46:53 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5654068B008 for ; Thu, 27 Jan 2022 09:46:47 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 81D1C24017C for ; Thu, 27 Jan 2022 08:46:46 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id ZxceQAI0s2lK for ; Thu, 27 Jan 2022 08:46:46 +0100 (CET) Received: from lain.red.khirnov.net (lain.red.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.red.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id EE04B240179 for ; Thu, 27 Jan 2022 08:46:45 +0100 (CET) Received: by lain.red.khirnov.net (Postfix, from userid 1000) id B6ED816008E; Thu, 27 Jan 2022 08:46:45 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20220113015101.4-60-jamrial@gmail.com> References: <20220113015101.4-1-jamrial@gmail.com> <20220113015101.4-60-jamrial@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 27 Jan 2022 08:46:45 +0100 Message-ID: <164326960561.23111.16805678724414225712@lain.red.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 059/281] flic: convert to new channel layout API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2022-01-13 02:50:21) > From: Vittorio Giovara > > Signed-off-by: Vittorio Giovara > Signed-off-by: James Almer > --- > libavformat/flic.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/flic.c b/libavformat/flic.c > index 44ed696421..496402aa94 100644 > --- a/libavformat/flic.c > +++ b/libavformat/flic.c > @@ -157,10 +157,10 @@ static int flic_read_header(AVFormatContext *s) > ast->codecpar->codec_id = AV_CODEC_ID_PCM_U8; > ast->codecpar->codec_tag = 0; > ast->codecpar->sample_rate = FLIC_TFTD_SAMPLE_RATE; > - ast->codecpar->channels = 1; > + ast->codecpar->format = AV_SAMPLE_FMT_U8; This is unrelated. Setting the format was removed in ffmpeg (but not in libav) in 7b007a7c1fad57e9ed4b685c1d3b4222f02d9720, with the comment "It is supposed to be set from lavc only." At the time it was still done on the AVStream-embedded codec context, so it might have been true, but today there is no issue with setting the AVCodecParameters format from the demuxer, several other demuxers do so. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".