From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 70F3540087 for ; Tue, 18 Jan 2022 10:52:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 81F6368B0E1; Tue, 18 Jan 2022 12:52:15 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E81D468B083 for ; Tue, 18 Jan 2022 12:52:08 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 5388F24017C for ; Tue, 18 Jan 2022 11:52:08 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id rFvEZ61sPpp6 for ; Tue, 18 Jan 2022 11:52:07 +0100 (CET) Received: from lain.red.khirnov.net (lain.red.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.red.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id ADF55240179 for ; Tue, 18 Jan 2022 11:52:07 +0100 (CET) Received: by lain.red.khirnov.net (Postfix, from userid 1000) id CDC1E16008E; Tue, 18 Jan 2022 11:52:07 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: =?utf-8?q?=3CPR3PR03MB66652146E2BEEA0A61611BC38F589=40PR3PR03MB?= =?utf-8?q?6665=2Eeurprd03=2Eprod=2Eoutlook=2Ecom=3E?= References: <20220111095830.31542-1-anton@khirnov.net> <20220111095830.31542-24-anton@khirnov.net> =?utf-8?q?=3CAM7PR03MB666035380?= =?utf-8?q?325BF0AF158A2828F539=40AM7PR03MB6660=2Eeurprd03=2Eprod=2Eoutlook?= =?utf-8?q?=2Ecom=3E?= <164250101626.23111.15871136514402468182@lain.red.khirnov.net> =?utf-8?q??= =?utf-8?q?=3CPR3PR03MB66650A61EB6F4B354F43C07C8F589=40PR3PR03MB6665=2Eeurpr?= =?utf-8?q?d03=2Eprod=2Eoutlook=2Ecom=3E?= <164250151234.23111.15082993172705566767@lain.red.khirnov.net> =?utf-8?q??= =?utf-8?q?=3CPR3PR03MB66652146E2BEEA0A61611BC38F589=40PR3PR03MB6665=2Eeurpr?= =?utf-8?q?d03=2Eprod=2Eoutlook=2Ecom=3E?= Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 18 Jan 2022 11:52:07 +0100 Message-ID: <164250312772.20480.6828605680408474003@lain.red.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 24/28] ffmpeg_mux: drop a useless check and reduce indentation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Andreas Rheinhardt (2022-01-18 11:35:13) > And if you swapped the patches it would be only two lines for an > ordinary git show; not because of git show functionality, but because > the patch only touches two lines. And I would have to spend extra time dealing with rebase conflicts. Not wasting people's time should be a factor in reviews. I wouldn't mind if there was a point to it, but optimizing diff size doesn't seem particularly meaningful to me. Especially since that code would get touched anyway, so it's not making things easier for git blame either. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".