From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C8D1F43135 for ; Fri, 14 Jan 2022 09:01:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 858FA68B4A1; Fri, 14 Jan 2022 11:00:55 +0200 (EET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4E27268B469 for ; Fri, 14 Jan 2022 11:00:48 +0200 (EET) Received: by mail-pl1-f181.google.com with SMTP id h1so12713643pls.11 for ; Fri, 14 Jan 2022 01:00:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MWGi9JWGGD1rCjenejSDwhOvgk0VGb36nEJF433o0wA=; b=hEIUZB+dBokGgcC3EJXtrXxOHNbWWqGjfbx3IK3fGPakA2Cn8z5jTSHDONl+lGzb5b te66TtfNhnuLHPpTxTKCkuko97f0OaK7k9Nt4p55urtxtWRDmHjd7OmRg3T2nOE7wEla QgAfcE5iWPwcazpnkEmoAQGG62E2A7ExNvR0AO1grFqowDVtIiXspemtF729txSlApbP 3p2+WkyWjZrq1McbjDW2Wlty/apG36TiqjrRjwa+S//XZtKt5W64b39/nbvOUSlQlrqv LFPNzBotN5gNzhYyaw18Ug3igLh3+23viifocjVFWklyL782SiVCAQDDglxSjIrzzq6u VrVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=MWGi9JWGGD1rCjenejSDwhOvgk0VGb36nEJF433o0wA=; b=Adz1z/ssJuhUle3n1Uc+r7fdO78diXbQUoGtQHSjbCpgppRxe2yRezc37f3thDALdi U0G+Ch8ZxqdAOf0PvbGcQ25o5ZShMNBDm9a6TAztBydArpLzUmJ3cWuCSfqQ9y7agdA7 Qh5hs5iyjsnHrhfIZd59XiwFUj12Q5EyfUUVZIxDb8fyGpjX0mTVy0JRrcwCTIwykRBX uXnfMWpx4RP0Vmr1jVLv4BJU9sOmHwq00LPiisLg300+gDwwNV9VecEB5iwzs9ucTQrX N6RuJE0za3mdRQjM0XwuzKgUBXDHqEx6GDqJBknKhdgH46nFTy135cVfBMe/au426vHc yCdA== X-Gm-Message-State: AOAM532slUqViOBgk8knum/d0ZXQ17itxN9ZZarzuyqDkAFYwMG3ouSh xOTzwji7s+hhjkZzdxrfO1pHAOGMtCE= X-Google-Smtp-Source: ABdhPJxMOYE+OPudA78TqrWIKLaiPZ7V6Y/veS6mAkYC1KnhwUYUlWhXAtYgenATCdgr4welTX6+Fg== X-Received: by 2002:a17:902:a9c9:b0:14a:180a:63c0 with SMTP id b9-20020a170902a9c900b0014a180a63c0mr8784655plr.89.1642150846679; Fri, 14 Jan 2022 01:00:46 -0800 (PST) Received: from vpn2.localdomain ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id n15sm10555434pjj.12.2022.01.14.01.00.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Jan 2022 01:00:46 -0800 (PST) From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Date: Fri, 14 Jan 2022 17:00:36 +0800 Message-Id: <1642150837-22960-2-git-send-email-lance.lmwang@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1642150837-22960-1-git-send-email-lance.lmwang@gmail.com> References: <1642070709-3104-1-git-send-email-lance.lmwang@gmail.com> <1642150837-22960-1-git-send-email-lance.lmwang@gmail.com> Subject: [FFmpeg-devel] [PATCH v2 2/3] avcodec/libopenh264enc: make the profile configuablable correctly X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Limin Wang MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Limin Wang d3a7bdd4ac54349aea9150a234478635d50ebd87 was based on incorrect conclusions because we had missed to set uiProfileIdc. If the version of libopenh264 >= 1.8, we can't configured main profile as expected, below is the testing cli: ffmpeg -y -f lavfi -i testsrc -c:v libopenh264 -profile:v main -frames:v 1 test.ts It'll report: [libopenh264 @ 0x5638300] Unsupported profile, select EProfileIdc PRO_BASELINE in libopenh264. Signed-off-by: Limin Wang --- libavcodec/libopenh264enc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index 5b5914c..8e27edb 100644 --- a/libavcodec/libopenh264enc.c +++ b/libavcodec/libopenh264enc.c @@ -220,19 +220,16 @@ static av_cold int svc_encode_init(AVCodecContext *avctx) #endif switch (s->profile) { -#if OPENH264_VER_AT_LEAST(1, 8) case FF_PROFILE_H264_HIGH: param.iEntropyCodingModeFlag = 1; av_log(avctx, AV_LOG_VERBOSE, "Using CABAC, " "select EProfileIdc PRO_HIGH in libopenh264.\n"); break; -#else case FF_PROFILE_H264_MAIN: param.iEntropyCodingModeFlag = 1; av_log(avctx, AV_LOG_VERBOSE, "Using CABAC, " "select EProfileIdc PRO_MAIN in libopenh264.\n"); break; -#endif case FF_PROFILE_H264_CONSTRAINED_BASELINE: case FF_PROFILE_UNKNOWN: param.iEntropyCodingModeFlag = 0; @@ -251,6 +248,7 @@ static av_cold int svc_encode_init(AVCodecContext *avctx) param.sSpatialLayers[0].fFrameRate = param.fMaxFrameRate; param.sSpatialLayers[0].iSpatialBitrate = param.iTargetBitrate; param.sSpatialLayers[0].iMaxSpatialBitrate = param.iMaxBitrate; + param.sSpatialLayers[0].uiProfileIdc = s->profile; #if OPENH264_VER_AT_LEAST(1, 7) if (avctx->sample_aspect_ratio.num && avctx->sample_aspect_ratio.den) { -- 1.8.3.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".