From: lance.lmwang@gmail.com
To: ffmpeg-devel@ffmpeg.org
Cc: Limin Wang <lance.lmwang@gmail.com>
Subject: [FFmpeg-devel] [PATCH 3/3] avcodec/libopenh264enc: set iEntropyCodingModeFlag by coder option
Date: Thu, 13 Jan 2022 18:45:09 +0800
Message-ID: <1642070709-3104-3-git-send-email-lance.lmwang@gmail.com> (raw)
In-Reply-To: <1642070709-3104-1-git-send-email-lance.lmwang@gmail.com>
From: Limin Wang <lance.lmwang@gmail.com>
ffmpeg -y -f lavfi -i testsrc -c:v libopenh264 -profile:v main -coder cavlc -frames:v 1 -bsf trace_headers -f null -
before the patch:
entropy_coding_mode_flag 0 = 1
after the patch:
entropy_coding_mode_flag 0 = 0
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
libavcodec/libopenh264enc.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c
index 995ee37..91deb6c 100644
--- a/libavcodec/libopenh264enc.c
+++ b/libavcodec/libopenh264enc.c
@@ -193,7 +193,7 @@ static av_cold int svc_encode_init(AVCodecContext *avctx)
#endif
param.bPrefixNalAddingCtrl = 0;
param.iLoopFilterDisableIdc = !s->loopfilter;
- param.iEntropyCodingModeFlag = 0;
+ param.iEntropyCodingModeFlag = s->coder >= 0 ? s->coder : 0;
param.iMultipleThreadIdc = avctx->thread_count;
/* Allow specifying the libopenh264 profile through AVCodecContext. */
@@ -222,15 +222,15 @@ static av_cold int svc_encode_init(AVCodecContext *avctx)
switch (s->profile) {
case FF_PROFILE_H264_HIGH:
s->profile = PRO_HIGH;
- param.iEntropyCodingModeFlag = 1;
- av_log(avctx, AV_LOG_VERBOSE, "Using CABAC, "
- "select EProfileIdc PRO_HIGH in libopenh264.\n");
+ av_log(avctx, AV_LOG_VERBOSE, "Using %s, "
+ "select EProfileIdc PRO_HIGH in libopenh264.\n",
+ s->coder == 1 ? "CABAC" : "CAVLC");
break;
case FF_PROFILE_H264_MAIN:
s->profile = PRO_MAIN;
- param.iEntropyCodingModeFlag = 1;
- av_log(avctx, AV_LOG_VERBOSE, "Using CABAC, "
- "select EProfileIdc PRO_MAIN in libopenh264.\n");
+ av_log(avctx, AV_LOG_VERBOSE, "Using %s, "
+ "select EProfileIdc PRO_MAIN in libopenh264.\n",
+ s->coder == 1 ? "CABAC" : "CAVLC");
break;
case FF_PROFILE_H264_CONSTRAINED_BASELINE:
case FF_PROFILE_UNKNOWN:
--
1.8.3.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-01-13 10:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 10:45 [FFmpeg-devel] [PATCH 1/3] avcodec/libopenh264enc: support for colorspace and range information lance.lmwang
2022-01-13 10:45 ` [FFmpeg-devel] [PATCH 2/3] avcodec/libopenh264enc: make the profile configuablable correctly lance.lmwang
2022-01-13 21:57 ` Martin Storsjö
2022-01-14 3:17 ` lance.lmwang
2022-01-13 10:45 ` lance.lmwang [this message]
2022-01-13 22:01 ` [FFmpeg-devel] [PATCH 3/3] avcodec/libopenh264enc: set iEntropyCodingModeFlag by coder option Martin Storsjö
2022-01-14 3:20 ` lance.lmwang
2022-01-13 21:35 ` [FFmpeg-devel] [PATCH 1/3] avcodec/libopenh264enc: support for colorspace and range information Martin Storsjö
2022-01-14 2:59 ` lance.lmwang
2022-01-14 9:00 ` [FFmpeg-devel] [PATCH v2 " lance.lmwang
2022-01-14 9:00 ` [FFmpeg-devel] [PATCH v2 2/3] avcodec/libopenh264enc: make the profile configuablable correctly lance.lmwang
2022-01-14 9:28 ` Martin Storsjö
2022-01-14 9:43 ` lance.lmwang
2022-01-14 9:00 ` [FFmpeg-devel] [PATCH v2 3/3] avcodec/libopenh264enc: set iEntropyCodingModeFlag by coder option lance.lmwang
2022-01-14 9:30 ` Martin Storsjö
2022-01-14 9:23 ` [FFmpeg-devel] [PATCH v2 1/3] avcodec/libopenh264enc: support for colorspace and range information Martin Storsjö
2022-01-14 9:55 ` [FFmpeg-devel] [PATCH v3 " lance.lmwang
2022-01-14 9:55 ` [FFmpeg-devel] [PATCH v3 2/3] avcodec/libopenh264enc: make the profile configuablable correctly lance.lmwang
2022-01-14 12:07 ` Martin Storsjö
2022-01-14 13:49 ` lance.lmwang
2022-01-14 9:55 ` [FFmpeg-devel] [PATCH v3 3/3] avcodec/libopenh264enc: set iEntropyCodingModeFlag by coder option lance.lmwang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1642070709-3104-3-git-send-email-lance.lmwang@gmail.com \
--to=lance.lmwang@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git