* Re: [FFmpeg-devel] [PATCH] IEC61937_EAC3 decoding support [not found] ` <CAM_Y7LjGS1gP9Rz3Z-PBWTbk4PwciQVWdA30CcbrsyoEEqucKg@mail.gmail.com> @ 2022-01-11 15:52 ` Denis Shulyaka 2022-01-12 9:46 ` Anton Khirnov 0 siblings, 1 reply; 3+ messages in thread From: Denis Shulyaka @ 2022-01-11 15:52 UTC (permalink / raw) To: FFmpeg development discussions and patches Hi all, Is there anything I could do to kindly ask to review and accept the patch? Best regards, Denis Shulyaka вт, 28 сент. 2021 г. в 17:53, Denis Shulyaka <shulyaka@gmail.com>: > Hi all, > > This is a kind reminder. > > Best regards, > Denis Shulyaka > > вс, 11 апр. 2021 г. в 13:21, Denis Shulyaka <shulyaka@gmail.com>: > >> Hi Carl, >> >> Thanks for the review. >> >> сб, 10 апр. 2021 г. в 18:05, Carl Eugen Hoyos <ceffmpeg@gmail.com>: >> >>> Please use "&" instead of "%". >>> >> >> Fixed >> >> Please remove this line. >>> >> >> Fixed >> >> See above. >>> >> >> Fixed >> >> Please remove this line or the default branch above. >>> >> >> Fixed. It was there as a safety feature in case someone adds a new >> condition to the switch which wouldn't return. >> >> Is this an unrelated fix? >>> >> >> Yes, you are right, will submit as a separate patch. >> >> > + if (!pkt_size) >>> > + return AVERROR_BUG; >>> >>> This looks wrong or do I miss something? >>> >> >> This is also just for safety to verify that future modifications of >> spdif_read_burst_payload_length() work correctly. Should I remove it? >> >> -- >> Best regards, >> Denis Shulyaka >> > > > -- > Best regards, > Denis Shulyaka > -- Best regards, Denis Shulyaka _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] IEC61937_EAC3 decoding support 2022-01-11 15:52 ` [FFmpeg-devel] [PATCH] IEC61937_EAC3 decoding support Denis Shulyaka @ 2022-01-12 9:46 ` Anton Khirnov 2022-01-12 10:11 ` Denis Shulyaka 0 siblings, 1 reply; 3+ messages in thread From: Anton Khirnov @ 2022-01-12 9:46 UTC (permalink / raw) To: FFmpeg development discussions and patches Quoting Denis Shulyaka (2022-01-11 16:52:42) > Hi all, > > Is there anything I could do to kindly ask to review and accept the patch? Could you add a FATE test, so this code can be regression-tested automatically? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] IEC61937_EAC3 decoding support 2022-01-12 9:46 ` Anton Khirnov @ 2022-01-12 10:11 ` Denis Shulyaka 0 siblings, 0 replies; 3+ messages in thread From: Denis Shulyaka @ 2022-01-12 10:11 UTC (permalink / raw) To: FFmpeg development discussions and patches Sure, will try to figure out how to do it! ср, 12 янв. 2022 г. в 12:46, Anton Khirnov <anton@khirnov.net>: > Quoting Denis Shulyaka (2022-01-11 16:52:42) > > Hi all, > > > > Is there anything I could do to kindly ask to review and accept the > patch? > > Could you add a FATE test, so this code can be regression-tested > automatically? > > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > -- Best regards, Denis Shulyaka _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-12 10:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210410081606.557527-1-Shulyaka@gmail.com>
[not found] ` <CAB0OVGo50s-fxos8FgDw17V68uvfMRprqHS1NuCMVopZmuhr+w@mail.gmail.com>
[not found] ` <CAM_Y7Lid8mSFLjv2x4Ot1vDvh7yXfS+AQsHHTasr=EhXK7AW=g@mail.gmail.com>
[not found] ` <CAM_Y7LjGS1gP9Rz3Z-PBWTbk4PwciQVWdA30CcbrsyoEEqucKg@mail.gmail.com>
2022-01-11 15:52 ` [FFmpeg-devel] [PATCH] IEC61937_EAC3 decoding support Denis Shulyaka
2022-01-12 9:46 ` Anton Khirnov
2022-01-12 10:11 ` Denis Shulyaka
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git