* [FFmpeg-devel] [PATCH] avcodec/videotoolbox: Fix undefined symbol with minimal configuration
@ 2022-01-04 9:43 lance.lmwang
2022-01-04 23:51 ` Cameron Gutman
0 siblings, 1 reply; 5+ messages in thread
From: lance.lmwang @ 2022-01-04 9:43 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Limin Wang
From: Limin Wang <lance.lmwang@gmail.com>
Please reproduced with the following minimal configure command:
./configure --enable-shared --disable-all --enable-avcodec --enable-decoder=h264 --enable-hwaccel=h264_videotoolbox
You'll get below error:
Undefined symbols for architecture x86_64:
"_ff_videotoolbox_vpcc_extradata_create", referenced from:
_videotoolbox_start in videotoolbox.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Reported-by: Cameron Gutman <aicommander@gmail.com>
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
libavcodec/videotoolbox.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c
index 69beb38..51d4eac 100644
--- a/libavcodec/videotoolbox.c
+++ b/libavcodec/videotoolbox.c
@@ -825,11 +825,13 @@ static CFDictionaryRef videotoolbox_decoder_config_create(CMVideoCodecType codec
if (data)
CFDictionarySetValue(avc_info, CFSTR("hvcC"), data);
break;
+#if CONFIG_VP9_VIDEOTOOLBOX_HWACCEL
case kCMVideoCodecType_VP9 :
data = ff_videotoolbox_vpcc_extradata_create(avctx);
if (data)
CFDictionarySetValue(avc_info, CFSTR("vpcC"), data);
break;
+#endif
default:
break;
}
--
1.8.3.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox: Fix undefined symbol with minimal configuration
2022-01-04 9:43 [FFmpeg-devel] [PATCH] avcodec/videotoolbox: Fix undefined symbol with minimal configuration lance.lmwang
@ 2022-01-04 23:51 ` Cameron Gutman
2022-01-05 1:15 ` lance.lmwang
0 siblings, 1 reply; 5+ messages in thread
From: Cameron Gutman @ 2022-01-04 23:51 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Limin Wang
> On Jan 4, 2022, at 3:43 AM, lance.lmwang@gmail.com wrote:
>
> From: Limin Wang <lance.lmwang@gmail.com>
>
> Please reproduced with the following minimal configure command:
> ./configure --enable-shared --disable-all --enable-avcodec --enable-decoder=h264 --enable-hwaccel=h264_videotoolbox
>
> You'll get below error:
>
> Undefined symbols for architecture x86_64:
> "_ff_videotoolbox_vpcc_extradata_create", referenced from:
> _videotoolbox_start in videotoolbox.o
> ld: symbol(s) not found for architecture x86_64
> clang: error: linker command failed with exit code 1 (use -v to see invocation)
>
> Reported-by: Cameron Gutman <aicommander@gmail.com>
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
Thanks, this fixes the build break for me. Please merge it into 5.0 if possible.
Tested-by: Cameron Gutman <aicommander@gmail.com>
> libavcodec/videotoolbox.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c
> index 69beb38..51d4eac 100644
> --- a/libavcodec/videotoolbox.c
> +++ b/libavcodec/videotoolbox.c
> @@ -825,11 +825,13 @@ static CFDictionaryRef videotoolbox_decoder_config_create(CMVideoCodecType codec
> if (data)
> CFDictionarySetValue(avc_info, CFSTR("hvcC"), data);
> break;
> +#if CONFIG_VP9_VIDEOTOOLBOX_HWACCEL
> case kCMVideoCodecType_VP9 :
> data = ff_videotoolbox_vpcc_extradata_create(avctx);
> if (data)
> CFDictionarySetValue(avc_info, CFSTR("vpcC"), data);
> break;
> +#endif
> default:
> break;
> }
> --
> 1.8.3.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox: Fix undefined symbol with minimal configuration
2022-01-04 23:51 ` Cameron Gutman
@ 2022-01-05 1:15 ` lance.lmwang
2022-01-05 1:17 ` James Almer
0 siblings, 1 reply; 5+ messages in thread
From: lance.lmwang @ 2022-01-05 1:15 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Tue, Jan 04, 2022 at 05:51:56PM -0600, Cameron Gutman wrote:
>
> > On Jan 4, 2022, at 3:43 AM, lance.lmwang@gmail.com wrote:
> >
> > From: Limin Wang <lance.lmwang@gmail.com>
> >
> > Please reproduced with the following minimal configure command:
> > ./configure --enable-shared --disable-all --enable-avcodec --enable-decoder=h264 --enable-hwaccel=h264_videotoolbox
> >
> > You'll get below error:
> >
> > Undefined symbols for architecture x86_64:
> > "_ff_videotoolbox_vpcc_extradata_create", referenced from:
> > _videotoolbox_start in videotoolbox.o
> > ld: symbol(s) not found for architecture x86_64
> > clang: error: linker command failed with exit code 1 (use -v to see invocation)
> >
> > Reported-by: Cameron Gutman <aicommander@gmail.com>
> > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > ---
>
> Thanks, this fixes the build break for me. Please merge it into 5.0 if possible.
>
> Tested-by: Cameron Gutman <aicommander@gmail.com>
thank for the testing, will apply and try to merge to 5.0.
>
> > libavcodec/videotoolbox.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c
> > index 69beb38..51d4eac 100644
> > --- a/libavcodec/videotoolbox.c
> > +++ b/libavcodec/videotoolbox.c
> > @@ -825,11 +825,13 @@ static CFDictionaryRef videotoolbox_decoder_config_create(CMVideoCodecType codec
> > if (data)
> > CFDictionarySetValue(avc_info, CFSTR("hvcC"), data);
> > break;
> > +#if CONFIG_VP9_VIDEOTOOLBOX_HWACCEL
> > case kCMVideoCodecType_VP9 :
> > data = ff_videotoolbox_vpcc_extradata_create(avctx);
> > if (data)
> > CFDictionarySetValue(avc_info, CFSTR("vpcC"), data);
> > break;
> > +#endif
> > default:
> > break;
> > }
> > --
> > 1.8.3.1
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
--
Thanks,
Limin Wang
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox: Fix undefined symbol with minimal configuration
2022-01-05 1:15 ` lance.lmwang
@ 2022-01-05 1:17 ` James Almer
2022-01-05 1:21 ` lance.lmwang
0 siblings, 1 reply; 5+ messages in thread
From: James Almer @ 2022-01-05 1:17 UTC (permalink / raw)
To: ffmpeg-devel
On 1/4/2022 10:15 PM, lance.lmwang@gmail.com wrote:
> On Tue, Jan 04, 2022 at 05:51:56PM -0600, Cameron Gutman wrote:
>>
>>> On Jan 4, 2022, at 3:43 AM, lance.lmwang@gmail.com wrote:
>>>
>>> From: Limin Wang <lance.lmwang@gmail.com>
>>>
>>> Please reproduced with the following minimal configure command:
>>> ./configure --enable-shared --disable-all --enable-avcodec --enable-decoder=h264 --enable-hwaccel=h264_videotoolbox
>>>
>>> You'll get below error:
>>>
>>> Undefined symbols for architecture x86_64:
>>> "_ff_videotoolbox_vpcc_extradata_create", referenced from:
>>> _videotoolbox_start in videotoolbox.o
>>> ld: symbol(s) not found for architecture x86_64
>>> clang: error: linker command failed with exit code 1 (use -v to see invocation)
>>>
>>> Reported-by: Cameron Gutman <aicommander@gmail.com>
>>> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
>>> ---
>>
>> Thanks, this fixes the build break for me. Please merge it into 5.0 if possible.
>>
>> Tested-by: Cameron Gutman <aicommander@gmail.com>
>
> thank for the testing, will apply and try to merge to 5.0.
A cherry-pick should work without conflicts for this change.
>
>>
>>> libavcodec/videotoolbox.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c
>>> index 69beb38..51d4eac 100644
>>> --- a/libavcodec/videotoolbox.c
>>> +++ b/libavcodec/videotoolbox.c
>>> @@ -825,11 +825,13 @@ static CFDictionaryRef videotoolbox_decoder_config_create(CMVideoCodecType codec
>>> if (data)
>>> CFDictionarySetValue(avc_info, CFSTR("hvcC"), data);
>>> break;
>>> +#if CONFIG_VP9_VIDEOTOOLBOX_HWACCEL
>>> case kCMVideoCodecType_VP9 :
>>> data = ff_videotoolbox_vpcc_extradata_create(avctx);
>>> if (data)
>>> CFDictionarySetValue(avc_info, CFSTR("vpcC"), data);
>>> break;
>>> +#endif
>>> default:
>>> break;
>>> }
>>> --
>>> 1.8.3.1
>>>
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel@ffmpeg.org
>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>
>>> To unsubscribe, visit link above, or email
>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox: Fix undefined symbol with minimal configuration
2022-01-05 1:17 ` James Almer
@ 2022-01-05 1:21 ` lance.lmwang
0 siblings, 0 replies; 5+ messages in thread
From: lance.lmwang @ 2022-01-05 1:21 UTC (permalink / raw)
To: ffmpeg-devel
On Tue, Jan 04, 2022 at 10:17:17PM -0300, James Almer wrote:
>
>
> On 1/4/2022 10:15 PM, lance.lmwang@gmail.com wrote:
> > On Tue, Jan 04, 2022 at 05:51:56PM -0600, Cameron Gutman wrote:
> > >
> > > > On Jan 4, 2022, at 3:43 AM, lance.lmwang@gmail.com wrote:
> > > >
> > > > From: Limin Wang <lance.lmwang@gmail.com>
> > > >
> > > > Please reproduced with the following minimal configure command:
> > > > ./configure --enable-shared --disable-all --enable-avcodec --enable-decoder=h264 --enable-hwaccel=h264_videotoolbox
> > > >
> > > > You'll get below error:
> > > >
> > > > Undefined symbols for architecture x86_64:
> > > > "_ff_videotoolbox_vpcc_extradata_create", referenced from:
> > > > _videotoolbox_start in videotoolbox.o
> > > > ld: symbol(s) not found for architecture x86_64
> > > > clang: error: linker command failed with exit code 1 (use -v to see invocation)
> > > >
> > > > Reported-by: Cameron Gutman <aicommander@gmail.com>
> > > > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > > > ---
> > >
> > > Thanks, this fixes the build break for me. Please merge it into 5.0 if possible.
> > >
> > > Tested-by: Cameron Gutman <aicommander@gmail.com>
> >
> > thank for the testing, will apply and try to merge to 5.0.
>
> A cherry-pick should work without conflicts for this change.
Yes, I'm glad to use cherry-pick for merge always.
>
> >
> > >
> > > > libavcodec/videotoolbox.c | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c
> > > > index 69beb38..51d4eac 100644
> > > > --- a/libavcodec/videotoolbox.c
> > > > +++ b/libavcodec/videotoolbox.c
> > > > @@ -825,11 +825,13 @@ static CFDictionaryRef videotoolbox_decoder_config_create(CMVideoCodecType codec
> > > > if (data)
> > > > CFDictionarySetValue(avc_info, CFSTR("hvcC"), data);
> > > > break;
> > > > +#if CONFIG_VP9_VIDEOTOOLBOX_HWACCEL
> > > > case kCMVideoCodecType_VP9 :
> > > > data = ff_videotoolbox_vpcc_extradata_create(avctx);
> > > > if (data)
> > > > CFDictionarySetValue(avc_info, CFSTR("vpcC"), data);
> > > > break;
> > > > +#endif
> > > > default:
> > > > break;
> > > > }
> > > > --
> > > > 1.8.3.1
> > > >
> > > > _______________________________________________
> > > > ffmpeg-devel mailing list
> > > > ffmpeg-devel@ffmpeg.org
> > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > > >
> > > > To unsubscribe, visit link above, or email
> > > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> > >
> >
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
--
Thanks,
Limin Wang
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-05 1:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-04 9:43 [FFmpeg-devel] [PATCH] avcodec/videotoolbox: Fix undefined symbol with minimal configuration lance.lmwang
2022-01-04 23:51 ` Cameron Gutman
2022-01-05 1:15 ` lance.lmwang
2022-01-05 1:17 ` James Almer
2022-01-05 1:21 ` lance.lmwang
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git