From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1AF1C40CDA for ; Thu, 30 Dec 2021 10:12:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 510B268AE9B; Thu, 30 Dec 2021 12:12:54 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9C81268AC57 for ; Thu, 30 Dec 2021 12:12:47 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id F114E24017C; Thu, 30 Dec 2021 11:12:46 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id yHe9DfL9KXGz; Thu, 30 Dec 2021 11:12:46 +0100 (CET) Received: from lain.red.khirnov.net (lain.red.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.red.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 5F256240179; Thu, 30 Dec 2021 11:12:46 +0100 (CET) Received: by lain.red.khirnov.net (Postfix, from userid 1000) id 75CCC16008E; Thu, 30 Dec 2021 11:12:46 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: =?utf-8?q?=3CAM7PR03MB666018C7CB003E2C0AA05D348F769=40AM7PR03MB?= =?utf-8?q?6660=2Eeurprd03=2Eprod=2Eoutlook=2Ecom=3E?= References: =?utf-8?q?=3CAM7PR03MB666072BE629D71EFF7053C138F769=40AM7PR03MB6?= =?utf-8?q?660=2Eeurprd03=2Eprod=2Eoutlook=2Ecom=3E_=3CAM7PR03MB666018C7CB00?= =?utf-8?q?3E2C0AA05D348F769=40AM7PR03MB6660=2Eeurprd03=2Eprod=2Eoutlook=2Ec?= =?utf-8?q?om=3E?= Mail-Followup-To: FFmpeg development discussions and patches , Andreas Rheinhardt Date: Thu, 30 Dec 2021 11:12:46 +0100 Message-ID: <164085916638.2375.6835847434776821902@lain.red.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 04/11] avcodec/ac3tab: Unavpriv ac3_channel_layout_tab X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Andreas Rheinhardt (2021-12-15 13:35:34) > It is small (16 B) and therefore the overhead of exporting it more > than outweighs the size savings from not having duplicated symbols: > When the symbol is no longer avpriv, one saves twice the size of > the string containing the symbols name (2x30 byte), two entries > in .dynsym (24 bytes each on x64), one entry in the importing libraries > .got and .rela.dyn (8 + 24 bytes on x64) and two entries for the > symbol version (2 bytes each) and one hash value in the exporting > library (4 bytes). > (The exact numbers are of course different for other platforms > (e.g. when using dlls), but given that the strings saved alone > more than outweigh the array size it can be presumed that this > is beneficial for all platforms.) > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/Makefile | 12 +++++--- > libavcodec/ac3_channel_layout_tab.c | 22 +++++++++++++++ > libavcodec/ac3_channel_layout_tab.h | 41 ++++++++++++++++++++++++++++ > libavcodec/ac3_parser.c | 2 +- > libavcodec/ac3dec.c | 4 +-- > libavcodec/ac3enc.h | 1 + > libavcodec/ac3tab.c | 14 ---------- > libavcodec/ac3tab.h | 4 +-- > libavcodec/eac3_data.c | 2 ++ > libavformat/Makefile | 2 ++ > libavformat/ac3_channel_layout_tab.c | 22 +++++++++++++++ > libavformat/hls_sample_encryption.c | 4 ++- > libavformat/mov.c | 4 +-- > 13 files changed, 107 insertions(+), 27 deletions(-) > create mode 100644 libavcodec/ac3_channel_layout_tab.c > create mode 100644 libavcodec/ac3_channel_layout_tab.h > create mode 100644 libavformat/ac3_channel_layout_tab.c > > diff --git a/libavcodec/ac3enc.h b/libavcodec/ac3enc.h > index ec9ead8a4e..39a41fe0b0 100644 > --- a/libavcodec/ac3enc.h > +++ b/libavcodec/ac3enc.h > @@ -35,6 +35,7 @@ > #include "ac3dsp.h" > #include "avcodec.h" > #include "fft.h" > +#include "internal.h" ? > diff --git a/libavcodec/eac3_data.c b/libavcodec/eac3_data.c > index b159e1682f..2ef0e2053c 100644 > --- a/libavcodec/eac3_data.c > +++ b/libavcodec/eac3_data.c > @@ -24,6 +24,8 @@ > * Tables taken directly from the E-AC-3 spec. > */ > > +#include ?? > diff --git a/libavformat/hls_sample_encryption.c b/libavformat/hls_sample_encryption.c > index 38795c7fb0..3dbaff717e 100644 > --- a/libavformat/hls_sample_encryption.c > +++ b/libavformat/hls_sample_encryption.c > @@ -26,6 +26,8 @@ > * https://developer.apple.com/library/ios/documentation/AudioVideo/Conceptual/HLS_Sample_Encryption > */ > > +#include "libavutil/channel_layout.h" ??? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".