From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 4/4] avcodec/tiff: Use ff_set_dimensions() for setting up mjpeg context dimensions
Date: Mon, 20 Dec 2021 15:32:05 +0100
Message-ID: <164001072509.13029.15596413999190684225@lain.red.khirnov.net> (raw)
In-Reply-To: <20211220105021.GQ2829255@pb2>
Quoting Michael Niedermayer (2021-12-20 11:50:21)
> On Mon, Dec 20, 2021 at 10:51:56AM +0100, Anton Khirnov wrote:
> > Quoting Michael Niedermayer (2021-12-17 22:51:55)
> > > Fixes: OOM
> >
> > This is very non-obvious and could use more explanation.
>
> I guess its obvious to me as ive seen this bug more than once
> the problem is that directly setting width/height leaves
> coded_w/h unset, then something sets coded_w/h and next time
> width/height is set again it is unrelated to the still set
> coded_w/h and theres a FFMAX() between coded_w and width
> so the image allocated is much bigger
> ff_set_dimension() breaks this chain by setting both width and
> coded_width
>
> should i add this long explanation above to the commit message
> or something shorter like
> "sets coded_width / coded_height too to keep them consistent with
> width / height"
Either is fine with me.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2021-12-20 14:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 21:51 [FFmpeg-devel] [PATCH 1/4] avcodec/ass: Faster ff_ass_add_rect() Michael Niedermayer
2021-12-17 21:51 ` [FFmpeg-devel] [PATCH 2/4] avcodec/ccaption_dec: Use ff_ass_add_rect2() Michael Niedermayer
2021-12-17 21:51 ` [FFmpeg-devel] [PATCH 3/4] avcodec/tiff: Pass max_pixels to mjpeg context Michael Niedermayer
2021-12-17 21:51 ` [FFmpeg-devel] [PATCH 4/4] avcodec/tiff: Use ff_set_dimensions() for setting up mjpeg context dimensions Michael Niedermayer
2021-12-20 9:51 ` Anton Khirnov
2021-12-20 10:50 ` Michael Niedermayer
2021-12-20 14:32 ` Anton Khirnov [this message]
2021-12-23 13:56 ` Michael Niedermayer
2021-12-17 22:15 ` [FFmpeg-devel] [PATCH 1/4] avcodec/ass: Faster ff_ass_add_rect() Andreas Rheinhardt
2021-12-18 14:27 ` Michael Niedermayer
2021-12-18 16:21 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164001072509.13029.15596413999190684225@lain.red.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git