From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EC74F451F6 for ; Mon, 12 Jun 2023 08:12:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4FC2268C348; Mon, 12 Jun 2023 11:12:21 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9E6FE68C1EE for ; Mon, 12 Jun 2023 11:12:15 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 35C8CE2T020428-35C8CE2U020428; Mon, 12 Jun 2023 11:12:14 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id D3168A145F; Mon, 12 Jun 2023 11:12:14 +0300 (EEST) Date: Mon, 12 Jun 2023 11:12:14 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20230604041756.5196-4-Logan.Lyu@myais.com.cn> Message-ID: <163da5c-acb4-a0e4-a2e-6d1b71ac8dab@martin.st> References: <20230604041756.5196-1-Logan.Lyu@myais.com.cn> <20230604041756.5196-4-Logan.Lyu@myais.com.cn> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 4/5] lavc/aarch64: new optimization for 8-bit hevc_epel_h X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Logan Lyu Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 4 Jun 2023, Logan.Lyu@myais.com.cn wrote: > From: Logan Lyu > > Signed-off-by: Logan Lyu > --- > libavcodec/aarch64/hevcdsp_epel_neon.S | 343 ++++++++++++++++++++++ > libavcodec/aarch64/hevcdsp_init_aarch64.c | 7 +- > 2 files changed, 349 insertions(+), 1 deletion(-) > + st2 {v20.8h, v21.8h}, [x7] > + subs w3, w3, #1 // height > + b.ne 1b > + ret In general, place the loop counter decrement somewhere else than exactly before the branch that depends on the result. E.g. after the initial loads is usually a good place, or between the st1/2 instructions and the instructions that calculate the final output values. The same goes probably for all places in all these patches. > @@ -283,13 +287,14 @@ av_cold void ff_hevc_dsp_init_aarch64(HEVCDSPContext *c, const int bit_depth) > NEON8_FNASSIGN_PARTIAL_4(c->put_hevc_qpel_uni_w, 1, 0, qpel_uni_w_v,); > > if (have_i8mm(cpu_flags)) { > + NEON8_FNASSIGN(c->put_hevc_epel, 0, 1, epel_h, _i8mm); > NEON8_FNASSIGN(c->put_hevc_epel_uni_w, 0, 1, epel_uni_w_h ,_i8mm); > NEON8_FNASSIGN(c->put_hevc_qpel, 0, 1, qpel_h, _i8mm); > NEON8_FNASSIGN(c->put_hevc_qpel_uni_w, 0, 1, qpel_uni_w_h, _i8mm); > NEON8_FNASSIGN_PARTIAL_5(c->put_hevc_qpel_uni_w, 1, 1, qpel_uni_w_hv, _i8mm); > } > - > } > + > if (bit_depth == 10) { Here are some stray unrelated whitespace changes. Other than that, this patch looks mostly reasonable. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".