From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1729B422D5 for ; Fri, 17 Dec 2021 09:33:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B960168ABAC; Fri, 17 Dec 2021 11:33:22 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0FF2A68A35C for ; Fri, 17 Dec 2021 11:33:17 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 09FCB24017C for ; Fri, 17 Dec 2021 10:33:16 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id cTIwNLXTmOh2 for ; Fri, 17 Dec 2021 10:33:14 +0100 (CET) Received: from lain.red.khirnov.net (lain.red.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.red.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 97494240179 for ; Fri, 17 Dec 2021 10:33:14 +0100 (CET) Received: by lain.red.khirnov.net (Postfix, from userid 1000) id 1464E16008E; Fri, 17 Dec 2021 10:33:11 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: =?utf-8?q?=3CAM7PR03MB6660BB984A5F6EC164D19B4C8F789=40AM7PR03MB?= =?utf-8?q?6660=2Eeurprd03=2Eprod=2Eoutlook=2Ecom=3E?= References: <20211213152042.5900-1-anton@khirnov.net> <20211213152042.5900-5-anton@khirnov.net> =?utf-8?q?=3CAM7PR03MB6660BB984A5?= =?utf-8?q?F6EC164D19B4C8F789=40AM7PR03MB6660=2Eeurprd03=2Eprod=2Eoutlook=2E?= =?utf-8?q?com=3E?= Mail-Followup-To: FFmpeg development discussions and patches Date: Fri, 17 Dec 2021 10:33:11 +0100 Message-ID: <163973359101.13029.8183236648046984224@lain.red.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 05/24] ffmpeg: move some muxing-related code into a separate file X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Andreas Rheinhardt (2021-12-17 02:55:43) > Anton Khirnov: > > This is a first step towards making muxers more independent from the > > rest of the code. > > --- > > fftools/Makefile | 11 +- > > fftools/ffmpeg.c | 273 ++-------------------------------------- > > fftools/ffmpeg.h | 10 ++ > > fftools/ffmpeg_mux.c | 293 +++++++++++++++++++++++++++++++++++++++++++ > > 4 files changed, 320 insertions(+), 267 deletions(-) > > create mode 100644 fftools/ffmpeg_mux.c > > > > diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c > > new file mode 100644 > > index 0000000000..e7c6ddd8f8 > > --- /dev/null > > +++ b/fftools/ffmpeg_mux.c > > @@ -0,0 +1,293 @@ > > +/* > > + * This file is part of FFmpeg. > > + * > > + * FFmpeg is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU Lesser General Public > > + * License as published by the Free Software Foundation; either > > + * version 2.1 of the License, or (at your option) any later version. > > + * > > + * FFmpeg is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > + * Lesser General Public License for more details. > > + * > > + * You should have received a copy of the GNU Lesser General Public > > + * License along with FFmpeg; if not, write to the Free Software > > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA > > + */ > > + > > +#include > > +#include > > + > > +#include "libavformat/avformat.h" > > +#include "libavformat/avio.h" > > + > > +#include "libavcodec/packet.h" > > + > > +#include "libavutil/fifo.h" > > +#include "libavutil/intreadwrite.h" > > +#include "libavutil/log.h" > > +#include "libavutil/mem.h" > > +#include "libavutil/timestamp.h" > > + > > +#include "ffmpeg.h" > > + > > These library headers are ordered reversely to our usual order. Is > this intended? I am not aware of there being a usual order. So no, it's not. > (It has the advantage that e.g. missing lavu headers > in the lavf headers could be uncovered.) Won't make checkheaders also find that? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".