From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 383A441A61 for ; Wed, 15 Dec 2021 19:36:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6E23468AD3D; Wed, 15 Dec 2021 21:36:34 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1332268AB2E for ; Wed, 15 Dec 2021 21:36:28 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 930BE24017C for ; Wed, 15 Dec 2021 20:36:26 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id FvzDBsMSpbC7 for ; Wed, 15 Dec 2021 20:36:25 +0100 (CET) Received: from lain.red.khirnov.net (lain.red.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.red.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id D2167240179 for ; Wed, 15 Dec 2021 20:36:25 +0100 (CET) Received: by lain.red.khirnov.net (Postfix, from userid 1000) id E773816008E; Wed, 15 Dec 2021 20:36:25 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20211214211343.GP2829255@pb2> References: <20211213152042.5900-1-anton@khirnov.net> <20211213152042.5900-23-anton@khirnov.net> <20211214211343.GP2829255@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 15 Dec 2021 20:36:25 +0100 Message-ID: <163959698589.13029.5805519215876153824@lain.red.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 23/24] ffmpeg: simplify the use of OutputStream.frame_number X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2021-12-14 22:13:43) > On Mon, Dec 13, 2021 at 04:20:41PM +0100, Anton Khirnov wrote: > > It features in limiting the number of output frames (-frames option) and > > currently can be incremented from two places: > > - for video encoding (not streamcopy), in do_video_out() after each > > successful avcodec_send_frame() call > > - for all other cases, in of_submit_packet() > > > > Not only is this inconsistent and confusing, but also the special > > treatment for video encoding is redundant, since > > AVCodecContext.frame_count stores the exact same value (number of > > successful avcodec_send_frame()) calls. > > > > Replace the use of OutputStream.frame_count in do_video_out() with > > AVCodecContext.frame_count. Modify OutputStream.frame_count in the same > > way for all streams. > > --- > > fftools/ffmpeg.c | 9 ++++----- > > fftools/ffmpeg_mux.c | 19 +++++++------------ > > 2 files changed, 11 insertions(+), 17 deletions(-) > > This results in differences > one is: > ./ffmpeg -i ~/tickets/4072/CoP\ 1\ 1\ 3\ -M.avi -vframes 2 -bitexact -vcodec huffyuv /tmp/4072-fic-old.avi > > -rw-r----- 1 michael michael 3572792 Dez 14 22:09 /tmp/4072-fic-new.avi > -rw-r----- 1 michael michael 1908172 Dez 14 22:10 /tmp/4072-fic-old.avi > > I see other differences caused by patches today i still need to investigate > what causes what Fixing this will require larger restructuring first, so I am dropping this patch for now. Please let me know if the rest of the set breaks anything else. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".