From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BCF7243296 for ; Sat, 28 May 2022 04:06:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BB60A68B4D4; Sat, 28 May 2022 07:05:57 +0300 (EEST) Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B186568B45D for ; Sat, 28 May 2022 07:05:50 +0300 (EEST) Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4L97Pl02Lbz9sQX for ; Sat, 28 May 2022 06:05:47 +0200 (CEST) Message-ID: <162ec7ca-1377-0e11-b60e-5ee04d8441a8@gyani.pro> Date: Sat, 28 May 2022 09:35:36 +0530 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220527082922.994-1-ffmpeg@gyani.pro> From: Gyan Doshi In-Reply-To: X-Rspamd-Queue-Id: 4L97Pl02Lbz9sQX Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: remove support for x262 MPEG-2 encoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2022-05-27 08:46 pm, Kieran Kunhya wrote: > On Fri, 27 May 2022 at 09:30, Gyan Doshi wrote: > >> Support for 'libx262' was added in e56f14659f by merging >> Libav e1319aa1c1. >> >> The Libav commit author believed that "x262 is a subfeature of x264" >> but this is not the case. Kieran Kuhnya added support for MPEG-2 >> encoding in *his fork* of x264. >> See https://github.com/kierank/x262/commit/6851000e27 >> > x262 is a VideoLAN project: https://git.videolan.org/?p=x262.git;a=summary > > >> So there are two issues: >> 1) Our configure enables libx262 implicitly if libx264 is enabled >> and a x262 constant is defined in x264.h; this will never be fulfilled >> with native x264. Users would have to build x262 and use the libx264 >> generated there. Which brings us to the 2nd issue. >> > Yes, there was some reason that I forget that meant we couldn't have a > single binary doing both. > And mainline x264 will never merge x262. > > >> 2) Development on the x262 repo stopped in 2015. So, it's likely API >> and ABI incompatible with native x264 and thus our current wrapper. >> > x262 works fine irrespective of lack of development. MPEG-2 came out in > 1993 after all. By development, I mean you merging updates to native x264 into your repo. That stopped in 2015. So, your repo only supports one bit-depth in a build, right? Regards, Gyan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".