From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A55B04941A for ; Tue, 12 Mar 2024 00:57:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A364768D0AE; Tue, 12 Mar 2024 02:57:54 +0200 (EET) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 29FB168D063 for ; Tue, 12 Mar 2024 02:57:48 +0200 (EET) Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-5c229dabbb6so3683106a12.0 for ; Mon, 11 Mar 2024 17:57:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710205065; x=1710809865; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oKsR8yuS/P2Eaao9ZV9Q600u3jRMnstIiXbSvyQ/K0U=; b=IIG2wbMg+qgIQKYvvGw+hjk6SA+T5vQEpsB8si5ljd4lyk861DhWUl3nOJMSVVUg1h nEqrbQRA+pG3roM/n6AL5POwmmHW6SnFGIs1/Kje57kzMgo4oIUc7QNaM95XUu4LzDaz bP+9V8153W1s2mX7D5j+f9mtUqNtX9u3qr/e45wzsocZqeXweZCKL6H53p9+eCGlpx6z O1H+5kdoxQGBrUUry5FjICDfGiFZ6aAB5nkStTeklD9b5AgtEJbimzB7WBsvBZ3wn3Jj RFtIIRo55xKcyotwE2xOQOzkAsQ4EAIdhrXt56l2/iH8jo93C/buQPQoTycXKvoyu8kg kE6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710205065; x=1710809865; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oKsR8yuS/P2Eaao9ZV9Q600u3jRMnstIiXbSvyQ/K0U=; b=SvHmy22QnGeLu4zMuUY4+SIs3F5MB5Kr+OoNt2QKk8totUdbquVrbT4Ve06XuoJodE LrAyayliDyZbjjl3tzQrBRx+R2z/qO7xDXb0CP1zJc7QRUkBZ5UuXwYbxXhnn9Cu97yF IFW0H7u11oILnhYPfb0JHGwU0ix86prtlCdXabKM1yeKvAXOBQozIX3Wa3JpC5UJOwO6 gcdiBc/9rORHVJa6IGK7OGSUicRs7emt7wyZY7ksyxlIWG9a1azPYzzONwkAXYEHGIpA ndIGhXJeoCF0g988qTd5uSNKJI7npdgwZA7BV6FECX2uad2litQAdEcIcbbK7iSPq//+ 8eAQ== X-Gm-Message-State: AOJu0YxoVwzUCo3DC9iOa5f+2RoSY9qc/84BYwxXxY6jo0woxnanrHzl xCJxwRr0OJFGwIXO4mykH9aknnkotSm3/o5+eOrO4zEUmwxJOJDEaDeIgC26 X-Google-Smtp-Source: AGHT+IFEShtM69+X55Mk2xH4lj/Jt38nLJ9edUxI9+6Pip0UDlHu6oIFi9bJpExfqWXJbRQGgzqz6Q== X-Received: by 2002:a05:6a20:12c9:b0:1a3:113a:bbd5 with SMTP id v9-20020a056a2012c900b001a3113abbd5mr468231pzg.40.1710205065150; Mon, 11 Mar 2024 17:57:45 -0700 (PDT) Received: from [192.168.0.10] ([190.194.169.124]) by smtp.gmail.com with ESMTPSA id gz8-20020a17090b0ec800b0029baf24ee51sm6131244pjb.48.2024.03.11.17.57.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Mar 2024 17:57:44 -0700 (PDT) Message-ID: <15ff0462-6e6b-40bc-a691-3dc3389b20d5@gmail.com> Date: Mon, 11 Mar 2024 21:57:45 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240311185331.84556-1-post@frankplowman.com> <20240312004919.GV6420@pb2> From: James Almer In-Reply-To: <20240312004919.GV6420@pb2> Subject: Re: [FFmpeg-devel] [PATCH] lavc/vvc: AVERROR_PATCHWELCOME for subpictures X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/11/2024 9:49 PM, Michael Niedermayer wrote: > On Mon, Mar 11, 2024 at 06:53:31PM +0000, Frank Plowman wrote: >> VVC's subpictures feature is not yet implemented in the native decoder. >> Throw an AVERROR_PATCHWELCOME when trying to decode a bitstream using >> the feature. Fixes crashes when trying to decode bitstreams which >> use the feature. >> >> Signed-off-by: Frank Plowman >> --- >> libavcodec/vvc/vvc_ps.c | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) > > This breaks fate-vvc-conformance-SUBPIC_A_3 > > make fate-vvc-conformance-SUBPIC_A_3 > TEST vvc-conformance-SUBPIC_A_3 > --- ./tests/ref/fate/vvc-conformance-SUBPIC_A_3 2024-03-05 02:37:36.235300141 +0100 > +++ tests/data/fate/vvc-conformance-SUBPIC_A_3 2024-03-12 01:47:27.301593567 +0100 > @@ -1,9 +0,0 @@ > -#tb 0: 1/25 > -#media_type 0: video > -#codec_id 0: rawvideo > -#dimensions 0: 1920x1080 > -#sar 0: 0/1 > -0, 0, 0, 1, 6220800, 0xa419cfb6 > -0, 1, 1, 1, 6220800, 0xa419cfb6 > -0, 2, 2, 1, 6220800, 0xa419cfb6 > -0, 3, 3, 1, 6220800, 0xa419cfb6 > Test vvc-conformance-SUBPIC_A_3 failed. Look at tests/data/fate/vvc-conformance-SUBPIC_A_3.err for details. > tests/Makefile:318: recipe for target 'fate-vvc-conformance-SUBPIC_A_3' failed > make: *** [fate-vvc-conformance-SUBPIC_A_3] Error 69 > > thx The sample appears to decode fine and doesn't crash, although all four frames are exactly the same (I don't know is that's intended). Maybe the crashes can be fixed in some other form? And abort only if FF_COMPLIANCE_STRICT is requested. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".