From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id 885064BE8A
	for <ffmpegdev@gitmailbox.com>; Sat,  5 Apr 2025 17:38:11 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8CA18687D94;
	Sat,  5 Apr 2025 20:38:06 +0300 (EEST)
Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 648A5687D8B
 for <ffmpeg-devel@ffmpeg.org>; Sat,  5 Apr 2025 20:37:59 +0300 (EEST)
Received: from fews01-sea.riseup.net (fews01-sea-pn.riseup.net [10.0.1.109])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by mx1.riseup.net (Postfix) with ESMTPS id 4ZVN3G0byFzDqNV;
 Sat,  5 Apr 2025 17:37:46 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak;
 t=1743874677; bh=z8eflE3i3WzYIegWT3GwfD4JAZDJ9dFCA0ZGmbYcgH8=;
 h=Date:Subject:To:References:From:In-Reply-To:From;
 b=DTPzNWlVDGhIDmTBYtnyBjuHNsy2FxqYAINWjmqhocLOyr7OLwoJvpgPMwl/lc9oc
 rXBgbo6UQe8efkPuSODMqesv15WwgCK1LnOBlcHm+C4oEgXIyL6UH0x2zflHcUKlVr
 YgfsQSKF0OIKaxu84IcSoNzFrqzStfUu0svVA19Q=
X-Riseup-User-ID: 04B1255C938641954591A3AD23E12DAD55E8AA0A4114BC7F83104019B763ACB5
Received: from [127.0.0.1] (localhost [127.0.0.1])
 by fews01-sea.riseup.net (Postfix) with ESMTPSA id 4ZVN3F1SwXzJsQT;
 Sat,  5 Apr 2025 17:37:44 +0000 (UTC)
Message-ID: <15c3c9ad-8c6c-464c-96b0-0040a98079a7@riseup.net>
Date: Sat, 5 Apr 2025 14:37:28 -0300
MIME-Version: 1.0
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>,
 Michael Niedermayer <michael@niedermayer.cc>
References: <20250312-video-only-kf-recover-v1-1-1e0e340da663@riseup.net>
 <20250329225718.GS4991@pb2>
Content-Language: en-US
From: Arthur Grillo <arthurgrillo@riseup.net>
In-Reply-To: <20250329225718.GS4991@pb2>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/fifo: Check for keyframe video
 type before stop dropping
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/15c3c9ad-8c6c-464c-96b0-0040a98079a7@riseup.net/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>



On 29/03/25 7:57 PM, Michael Niedermayer wrote:
> Hi Arthur
> 
> On Wed, Mar 12, 2025 at 03:45:42PM -0300, Arthur Grillo wrote:
>> The current behavior when using restart_with_keyframe is that it will
>> recover if it also encounters any audio packet, as they are flagged as a
>> keyframe.
>>
>> The expectation is that packets are dropped until the next _video_
>> keyframe.
>>
>> Fix that by checking the packet stream codec type, only letting it
>> recover when it is a video one.
>>
>> Fixes ticket: #11467
>>
>> Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net>
>> ---
>> Cc: lingjiujianke@gmail.com
>> ---
>>  libavformat/fifo.c | 11 +++++++++--
>>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> What happens if there is no video stream ?
> 
> thx

Well noted, I will add a check for the existence of a video stream, if
no video stream is found, it will resume to the original behavior of not
caring about the stream type.

Regards,
~Grillo


> 
> [...]
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".