Re: [FFmpeg-devel] [PATCH v3 01/10] channel_layout: add new channel positions supported by xHE-AAC

[Lynne via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

[-- Attachment #1.1.1.1: Type: text/plain, Size: 982 bytes --]

On 27/05/2024 10:40, Anton Khirnov wrote:
> Quoting Lynne via ffmpeg-devel (2024-05-26 23:42:41)
>> ...its an enum entry. Do you want a design document and a proposal?
>> You could talk to the person who did the research about it, JEEB.
>> Why wait at all? There's only you and JEEB that care about channel
>> layouts, you can review it and give it an LGTM. There's no reason to
>> wait for days, that is not how reviewing is supposed to work.
> 
> That's exactly how reviewing is supposed to work. Waiting a few days
> won't kill anyone and allows more people to comment.
> 
> To the contrary I'm quite unhappy with some recent instances of
> developers pushing code immediately upon seeing an LGTM, without giving
> other people the opportunity to look at it.

I'd understand if it was for generic common code, but if its for code 
that the one pushing it maintains, I don't see a problem with this, this 
is how it works in pretty much every project out there.

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".