Re: [FFmpeg-devel] [PATCH] mov: Reduce the verbosity of the warning about fragmented MP4 vs advanced edit lists

["Martin Storsjö" <martin@martin.st>]

On Mon, 23 Jan 2023, Derek Buitenhuis wrote:

> On 1/17/2023 9:31 AM, Martin Storsjö wrote:
>> Only warn if the advanced_editlist option is enabled (it is enabled
>> by default though) so we don't print one warning for each track, and
>> demote the warning to AV_LOG_LEVEL_VERBOSE; this message does get
>> generated whenever parsing a fragmented MP4 file, regardless of
>> whether the file actually uses multiple edits or not.
>> 
>> Later when parsing the mov structures, the demuxer does warn if
>> the file did contain multiple edits which would require the
>> advanced_editlist option enabled for decoding correctly.
>> 
>> Adjust the warning message for the case when the file seemed like it
>> actually would have needed handling of advanced edit lists, to
>> reflect the fact that it doesn't help to try set the option as
>> it has been automatically disabled.
>> ---
>>  libavformat/isom.h |  1 +
>>  libavformat/mov.c  | 20 ++++++++++++++------
>>  2 files changed, 15 insertions(+), 6 deletions(-)
>
> LGTM.

Pushed now, thanks!

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".