From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 52EAC43D1A for ; Mon, 8 Aug 2022 13:42:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3F2F468B734; Mon, 8 Aug 2022 16:42:34 +0300 (EEST) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5839568B449 for ; Mon, 8 Aug 2022 16:42:27 +0300 (EEST) Received: by mail-wm1-f53.google.com with SMTP id a11so4816385wmq.3 for ; Mon, 08 Aug 2022 06:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:from:to:references :in-reply-to:content-transfer-encoding; bh=tInGYrUKmuZLdc5q4xmzKgKzQx2HI6CFmcQil1RIgc8=; b=FjnVDXO731ADUk7TlZSwV73DPd1JH+ZiVKwtLep/p4jbuMgSH7yWA8CJAMPp+5AVxI nZ5ZGD7LlIkkk0Dc2VDi9h3nngp+YbsqwZ8hr6KjMt4abR1bnEinrISNx/pM+Gv5xvt2 KQJ8qUG0POCuCW2ksjWDiUstpLoExNDhNWiDEeXrBgmi18kpkHGMBAxA766klPww+ISw 5xCwhQU1OH1SzyBdVSe9WTHBEJDvlr0dnIu8XLgIImn6WL3efwS49fbMGGsuM5qvyr3w BcgZ6xD2qMTkEgp/DFi+vrP1nxQhzY5/7v/atIys7AUNiKNs+Fyv3nWQz2ynUn2v3mAy R32A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :from:to:references:in-reply-to:content-transfer-encoding; bh=tInGYrUKmuZLdc5q4xmzKgKzQx2HI6CFmcQil1RIgc8=; b=Bwi1vP7Yw04dG8VMPPhVOEujvWZHYYol46cdUEznBj+wCp0V394hBZzdElxgYjTTEV xXTAU3hOkANfA8fu8GQUdzAQtR3Z40rtYP6G5xLgCz5WIt9ZqsuFY5ByiI6n9x4/04ep KPS54OkgnUtGSZfE3+wZwzof5aRRVRVbIkwZBCsVG7DrZmPHR4TeRH294vvzP3nUAT4h VkWxt4B8Iet8bEwgp9Jsx13ZuJrSm2wnozDs/JehQ5DoeOFBlltUT3S8iGtN8Nb5LSEv 5XJ0aoZrpmnrywsisrLFeCpE0MUNc6qrpyNdcjW+t5XiJtRpG+BJB2DMeFOsawaHCKGf PZ+A== X-Gm-Message-State: ACgBeo2K8VWeafKf/NI/JrqATQ6MBqWJpeu0JApXM/XwolBjCn8sqBVv fLbDZTykIxcpVZ+xquanyopGh9fmW68= X-Google-Smtp-Source: AA6agR4uN0K7SdCgic/RM4X3jAIdsW43NY7X/d4dMwu2r180Kbx8RRwOOV4VcG8N3MXT9XW2Y5nDLw== X-Received: by 2002:a05:600c:3b21:b0:3a5:2348:5a1c with SMTP id m33-20020a05600c3b2100b003a523485a1cmr8595099wms.129.1659966146191; Mon, 08 Aug 2022 06:42:26 -0700 (PDT) Received: from [192.168.1.106] ([149.12.10.163]) by smtp.googlemail.com with ESMTPSA id f13-20020a05600c4e8d00b003a319b67f64sm44224677wmq.0.2022.08.08.06.42.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Aug 2022 06:42:25 -0700 (PDT) Message-ID: <15551395-4a68-b71e-1ad4-07ac61ebed51@gmail.com> Date: Mon, 8 Aug 2022 14:42:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 From: Derek Buitenhuis To: ffmpeg-devel@ffmpeg.org References: <20220803131859.167392-1-derek.buitenhuis@gmail.com> In-Reply-To: <20220803131859.167392-1-derek.buitenhuis@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH v2] mov: Compare frag times in correct time base when seeking a stream without a corresponding sidx X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 8/3/2022 2:18 PM, Derek Buitenhuis wrote: > Some muxers, such as GPAC, create files with only one sidx, but two streams > muxed into the same fragments pointed to by this sidx. > > Prevously, in such a case, when we seeked in such files, we fell back > to, for example, using the sidx associated with the video stream, to > seek the audio stream, leaving the seekhead in the wrong place. > > We can still do this, but we need to take care to compare timestamps > in the same time base. > > Signed-off-by: Derek Buitenhuis > --- > libavformat/mov.c | 40 +++++++++++++++++++++------------------- > 1 file changed, 21 insertions(+), 19 deletions(-) Will push in a day or so if there are no objections. - Derek _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".