From: Gyan Doshi <ffmpeg@gyani.pro>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [RFC] [PATCH] avfilter/avfilter: add flag to signal filters that support w/h change
Date: Sat, 17 Jun 2023 14:12:40 +0530
Message-ID: <1552cccc-b070-b025-fafa-6efc86222f7e@gyani.pro> (raw)
In-Reply-To: <CAPYw7P4iYBXBhP_eNheVqiOrD12dtKVu4VNYe-HWpCp1g2LFNA@mail.gmail.com>
On 2023-06-17 01:58 pm, Paul B Mahol wrote:
> On Sat, Jun 17, 2023 at 10:27 AM Anton Khirnov <anton@khirnov.net> wrote:
>
>> Quoting Paul B Mahol (2023-06-17 08:52:33)
>>> On Wed, Jun 14, 2023 at 7:33 PM Nicolas George <george@nsup.org> wrote:
>>>
>>>> Paul B Mahol (12023-06-14):
>>>>> To flag filters that can work with variable frame size changes
>>>>> all the time in graph. So no rescalers are need to be inserted or
>>>>> filtergraph reset.
>>>>>
>>>>> Once all such filters are flaged with such capability then code will
>> be
>>>>> added so auto inserted rescale filter is inserted where neccesarry to
>>>>> filters in
>>>>> filtergraph that do not support dynamic width/height changes.
>>>> If you have a proof-of-concept patch series where this flag is actually
>>>> useful, I will review it.
>>>>
>>>> As it is, it is dead code and not for commit.
>>>>
>>> More code will come later, no reasons to block this patch for no valid
>>> reasons.
>> I agree with Nicolas, we should not add flags that are not used for
>> anything.
>>
> Does not really matter who agrees to whom.
>
> Patch goes in.
At least patch some of the applicable filters and you could use the flag
in buffersrc param check.
Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-06-17 8:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 14:47 Paul B Mahol
2023-06-14 16:44 ` Paul B Mahol
2023-06-14 17:05 ` Nicolas George
2023-06-14 17:31 ` Paul B Mahol
2023-06-14 17:33 ` Nicolas George
2023-06-17 6:52 ` Paul B Mahol
2023-06-17 8:27 ` Anton Khirnov
2023-06-17 8:28 ` Paul B Mahol
2023-06-17 8:42 ` Gyan Doshi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1552cccc-b070-b025-fafa-6efc86222f7e@gyani.pro \
--to=ffmpeg@gyani.pro \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git