From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 26BB54B660 for ; Mon, 10 Jun 2024 19:38:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3C3CC68D76C; Mon, 10 Jun 2024 22:38:33 +0300 (EEST) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BA06B68D6B4 for ; Mon, 10 Jun 2024 22:38:26 +0300 (EEST) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1f6f031549bso2399165ad.3 for ; Mon, 10 Jun 2024 12:38:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718048304; x=1718653104; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=OzEhSIbySwsCWjz9/uCbV/Zj9a2/EKCk8XX7SatCP4Y=; b=RlvR79RIYKhoPr41Qq25hj0n9j4otJDZzzatOQWR5PAOn8wpXUlnyzyDf5fWiJiF+S uJiNE5qRPfZZ6lH7EyjaIx3ESmZTfBwJCSq8Y0R3eTnqPA/jvOf18pMYq5uBB6ImJO7l XWGS/PLpz4T/g+wX8hynu1bc1bTxhoU8A/Rc5dXM1pfnHE6feZ4YSQSvtJYzxu8PTZv7 gxC0m0hSJPbJFNlahI4T0fyeQq01TtslEV+tdFRdyG8KWH/26ZqMz+mToKlWMsxCGDWm hoQ11DtiAwj/Gf8iPv5p3bCFNoYR9crpShXJn+t/vN1KKbYC3OLlL0yVIN0o7+t9QGq8 uDOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718048304; x=1718653104; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OzEhSIbySwsCWjz9/uCbV/Zj9a2/EKCk8XX7SatCP4Y=; b=LXXKAG7vlnPU41F1ozv0sGA4QF6arbdVa1SGCbzi7n7f4IVh3kAXE245TqkKg3bv4T uiCAQzgfbhJeoV/r5TK9c0ccz1y/ROTspLhstZrkMMZkvk2qppbMz5CtQoQQlzd9wECN pjnQuF0fYi9NkMd7GG7ut4PZ089HvhtmAb641e26HbVgBj5Xs683aIo2XoFeYHXdQ35Y xQGrAiloUItUNyn/lzUg738gMc2XATsq9qMEp7oktOtER00a768ptYhjAmN6dDZ0V/NN CV5UvJb85UsAl5PCulbEtf4POoGY3r13cIGjd1b/IvWLw+LfbqDMj3btakYuwfz9DSE+ pepQ== X-Gm-Message-State: AOJu0YxUuNYsEqr7qYvevLBa0vIj64fnhCTbbDqnk9yZqhG7MNV2biyh ujtfAoblMpTddvtP5ktxu8VkgdFx1PiHm+8Y2PBqasTtOy1KmGWO91YuLw== X-Google-Smtp-Source: AGHT+IEpsyJLKSnrGSwwWAXQJeYB8JjxVXiuz2TFTSlDn7BsARp4CXfpcnFOUgzvv+ABO3xxjgn5DQ== X-Received: by 2002:a17:902:da8e:b0:1f7:1bf3:db11 with SMTP id d9443c01a7336-1f71bf3dd6amr24454985ad.24.1718048303191; Mon, 10 Jun 2024 12:38:23 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f6bd7f7ec1sm87784515ad.271.2024.06.10.12.38.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jun 2024 12:38:22 -0700 (PDT) Message-ID: <15365cbb-22fe-4bde-ae2b-13bf2e8b0411@gmail.com> Date: Mon, 10 Jun 2024 16:38:43 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240610184408.68171-1-derek.buitenhuis@gmail.com> <20240610184408.68171-5-derek.buitenhuis@gmail.com> Content-Language: en-US From: James Almer In-Reply-To: <20240610184408.68171-5-derek.buitenhuis@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH 4/5] avformat/mov: Add support for exporting Video Extension Usage info X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/10/2024 3:44 PM, Derek Buitenhuis wrote: > +static int mov_read_vexu(MOVContext *c, AVIOContext *pb, MOVAtom atom) > +{ > + int size; > + int64_t remaining; > + uint32_t tag; > + > + if (c->fc->nb_streams < 1) > + return 0; > + > + if (atom.size < 8) { > + av_log(c->fc, AV_LOG_ERROR, "Empty video extension usage box\n"); > + return AVERROR_INVALIDDATA; > + } > + > + remaining = atom.size; > + while (remaining > 0) { Maybe this loop should call mov_read_default, with proj and eyes added to mov_default_parse_table[]. Although i don't know if eyes may show up as child for other parent boxes or not. At least with proj, i see it can be a child for sv3d, where only prhd is expected as a child box in turn. But it shouldn't a problem to add a mov_read_proj that handles both prhd and prji for this purpose. > + size = avio_rb32(pb); > + if (size < 8 || size > remaining ) { > + av_log(c->fc, AV_LOG_ERROR, "Invalid child size in vexu box\n"); > + return AVERROR_INVALIDDATA; > + } > + > + tag = avio_rl32(pb); > + switch (tag) { > + case MKTAG('p','r','o','j'): { > + MOVAtom proj = { tag, size - 8 }; > + int ret = mov_read_vexu_proj(c, pb, proj); > + if (ret < 0) > + return ret; > + break; > + } > + case MKTAG('e','y','e','s'): { > + MOVAtom eyes = { tag, size - 8 }; > + int ret = mov_read_eyes(c, pb, eyes); > + if (ret < 0) > + return ret; > + break; > + } > + default: > + av_log(c->fc, AV_LOG_WARNING, "Unknown tag in vexu: 0x%08X\n", tag); > + avio_skip(pb, size - 8); > + break; > + } > + remaining -= size; > + } > + > + if (remaining != 0) { > + av_log(c->fc, AV_LOG_ERROR, "Broken vexu box\n"); > + return AVERROR_INVALIDDATA; > + } > + > + return 0; > +} _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".