From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 87D86420BC for ; Tue, 22 Feb 2022 11:30:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 29FC268A67E; Tue, 22 Feb 2022 13:30:42 +0200 (EET) Received: from shout01.mail.de (shout01.mail.de [62.201.172.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 054BB689FD9 for ; Tue, 22 Feb 2022 13:30:35 +0200 (EET) Received: from postfix01.mail.de (postfix02.bt.mail.de [10.0.121.126]) by shout01.mail.de (Postfix) with ESMTP id 7978CA1CDF for ; Tue, 22 Feb 2022 12:30:35 +0100 (CET) Received: from smtp02.mail.de (smtp02.bt.mail.de [10.0.121.212]) by postfix01.mail.de (Postfix) with ESMTP id 60B1FA03C3 for ; Tue, 22 Feb 2022 12:30:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mail.de; s=mailde202009; t=1645529435; bh=W+/bj8Fi6R+W/A2Oir7ddfzkL2Hl83zXTf9VTMusMxQ=; h=Message-ID:Date:Subject:To:From:From:To:CC:Subject:Reply-To; b=oePnZhR2efl1zrLgNYnq2V54lGFLHa2qKqJEwpnS0A26ZH2o+aK5Ji9KWjkb9Ppnd QoDEIGzQu2eBLvQaCArg84Lwmaebj5zv6QxIqHkEuQLtOJ82BpiECwiD59A2L9CJLR xITIkfgY6RAonELm7fARM5tbJQVr4joKirw1/iGcy3DXTdVovbrcTvTawJOa1eb3Ae zSGmpJ5QoFtVUTFWqN6cGEqVaRmEKhWmJ4gA8WYvgKjAwRvXd3xFbrrUA8EKMuZXrC u+LknxnNbtsCp8mqViw7qKy3vJYk65t0LLJ5WIqCqeZPMCDJKlvkPt0C2UbjRHw14M b7AO7KvDI4eZQ== Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtp02.mail.de (Postfix) with ESMTPSA id 2F4EEA02F1 for ; Tue, 22 Feb 2022 12:30:35 +0100 (CET) Message-ID: <14fa7592-4acc-2186-335b-56ea500f9663@mail.de> Date: Tue, 22 Feb 2022 12:30:34 +0100 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20210115045832.76405-1-borbarak@fb.com> <3fa8e9b2-6824-eb3a-2390-22fd024efa9f@mail.de> <164363001951.23111.4989616914372511566@lain.red.khirnov.net> From: Thilo Borgmann In-Reply-To: X-purgate: clean X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate: clean X-purgate-size: 1577 X-purgate-ID: 154282::1645529435-00002C8C-7D01BD31/0/0 Subject: Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Am 18.02.22 um 17:08 schrieb Paul B Mahol: > On Sat, Feb 12, 2022 at 11:55 AM Thilo Borgmann > wrote: > >> Am 31.01.22 um 12:55 schrieb James Almer: >>> >>> >>> On 1/31/2022 8:53 AM, Anton Khirnov wrote: >>>> Quoting Thilo Borgmann (2022-01-18 14:58:07) >>>>>>> Violations of code style. >>>>> >>>>> Enhanced. >>>> >>>> Not enough. There are still many remaining, e.g. >>>> * opening brace of a function definition should be on its own line >>>> * the context should generally be the first argument >>>> * unsigned char* should be uint8_t* >>>> * mixed declarations and code (the compiler should warn about that) >>> >>> I think someone said that clang (or some versions) is apparently not >> warning about this, hence why so many of these end up being missed in >> reviews or even by the patch author. >> >> This and all of Anton's comments in v3. Also removed some more obviously >> useless doubles. >> > > Why it uses doubles in so many places? > Is there any real benefit in that, except extra slowdown? I guess because it's originating in some c&p Matlab code. I did %s#double#float#g for v4, loosing some precision we can ignore IMHO. v3: Total frames: 2 Spatial Information: Average: 165.451985 Max: 165.817542 Min: 165.086427 Temporal Information: Average: 1.007263 Max: 2.014525 Min: 0.000000 v4: Total frames: 2 Spatial Information: Average: 164.385895 Max: 164.742325 Min: 164.029480 Temporal Information: Average: 1.007241 Max: 2.014483 Min: 0.000000 -Thilo _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".