From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3168449C3E for ; Tue, 5 Mar 2024 14:56:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 91ABF68D025; Tue, 5 Mar 2024 16:56:09 +0200 (EET) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 42A1B68C830 for ; Tue, 5 Mar 2024 16:56:03 +0200 (EET) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1dc09556599so54554655ad.1 for ; Tue, 05 Mar 2024 06:56:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709650561; x=1710255361; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mTQV3ni4jaWsIqVHKI9IYI2sIKCa9QeXVP1xibRRnII=; b=hayOXeiQL6nQbbEIr1cSgm7GBYqm1hf2O/GwovxALG/EfVRosze22Za1odqcMKGvey i9Si5W05fJIaVCQjp0XpIe5KEYiSURRct7g4qLuRqu3M9KwbZZo9grCvMTcTnOikRkhz 2aaCWtvHXB/8rsFc9xRh8VAf+f4kyeUZcOSr+6fOwd6EphGCWAhpektwNC61nK8SBfkM q6uPoty5PNqXgBG6CQjl0rSwLa0PSexkbHhhd9Etcv+AIhQnRI4qrjhXRVIPy4c05jQm mN1SwkvNDKM4HTF7+jJfAtV8Uxr0yvWNQrUeoLSmw+O5hnu9J0BKn+JmUhcsDl1HGkDe d7Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709650561; x=1710255361; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mTQV3ni4jaWsIqVHKI9IYI2sIKCa9QeXVP1xibRRnII=; b=VWuql4N2vvtbyq0gJ6tCChrGymtBDsayTA6UFGuMRFri+hC3DNpDagk8mJyc3jyf4O WX2nPCPa4Zl/U1OAQHyfhD+vycQ1Wy4TJPqJOAOnUjRtdFHWuHZSoij19LxFrbttN5vn /k3sAW6o5AfsIycuJobygCVcAeZXKJWa+BUdcyHGep48fj/s+G1jyfGqBijJMseE8A0N 9Adb3MuOlSgCnjhAICbK5e/CrKlOI10shC/LSH/sZd7VV9vAI2mwVkN05DUQUqmQ4+0j b5U+JGz1yMER42avnkgRemlv1LYX+CLM6gu8tnFXj57eZmT+rwLxniCcVFXMltyDa5es FWbA== X-Gm-Message-State: AOJu0Yw0qpjAq4wDTVqiIPMCjmcc/z8498HRASVxy0d0SP34IhhrENYA KqnPzhDpJUuwtT+0u5FbakHGKtV3u+BleJ0nXvAqf5ngriRcvpRllu/fCwFh X-Google-Smtp-Source: AGHT+IEzZhzuu2rzJGcg4075MQT1xP0Ich0d2hQRp/PbYW18MIa9ArJ1MPoE6P14KGQY3EjU7mYqZg== X-Received: by 2002:a17:903:11c3:b0:1dd:1a8:2ba7 with SMTP id q3-20020a17090311c300b001dd01a82ba7mr2698806plh.35.1709650561032; Tue, 05 Mar 2024 06:56:01 -0800 (PST) Received: from [192.168.0.14] ([190.194.169.124]) by smtp.gmail.com with ESMTPSA id y5-20020a170902ed4500b001dbb06b6133sm10643733plb.127.2024.03.05.06.55.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Mar 2024 06:56:00 -0800 (PST) Message-ID: <14d55e72-8e46-4b72-8edf-de4cbe7b93da@gmail.com> Date: Tue, 5 Mar 2024 11:56:12 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240305000033.10379-1-jamrial@gmail.com> <20240305000033.10379-2-jamrial@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 2/9] avformat/avformat: add a function to return the name of stream groups X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/5/2024 11:52 AM, Stefano Sabatini wrote: > On date Tuesday 2024-03-05 15:50:23 +0100, Stefano Sabatini wrote: >> On date Monday 2024-03-04 21:00:22 -0300, James Almer wrote: >>> Signed-off-by: James Almer >>> --- >>> Missing version bump and APIChanges entry. >>> >>> libavformat/avformat.c | 10 ++++++++++ >>> libavformat/avformat.h | 5 +++++ >>> 2 files changed, 15 insertions(+) >>> >>> diff --git a/libavformat/avformat.c b/libavformat/avformat.c >>> index eb898223d2..98dfac2f89 100644 >>> --- a/libavformat/avformat.c >>> +++ b/libavformat/avformat.c >>> @@ -321,6 +321,16 @@ AVStream *ff_stream_clone(AVFormatContext *dst_ctx, const AVStream *src) >>> return st; >>> } >>> >>> +const char *avformat_stream_group_name(enum AVStreamGroupParamsType type) >>> +{ >>> + switch(type) { >>> + case AV_STREAM_GROUP_PARAMS_IAMF_AUDIO_ELEMENT: return "IAMF Audio Element"; >>> + case AV_STREAM_GROUP_PARAMS_IAMF_MIX_PRESENTATION: return "IAMF Mix Presentation"; >>> + case AV_STREAM_GROUP_PARAMS_TILE_GRID: return "Tile Grid"; >>> + } >>> + return NULL; >>> +} >>> + >>> AVProgram *av_new_program(AVFormatContext *ac, int id) >>> { >>> AVProgram *program = NULL; >>> diff --git a/libavformat/avformat.h b/libavformat/avformat.h >>> index f4506f4cf1..c41041b1bc 100644 >>> --- a/libavformat/avformat.h >>> +++ b/libavformat/avformat.h >>> @@ -2120,6 +2120,11 @@ const AVClass *av_stream_get_class(void); >>> */ >>> const AVClass *av_stream_group_get_class(void); >>> > >>> +/** >>> + * @return a string identifying the stream group type >>> + */ > > Also add a note that this will return NULL in case of unknown stream > group type. > >>> +const char *avformat_stream_group_name(enum AVStreamGroupParamsType type); >>> + >> >> LGTM (remember to bump minor and add entry to doc/APIchanges before >> pushing). Applied with the suggestion. Thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".