From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3BC0F456D7 for ; Sat, 18 Feb 2023 13:58:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 521BF68BE47; Sat, 18 Feb 2023 15:58:34 +0200 (EET) Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0666C68BE0A for ; Sat, 18 Feb 2023 15:58:27 +0200 (EET) Received: by mail-ot1-f48.google.com with SMTP id l10-20020a0568302b0a00b00690ee4a5febso190499otv.0 for ; Sat, 18 Feb 2023 05:58:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ocbO9mpsjN/VyK5yAW8MJWeNynvqkQUHO94YbSkbrVQ=; b=pTbYmBuAU2z7/y4P85F+v2oR5xD/OMHTMRGkVlR/eWIY7rR4Sc6rmVCmgcPUNScjbI Ny5SS079nl2Z8PYt2WffY//wdbWFTN4iQ3hPS/+/jzO/Kn/IYcWXy5jShFBiE95wGnlI KpRTe/HKDvpBbYOqEcwukI9KWcX3bwdLr92jLYLMgHpKaW9yybsyYWCINxdJtMvYq6Se 3MPvGy/+m2bYubTWOROK6H3/pUJG2yFDvffXpzvbKP/wqTzEiQqnMc7CpDFr729Pwu/6 SM8vCf4dYx0p4quArnXN763YJFIT36JKJONNevaIyj7SOMaLCwPz0E4nBE0VMnzmdF0H QH5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ocbO9mpsjN/VyK5yAW8MJWeNynvqkQUHO94YbSkbrVQ=; b=OaDHWB5hf06f/njcQnnhqghBYhNvoT2nRfVR3T/vV65xhf4ZVI+8OPQQSmHBrTe56W 8xpwm6sXlxF0mopaDvy4SXPR8r2IY0E76zz1CW15bjAXz4pUYI5O1SBTCbguqHix+eAQ /rz5ci1Wry1UOirHr6hqIZXbQP0oGTs7655Dr6lwlwgt3j3XtNcmy1XRWX2M1AbGypb3 CPZFPNQvOk3GjVc7rBsQGMH+i3d6hQJ+zn0dtTfdHw27009pmVmIGF3MuCVdY/CTxetT A5vJ5M9GfgxE+aaRmhqMwa+hEGowmOWYLsdCE1hlUQifaUe4kp0ipDyVaFl3FnVKK4gY QoMg== X-Gm-Message-State: AO0yUKUnmVhuc5i8qaUUFwVMzb1pClY5bNYA1nsw2JrlcK3obexNtDGw 5kTT3xGB0P+AxL8VMbC7yX5Vfxnu7/c= X-Google-Smtp-Source: AK7set+AwKZ4Ei+w/eC9qP11mRMGURKwAEoad1a+UbDPKS93+CYBoXLqAAcUvyLfSZWyrwIEKjadEw== X-Received: by 2002:a05:6830:920:b0:68d:50ac:b261 with SMTP id v32-20020a056830092000b0068d50acb261mr2385787ott.1.1676728703725; Sat, 18 Feb 2023 05:58:23 -0800 (PST) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id w2-20020a056830144200b0068bcf7995aesm3025201otp.64.2023.02.18.05.58.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Feb 2023 05:58:23 -0800 (PST) Message-ID: <14d18141-4e19-7c28-427f-a7d12cc2486b@gmail.com> Date: Sat, 18 Feb 2023 10:58:46 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <66307ef3-b214-47f6-6d4e-fbcc439f2004@gmail.com> <077fbbad-3629-c057-1d5d-d59fece7eed9@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] lavc: deprecate avcodec_dct, av_fft, av_dct, av_rdft and av_mdct X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/18/2023 10:45 AM, Lynne wrote: > Feb 18, 2023, 14:32 by jamrial@gmail.com: > >> On 2/18/2023 9:49 AM, Lynne wrote: >> >>> Feb 17, 2023, 19:45 by dev@lynne.ee: >>> >>>> Feb 17, 2023, 18:08 by jamrial@gmail.com: >>>> >>>>> On 2/17/2023 1:54 PM, Lynne wrote: >>>>> >>>>>> This reverts commit 26cb36f35746fe6ef53688b119852bfa6d555f62. >>>>>> >>>>>> All filters and all codecs (except wmavoice) have been ported for the >>>>>> lavu/tx API. >>>>>> >>>>>> The noise should be minimal. >>>>>> >>>>> >>>>> It isn't. I'm getting more than two thousand lines of warnings after applying this patch from >>>>> >>>>> libavfilter/vf_spp.c >>>>> libavfilter/x86/vf_spp.c >>>>> libavcodec/asvenc.c >>>>> libavcodec/avdct.c >>>>> libavcodec/avfft.c >>>>> libavcodec/dct.c >>>>> libavcodec/fdctdsp.c >>>>> libavcodec/fft_float.c >>>>> libavcodec/fft_init_table.c >>>>> libavcodec/idctdsp.c >>>>> libavcodec/jfdctfst.c >>>>> libavcodec/jfdctint.c >>>>> libavcodec/jrevdct.c >>>>> libavcodec/mpegaudiodsp.c >>>>> libavcodec/mpegvideo_enc.c >>>>> libavcodec/rdft.c >>>>> libavcodec/wmavoice.c >>>>> libavcodec/x86/dct_init.c >>>>> libavcodec/x86/fft_init.c >>>>> libavcodec/x86/mpegvideoenc.c >>>>> >>>>> It's not just wmavoice, there's also mpeg and jpeg stuff, and one filter. For the actual fft/dct/rdft/mdct source files, you should use the deprecation warning pragmas to silence them, but the other modules need to be ported. >>>>> This patch is also missing the schedule FF_API deprecation wrapper. >>>>> >>>> >>>> Is the noise acceptable if I just deprecate the functions? >>>> It wasn't before, but it should be much less now. >>>> >>> >>> Version 2 attached. >>> Deprecates only the init functions (which must always be used, therefore >>> the entire API is deprecated). >>> >> >> You should deprecate all the functions, not just the init ones, even if the rest depend on them. And add a "@deprecated use AVTXContext from libavutil/tx.h" line or similar in the doxy for at least the init or alloc functions to point library users to the replacement API. >> > > Fair enough, deprecated all functions, added disable/enable warnings to tests > and vf_spp, and added the doxy note. > Attached v3. vf_spp should be ported to tx, not the avdct functions silenced. You're just scheduling a compilation failure as is. What is the plan for the internal version of all this lavc code? Is it going to be removed and wmavoice/mpegaudiodsp/etc ported to tx? Because it depends on structs defined in the public headers you're scheduling to be removed. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".