From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 43911403E9 for ; Mon, 24 Jan 2022 02:13:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DF9C168B007; Mon, 24 Jan 2022 04:13:21 +0200 (EET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 241B468AEBC for ; Mon, 24 Jan 2022 04:13:14 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642990400; x=1674526400; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=Gd/gk8vgBN0auMSDcwdobAZVIqQTDJhrg+f7vq8f4hA=; b=jSi1B4zLMqpgwDuCnBN9RLO9/7YQSqBXzlayT2HVvq7LXMtNk5urw9dg LLbQNeDJg0+r2Wcx37QCRQAtDxbL5PWw5oItggJsJQRGTvJgqOFJ/wwja Ihh15cVAHq/ZRmEYrpZwYv96bqM0pEo9Cssk3OApeYTENGXYDf0us0Hjf 09EMp8sBbLJvv8wmlVuw0z9bmguLV2nhQuBLb7W5AZgVKxAuCERnvpmZl 37+syHBAQuK5b1BubGkZhOPONzsaLJpIYTwaR+5FUJsvGni3hmaNCyFZz T1K+c3jm+BHTq2lic4IZHSxjqyzPCkGc7HD3vdY7MgZQuu2ASAF/ZpZzQ g==; X-IronPort-AV: E=McAfee;i="6200,9189,10236"; a="243540234" X-IronPort-AV: E=Sophos;i="5.88,311,1635231600"; d="scan'208";a="243540234" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2022 18:13:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,311,1635231600"; d="scan'208";a="623922181" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga002.fm.intel.com with ESMTP; 23 Jan 2022 18:13:11 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 23 Jan 2022 18:13:11 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Sun, 23 Jan 2022 18:13:11 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Sun, 23 Jan 2022 18:13:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JwHfwXxHJpZ6YTgg8ZFphiqoHJ/AhOo1w4RzaqDevu9TdfqEyBwUOWpz07Vro6k/tVmIMtgtAVbdkJTcReqGw6ah8YJRoXRyJdWNDK/oHHjLUpSNzoxqQmcHROWb1L9hxC0dlJk4VTxnEOiMSoRHmsc9Flv0MYuWayTc5DyADNDSjKLgGvpm9LxbBvHtB+73hltA5LPCnjaS6vg+9W/xBBQYuA2dnuQpY1RWxGQ7Pg+C3gjklSA64Saty2hjIBuip4p+d03NR9RrUrA6oz9LT5bYWw3jkWO/JS9qHi/BRX5IYOz88109TLJkoYPn12laLmHqbG7g8Vjad/izeyMRZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gd/gk8vgBN0auMSDcwdobAZVIqQTDJhrg+f7vq8f4hA=; b=PmgKImzxpEwCxElY05/Upw5D6ZU8QoX2bqtDqXyy9hCOqTFwVAeWtf4YNjy37u6lIL6iXR1L3OQ9wEr9YWOsgMZCJk/r7o2+5zDfK82OiW6/FqfhPVld3jDplPaF/6NDo33dsbKxtobPx/pPdi0lC1n/4vJkUiKZnQd+ibJbxwD2sgSaWG128AQ4V0I/Vpgr84NpzZSqWLWPmzArY/J/0oPlvzMGQ3pEfwBVAjruXeAXL5Xi8uL8tTY/422ICEF/+hkL0CmAWuSbMlqjf04dMeY/ESXcQgk0sFE9JlgqQscIbM9I/1tnrimBm63DbD24hSQvJeU9T6AnpbiZpsm8hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BN6PR11MB1364.namprd11.prod.outlook.com (2603:10b6:404:48::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.13; Mon, 24 Jan 2022 02:13:09 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843%5]) with mapi id 15.20.4888.020; Mon, 24 Jan 2022 02:13:09 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v2] lavc/qsvenc: add tile encoding support for VP9 Thread-Index: AQHYCEDYbxvbrcgxykCDVV/OtIl66qxm6FKAgAAjO4CAAAX8AIAAFPqAgAFOIwCACQqzAA== Date: Mon, 24 Jan 2022 02:13:09 +0000 Message-ID: <14c1c8431c566fa76336dbc33d16a44daf7834fd.camel@intel.com> References: <20220113054525.14057-1-haihao.xiang@intel.com> <2de74c97e30007697825af8d68df3fdf5270350c.camel@intel.com> <1c674eab-97ba-b054-f12b-4bf6ad091cc9@gmail.com> <33176c6889d9e77298ceefcf7ab049edafff00d2.camel@intel.com> In-Reply-To: <33176c6889d9e77298ceefcf7ab049edafff00d2.camel@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c6827f99-61a9-4ed6-2266-08d9dedf112b x-ms-traffictypediagnostic: BN6PR11MB1364:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3631; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: beNiM2JvlNp35pN3vwQuDUYTOubL2QxKR4isBBr5vjqzwjbfCmcogGClnEIGqTG4w/x2qHfiWjuDJyWBDlavBli2KCpVN+v5qq9LxRL+bhCup+RSxd3eDbIbuO1a3cs8HD2rgkVwm/0kUzuxLnDyGDkNTGD7Sx4GfJae0Jw0ObK+d6InkGFBbARYVZvP65gvliLELCyawXfyrNyKPY2O4beyRxBkdhgDynSyB1pfukn5FQu7kjlWqrYctbkRa10dhe/6dXbJegkbq3favojHjWLeHUsntoPWoz5chgDl+LNWgUjfibrH5NCWcb03RYDx+HHvxi0XdxDwuKqFG05dgsJLC8PiWmGQa3CymWXFwTGT2TJbF+Y8wsIOQdmjZNbnRmFbQgOLAOsnbhfGwwqLKVg0ybI0jP4YV0slEsDNt10Pk78/dI2yC/5lqgFqFOIfIvDAhK6HR7UsnZiCwc8QSaMInScLZxqs4jYF7h/M3YOVC7bjOD4kB7xHfLOVCD4KO+LORIGH+KpBDA8pF3KWNdSEvePh4Z21xksMP3v9eGkubKDrnwIYSaVwnyx7lLaOi1dFO1c4lDpCWxfNN4iOoD4TPEe8C3B7z1CQH+/x0152tr2WvpC3bag3cWYyeSpU7YdzfFS1Kfk/5hKivYjjsnqr9jYXxhrGCfOunVHE3+s61E9FZPmY0dskAQmXVBQ0/1bt7MBQ2q1JroqC37viA+LC9iqPayW5PkdcJaI9/NfzZ1lJrBFlzr+vrKbfPD3Ga05RfHRSzQ2t3TmL/VnNmCxvUzh/RVlpp56A5lrG507koIfpWtFSvjmhvls3uhHj x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6512007)(8676002)(36756003)(26005)(2616005)(5660300002)(2906002)(6506007)(8936002)(316002)(6486002)(71200400001)(508600001)(186003)(53546011)(966005)(91956017)(76116006)(66446008)(64756008)(66946007)(66476007)(66556008)(6916009)(82960400001)(122000001)(86362001)(83380400001)(38100700002)(38070700005)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MUNndDY5S1VWdE9vVU9uMWlJaXE3U3R0MUo3MUNUWCtJY0R3R0xqQnU3L2NI?= =?utf-8?B?RnJtaGRLaUlNREhMY0Y4a29FczJGNnVUWnQ0VjRiSnl2Q2FiTEVHYUZ5ZHdD?= =?utf-8?B?QjJnWEhrWnFPOGxUenZBUUk0QnNjb3VtY1V4cktRODJDV1ZNbXB5YmYycGxl?= =?utf-8?B?bXczUktZOVFyTW56b2dVOXhPYmNVcHVnQm5RRm1oUVptMy9qSWt1RHBFRUJw?= =?utf-8?B?SEJ0MEJkWjRpUTRDcXhtRjlxekZjeG9KVTVwZFBvQms4REEwbHJvRXF2a3cy?= =?utf-8?B?OVdLbUpSMEliZVN0VENzbUFBMzg0ai94eXJEY0U1RnJNS1VQWFNHaVRoRXVu?= =?utf-8?B?VVZ4c2pNZ3lkT0FiN1hNWUdxdzdEY01WL2NCd1RnNlBQVDNFTkw3YXF2cWtH?= =?utf-8?B?M1VPQnpweGM4UXZDcWwrYWx5WTQ1TEp6WFNDTVVjV2xsZmczdXY1a0VqcnFw?= =?utf-8?B?aEFjWmhyNkJzcTVmRzFTTklWRDV4VlRNOUorN2luVGVudTdnM0F3TlBnVmRZ?= =?utf-8?B?TElYMVZVek9NckhwMGtlYlIvbExLRW1CQWlLc21yblpWY3BXR29XdnRUSGZY?= =?utf-8?B?bE1PTisrVXZaSXBwc29zOXd3M1ZDOGVzb1IzSkY3TlRpZXREZXdOZ2N2SXE4?= =?utf-8?B?WHBBNi9lL0pjcXl4K0d1LzYyYm42Ly8rQ2lqZ2FEY1J1VGVKbGtOYnowMG0w?= =?utf-8?B?ZExGKzlZbXFsU0NZeWVsMGdoNEV4bFcwcjJaYU41WE9mdnZLVy9rQW9qM3gw?= =?utf-8?B?RDIwTW5RR29pNDVHY1RUSlg4cmVaQVRyRnROUTI2SkRUK09DcVJYV0VQU2xz?= =?utf-8?B?QjJ1T2M3MklWZ1hDZUUwK0pHN0JXTVllcDZhWitWRkR6K3V5WDNhWVByelNB?= =?utf-8?B?TjAramN0SjMwaGZ3WE9YTklmZ1hWMVVkU0NTRTJhSXBHdHptRGVBcHB1QzdZ?= =?utf-8?B?YW5iT0tnSTZpVS9RMzJ5WjJEdUlrdXBOeXBKdWdZOWFKRnhwOFhKUzI2SDNO?= =?utf-8?B?L3hhMHRya1kxUTNhVTJyMzFvVnVFUmRtbzdBT2lNL1FuUlhuSEhWR1ZveVNx?= =?utf-8?B?bVRFek9CMk9PQm5DekdMYkFBME1nQTBoWTNwU1B6VzRtU0UxYXVhWWw5VWxR?= =?utf-8?B?a015aUlQaFh1aTBRaVhrSHhQUldPN3NCY1g2eklaMmVHc2hIUGFnWTVYaVh0?= =?utf-8?B?Y1NlNGcvMUpuZ0p6cGNIYVR4RzNlaXMzMUU4SXJ1cDFMSE1HdlYzTW8rOUUr?= =?utf-8?B?ZDgxQ1VSRWQ1ZjkvWFYwckRoOVlQUWxvc0taQzhmZ1NXRkcwdW1qWC9LME1Y?= =?utf-8?B?L1VXbElub3o0K1gvZVdZVUhIT0ozU3dBUHFZRU50ZDFjV0hhWjFZQ3RuZkRx?= =?utf-8?B?ekZEcWxBd2l2QTJjejBUeVVwQ1NCUzZDMDh2d3FvYXhXYm1DdEJXMHdyelFR?= =?utf-8?B?YXFpSHdTSHpOdmRFbW9SeFJ6YWNMUXNOQlpYT0MrMFpiOVZsai9LL1RNYlRK?= =?utf-8?B?QmxZR0J2Rk1YalFWRWJCUC94cFNIMjhOVWNNdm40MHZuZVlYZEcveEp6b0Ny?= =?utf-8?B?SWswdndYNlRITzFhYXJseE9PeDFpSW5jM3lKUWhoRVQ4UzladlZoMi9VR3Q1?= =?utf-8?B?aEd6YktUL010QWE4N0ZzU0ptbDV0djhMeWhVMVpZbURyREFROUc0Q0dmTEkv?= =?utf-8?B?OGFONWFvNWx0dFNMaXhtbGdiME1OMEhreUdFZWVNRzFHZlJwMWQraFBmcDNP?= =?utf-8?B?UWtkRGR4aHJiU2tETVdqREdTZDhDcHlVczRwMFJlUlUvZlQ1aUMvOWUyT0tW?= =?utf-8?B?Vjc0ZlhlQ2RSRk1aVFgrdVN3NFNPK2Q5VnVjZllVTlF1dWg4UGs1eW9MRENV?= =?utf-8?B?SHdrMDhkK28vb2RlZGsrUitvdkN5TlI4WnQ5WDhXSHlrcHFESFhzenRJVmNi?= =?utf-8?B?RHR0T25semx3TGkvaUcwK2tQQzh2eHJzbTBPMHNST3grd1JiQXBXaTBaUXlp?= =?utf-8?B?VnE5MUpGT01HSmM3OTNCL05DNkNoMGMwM3Z6SGllUGFiaFlTTkE3RHB6QWFn?= =?utf-8?B?TlFlaWZIR3BGSnhkZUtqNEVXa3J0K2U2bHovNjU4VmhzQTU5WjhKNmY2MzNn?= =?utf-8?B?alZWQ0ZkR2g2RnpEY09hVVlUeERYODdubzcwWjNSZm9Cb1ZOdURiMWJOVVVX?= =?utf-8?Q?XdG5WILB9n/K145k2qLH89c=3D?= Content-ID: <5B0946B642039544A33B069D3B7046BB@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6827f99-61a9-4ed6-2266-08d9dedf112b X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2022 02:13:09.6436 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GxLrXsBz2Ir/ByOO4SivJRpkM6YN8uk06uv5WW2ybbd8eaKXfA4g7Gz2du7UwsnYxAZschS6OEtRpjPxpy6G3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1364 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2] lavc/qsvenc: add tile encoding support for VP9 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 2022-01-18 at 08:08 +0000, Xiang, Haihao wrote: > On Mon, 2022-01-17 at 09:12 -0300, James Almer wrote: > > On 1/17/2022 7:57 AM, Soft Works wrote: > > > > > > > > > > -----Original Message----- > > > > From: ffmpeg-devel On Behalf Of > > > > mypopy@gmail.com > > > > Sent: Monday, January 17, 2022 11:36 AM > > > > To: FFmpeg development discussions and patches > > > > Subject: Re: [FFmpeg-devel] [PATCH v2] lavc/qsvenc: add tile encoding > > > > support > > > > for VP9 > > > > > > > > On Mon, Jan 17, 2022 at 4:30 PM Xiang, Haihao > > > > wrote: > > > > > > > > > > On Thu, 2022-01-13 at 13:45 +0800, Haihao Xiang wrote: > > > > > > Add -tile_rows and -tile_cols options to specify the number of tile > > > > > > rows and columns > > > > > > > > > > > > Signed-off-by: Haihao Xiang > > > > > > --- > > > > > > v2: add option descriptions in the doc > > > > > > > > > > > > doc/encoders.texi | 6 ++++++ > > > > > > libavcodec/qsvenc.c | 4 ++++ > > > > > > libavcodec/qsvenc.h | 1 + > > > > > > libavcodec/qsvenc_vp9.c | 10 ++++++++++ > > > > > > 4 files changed, 21 insertions(+) > > > > > > > > > > > > diff --git a/doc/encoders.texi b/doc/encoders.texi > > > > > > index 7cc8be1209..a4176089d5 100644 > > > > > > --- a/doc/encoders.texi > > > > > > +++ b/doc/encoders.texi > > > > > > @@ -3457,6 +3457,12 @@ These options are used by vp9_qsv > > > > > > @item profile2 > > > > > > @item profile3 > > > > > > @end table > > > > > > + > > > > > > +@item @var{tile_cols} > > > > > > +Number of columns for tiled encoding (requires libmfx >= 1.29). > > > > > > + > > > > > > +@item @var{tile_rows} > > > > > > +Number of rows for tiled encoding (requires libmfx >= 1.29). > > > > > > @end table > > > > > > > > > > > > @section snow > > > > > > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > > > > > > index 4e7a15f060..4cbc9ff4dc 100644 > > > > > > --- a/libavcodec/qsvenc.c > > > > > > +++ b/libavcodec/qsvenc.c > > > > > > @@ -939,6 +939,10 @@ static int init_video_param(AVCodecContext > > > > > > *avctx, > > > > > > QSVEncContext *q) > > > > > > q->extvp9param.Header.BufferId = MFX_EXTBUFF_VP9_PARAM; > > > > > > q->extvp9param.Header.BufferSz = sizeof(q->extvp9param); > > > > > > q->extvp9param.WriteIVFHeaders = MFX_CODINGOPTION_OFF; > > > > > > +#if QSV_HAVE_EXT_VP9_TILES > > > > > > + q->extvp9param.NumTileColumns = q->tile_cols; > > > > > > + q->extvp9param.NumTileRows = q->tile_rows; > > > > > > +#endif > > > > > > q->extparam_internal[q->nb_extparam_internal++] = > > > > > > (mfxExtBuffer > > > > > > > > *)&q- > > > > > > > extvp9param; > > > > > > > > > > > > } > > > > > > #endif > > > > > > diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h > > > > > > index 31516b8e55..00ee52a5d1 100644 > > > > > > --- a/libavcodec/qsvenc.h > > > > > > +++ b/libavcodec/qsvenc.h > > > > > > @@ -41,6 +41,7 @@ > > > > > > > > > > > > #define QSV_HAVE_EXT_HEVC_TILES QSV_VERSION_ATLEAST(1, 13) > > > > > > #define QSV_HAVE_EXT_VP9_PARAM QSV_VERSION_ATLEAST(1, 26) > > > > > > +#define QSV_HAVE_EXT_VP9_TILES QSV_VERSION_ATLEAST(1, 29) > > > > > > > > > > > > #define QSV_HAVE_TRELLIS QSV_VERSION_ATLEAST(1, 8) > > > > > > #define QSV_HAVE_MAX_SLICE_SIZE QSV_VERSION_ATLEAST(1, 9) > > > > > > diff --git a/libavcodec/qsvenc_vp9.c b/libavcodec/qsvenc_vp9.c > > > > > > index 9329990d11..1168ddda0e 100644 > > > > > > --- a/libavcodec/qsvenc_vp9.c > > > > > > +++ b/libavcodec/qsvenc_vp9.c > > > > > > @@ -73,6 +73,16 @@ static const AVOption options[] = { > > > > > > { "profile2", NULL, 0, AV_OPT_TYPE_CONST, { > > > > > > .i64 > > > > > > > > = > > > > > > MFX_PROFILE_VP9_2 }, INT_MIN, INT_MAX, VE, "profile" }, > > > > > > { "profile3", NULL, 0, AV_OPT_TYPE_CONST, { > > > > > > .i64 > > > > > > > > = > > > > > > MFX_PROFILE_VP9_3 }, INT_MIN, INT_MAX, VE, "profile" }, > > > > > > > > > > > > +#if QSV_HAVE_EXT_VP9_TILES > > > > > > + /* The minimum tile width in luma pixels is 256, set maximum > > > > > > > > tile_cols to > > > > > > 32 for 8K video */ > > > > > > + { "tile_cols", "Number of columns for tiled > > > > > > encoding", OFFSET(qsv.tile_cols), AV_OPT_TYPE_INT, { .i64 = 0 > > > > > > }, > > > > > > 0, > > > > > > > > 32, > > > > > > VE }, > > > > > > + /* Set maximum tile_rows to 4 per VP9 spec */ > > > > > > + { "tile_rows", "Number of rows for tiled > > > > > > encoding", OFFSET(qsv.tile_rows), AV_OPT_TYPE_INT, { .i64 = > > > > > > 0 > > > > > > }, > > > > > > > > 0, 4, > > > > > > VE }, > > > > > > +#else > > > > > > + { "tile_cols", "(not > > > > > > supported)", OFFSET(qsv.tile_cols), > > > > > > > > AV_OPT_TYPE_INT, > > > > > > { .i64 = 0 }, 0, 0, VE }, > > > > > > + { "tile_rows", "(not > > > > > > supported)", OFFSET(qsv.tile_rows), > > > > > > > > AV_OPT_TYPE_INT, > > > > > > { .i64 = 0 }, 0, 0, VE }, > > > > > > +#endif > > > > > > + > > > > > > > > perfer one option like "-tile rows x cols" than two options like > > > > > > The example is invalid. (spaces) > > > > > > > "-tile_rows row -tile_cols col" > > > > > > This way, the options are typed, have min, max and default values, > > > without needing any code to write and maintain. > > > > > > if you mean "-tile rowsxcols", there's no option type for this, > > > unless you would want to mis-use the video size type for it. > > > Otherwise you'd need to make it string and write all the parsing > > > and checking code for it. > > > > We already have code for this. see libaomenc. > > Thanks for the comments. There are -tile_rows and -tile_cols options for > hevc_qsv encoder, I'd like to keep the style consistent in qsv encoders and > prefer to add the two options for vp9 encoder too. > Any other concern ? Thanks Haihao > > > > > > > Do you think that it would be worth the effort? > > > > > > Also, in most use cases, you will probably have rows or cols, > > > rather than both.. > > > > > > sw > > > > > > > > > _______________________________________________ > > > ffmpeg-devel mailing list > > > ffmpeg-devel@ffmpeg.org > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > > > To unsubscribe, visit link above, or email > > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".