From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 17FC6426FE for ; Thu, 6 Jan 2022 11:27:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6B03268AA6A; Thu, 6 Jan 2022 13:27:12 +0200 (EET) Received: from shout01.mail.de (shout01.mail.de [62.201.172.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A520168052C for ; Thu, 6 Jan 2022 13:27:05 +0200 (EET) Received: from postfix01.mail.de (postfix01.bt.mail.de [10.0.121.125]) by shout01.mail.de (Postfix) with ESMTP id E93CDA1D33 for ; Thu, 6 Jan 2022 12:27:04 +0100 (CET) Received: from smtp01.mail.de (smtp01.bt.mail.de [10.0.121.211]) by postfix01.mail.de (Postfix) with ESMTP id CFE7A801CB for ; Thu, 6 Jan 2022 12:27:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mail.de; s=mailde202009; t=1641468424; bh=CvBhAp8Yxak5nVI557SHeYxRHPvvP/EkEkRyUwv3lJs=; h=Subject:To:References:From:Date:In-Reply-To:From; b=DM74rQ0ojJd1ichkXslyK7GSA5JvgqbA7C5lJhE0O8981/GaYy/aLmO0ZbiEQlbcS DualsURweH+2GSbPEeya1Y5G/kXkq0JCneZaxHC8I+GEEPAswnJ3l6MUfLtCVYqRlP dwmqBwlPoH+Q+TQLIrQSqquV4EkxbDIQ8gwssJ/5zP2xNg+e2SidNYDEOqijsQwPk5 vdFQocJIR/4vAQ+90x8ORRVRQ0I0m+mjyHY9CubtVLcCf2HSiNvGkP2x4sjfLeON7q Adye25xHb3HcwPzIQV9h1DeVAvYIM5GnlrNJtwufzncn9isYciVPIu74u3rD6ZWeWB hR39bEyp4NKWA== Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtp01.mail.de (Postfix) with ESMTPSA id 91BB61002CB for ; Thu, 6 Jan 2022 12:27:03 +0100 (CET) To: ffmpeg-devel@ffmpeg.org References: <280498BE-226E-41E2-BE17-DE2D47EAFFC0@mail.de> <0768FA6E-731F-4214-8B90-A3F38764010F@mail.de> <20211210164657.GF2829255@pb2> <727CF2F6-C834-415A-B771-4F70661F8BE8@mail.de> <3E808BD2-808B-4C53-B1F7-B9DFFE2BF687@mail.de> <72e9521f-b029-8637-c32c-27cf7c5de170@mail.de> From: Thilo Borgmann Message-ID: <14470aae-c127-7532-a054-b5d878d415dd@mail.de> Date: Thu, 6 Jan 2022 12:27:02 +0100 MIME-Version: 1.0 In-Reply-To: <72e9521f-b029-8637-c32c-27cf7c5de170@mail.de> Content-Type: multipart/mixed; boundary="------------8512ADDF647FFE9B0AC0A7D1" Content-Language: en-US X-purgate: clean X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate: clean X-purgate-size: 6062 X-purgate-ID: 154282::1641468424-00006BE6-5DB2CD91/0/0 Subject: Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: This is a multi-part message in MIME format. --------------8512ADDF647FFE9B0AC0A7D1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Am 03.01.22 um 16:22 schrieb Thilo Borgmann: > Am 29.12.21 um 12:46 schrieb Nicolas George: >> "zhilizhao(赵志立)" (12021-12-29): >>> How about add a restriction like this: >>> >>> if (format.endsWith(“%S")) >>> enable the feature >>> else >>> warning message >>> >>> It’s a useful feature, it shouldn't create unexpected results, but >>> doesn’t need to support every use case. >> >> I would not oppose it, but I find it inelegant, especially because it >> requires a different expansion function, localtime_ms instead of >> localtime. >> >> What about this: with the original function "localtime", if the format >> ends in "%3N", then append the millisecond. It can later be expanded to >> support %xN at any place in the format for any value of x. > > I think best will be to scan the format string for %S and extend it there with .ms part before expanding the rest of it, not? Shouldn't be too expensive for the filter. > > Just need to find time to actually implement it. Like v5 as attached. Thanks, Thilo --------------8512ADDF647FFE9B0AC0A7D1 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="v5-0001-lavfi-drawtext-Add-localtime_ms-for-millisecond-p.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="v5-0001-lavfi-drawtext-Add-localtime_ms-for-millisecond-p.pa"; filename*1="tch" RnJvbSBjN2Y3YzdhMWNlZGM0Y2NjNTE5NzdmYzkyNjQ1ZTExMzE2MDhhYzk1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUaGlsbyBCb3JnbWFubiA8dGhpbG8uYm9yZ21hbm5A bWFpbC5kZT4KRGF0ZTogVGh1LCA2IEphbiAyMDIyIDEyOjI0OjQ2ICswMTAwClN1YmplY3Q6 IFtQQVRDSCB2NV0gbGF2ZmkvZHJhd3RleHQ6IEFkZCBsb2NhbHRpbWVfbXMgZm9yIG1pbGxp c2Vjb25kIHByZWNpc2lvbgoKU3VnZ2VzdGVkLUJ5OiBmZm1wZWdAZmIuY29tCi0tLQogZG9j L2ZpbHRlcnMudGV4aSAgICAgICAgICB8ICA4ICsrKysrKysrCiBsaWJhdmZpbHRlci92Zl9k cmF3dGV4dC5jIHwgMjggKysrKysrKysrKysrKysrKysrKysrKysrKystLQogMiBmaWxlcyBj aGFuZ2VkLCAzNCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2RvYy9maWx0ZXJzLnRleGkgYi9kb2MvZmlsdGVycy50ZXhpCmluZGV4IDA1ZDRiMWE1NmUu Ljk2NzAyMWU0OGIgMTAwNjQ0Ci0tLSBhL2RvYy9maWx0ZXJzLnRleGkKKysrIGIvZG9jL2Zp bHRlcnMudGV4aQpAQCAtMTEzNzksMTAgKzExMzc5LDE4IEBAIEl0IGNhbiBiZSB1c2VkIHRv IGFkZCBwYWRkaW5nIHdpdGggemVyb3MgZnJvbSB0aGUgbGVmdC4KIFRoZSB0aW1lIGF0IHdo aWNoIHRoZSBmaWx0ZXIgaXMgcnVubmluZywgZXhwcmVzc2VkIGluIFVUQy4KIEl0IGNhbiBh Y2NlcHQgYW4gYXJndW1lbnQ6IGEgc3RyZnRpbWUoKSBmb3JtYXQgc3RyaW5nLgogCitAaXRl bSBnbXRpbWVfbXMKK1NhbWUgYXMgQGNvZGV7Z210aW1lfSBidXQgd2l0aCBtaWxsaXNlY29u ZCBwcmVjaXNpb24uCitJdCBjYW4gYWNjZXB0IGFuIGFyZ3VtZW50OiBhIHN0cmZ0aW1lKCkg Zm9ybWF0IHN0cmluZy4KKwogQGl0ZW0gbG9jYWx0aW1lCiBUaGUgdGltZSBhdCB3aGljaCB0 aGUgZmlsdGVyIGlzIHJ1bm5pbmcsIGV4cHJlc3NlZCBpbiB0aGUgbG9jYWwgdGltZSB6b25l LgogSXQgY2FuIGFjY2VwdCBhbiBhcmd1bWVudDogYSBzdHJmdGltZSgpIGZvcm1hdCBzdHJp bmcuCiAKK0BpdGVtIGxvY2FsdGltZV9tcworU2FtZSBhcyBAY29kZXtsb2NhbHRpbWV9IGJ1 dCB3aXRoIG1pbGxpc2Vjb25kIHByZWNpc2lvbi4KK0l0IGNhbiBhY2NlcHQgYW4gYXJndW1l bnQ6IGEgc3RyZnRpbWUoKSBmb3JtYXQgc3RyaW5nLgorCiBAaXRlbSBtZXRhZGF0YQogRnJh bWUgbWV0YWRhdGEuIFRha2VzIG9uZSBvciB0d28gYXJndW1lbnRzLgogCmRpZmYgLS1naXQg YS9saWJhdmZpbHRlci92Zl9kcmF3dGV4dC5jIGIvbGliYXZmaWx0ZXIvdmZfZHJhd3RleHQu YwppbmRleCAyYTg4NjkyY2JkLi43MjM0NzNmMjk5IDEwMDY0NAotLS0gYS9saWJhdmZpbHRl ci92Zl9kcmF3dGV4dC5jCisrKyBiL2xpYmF2ZmlsdGVyL3ZmX2RyYXd0ZXh0LmMKQEAgLTUx LDYgKzUxLDcgQEAKICNpbmNsdWRlICJsaWJhdnV0aWwvb3B0LmgiCiAjaW5jbHVkZSAibGli YXZ1dGlsL3JhbmRvbV9zZWVkLmgiCiAjaW5jbHVkZSAibGliYXZ1dGlsL3BhcnNldXRpbHMu aCIKKyNpbmNsdWRlICJsaWJhdnV0aWwvdGltZS5oIgogI2luY2x1ZGUgImxpYmF2dXRpbC90 aW1lY29kZS5oIgogI2luY2x1ZGUgImxpYmF2dXRpbC90aW1lX2ludGVybmFsLmgiCiAjaW5j bHVkZSAibGliYXZ1dGlsL3RyZWUuaCIKQEAgLTEwNDUsMTQgKzEwNDYsMzUgQEAgc3RhdGlj IGludCBmdW5jX3N0cmZ0aW1lKEFWRmlsdGVyQ29udGV4dCAqY3R4LCBBVkJQcmludCAqYnAs CiAgICAgICAgICAgICAgICAgICAgICAgICAgY2hhciAqZmN0LCB1bnNpZ25lZCBhcmdjLCBj aGFyICoqYXJndiwgaW50IHRhZykKIHsKICAgICBjb25zdCBjaGFyICpmbXQgPSBhcmdjID8g YXJndlswXSA6ICIlWS0lbS0lZCAlSDolTTolUyI7CisgICAgaW50NjRfdCB1bm93OwogICAg IHRpbWVfdCBub3c7CiAgICAgc3RydWN0IHRtIHRtOwogCi0gICAgdGltZSgmbm93KTsKLSAg ICBpZiAodGFnID09ICdMJykKKyAgICB1bm93ID0gYXZfZ2V0dGltZSgpOworICAgIG5vdyAg PSB1bm93IC8gMTAwMDAwMDsKKyAgICBpZiAodGFnID09ICdMJyB8fCB0YWcgPT0gJ20nKQog ICAgICAgICBsb2NhbHRpbWVfcigmbm93LCAmdG0pOwogICAgIGVsc2UKICAgICAgICAgdG0g PSAqZ210aW1lX3IoJm5vdywgJnRtKTsKKworICAgIGlmICh0YWcgPT0gJ00nIHx8IHRhZyA9 PSAnbScpIHsKKyAgICAgICAgY2hhciAqc2Vjb25kcyA9IGF2X3N0cmlzdHIoZm10LCAiJVMi KTsKKyAgICAgICAgaWYgKHNlY29uZHMpIHsKKyAgICAgICAgICAgIHNlY29uZHMgKz0gMjsK KyAgICAgICAgICAgIGludCBsZW4gPSBzZWNvbmRzIC0gZm10ICsgMTsKKyAgICAgICAgICAg IGNoYXIgKnRtcCA9IGF2X21hbGxvYyhsZW4pOworICAgICAgICAgICAgYXZfc3RybGNweSh0 bXAsIGZtdCwgbGVuKTsKKworICAgICAgICAgICAgY2hhciAqZm10X25ldyA9IGF2X2FzcHJp bnRmKCIlcy4lMDNkJXMiLCB0bXAsIChpbnQpKHVub3cgJSAxMDAwMDAwKSAvIDEwMDAsIHNl Y29uZHMpOworICAgICAgICAgICAgYXZfYnByaW50X3N0cmZ0aW1lKGJwLCBmbXRfbmV3LCAm dG0pOworCisgICAgICAgICAgICBhdl9mcmVlcCgmdG1wKTsKKyAgICAgICAgICAgIGF2X2Zy ZWVwKCZmbXRfbmV3KTsKKworICAgICAgICAgICAgcmV0dXJuIDA7CisgICAgICAgIH0KKyAg ICB9CisKICAgICBhdl9icHJpbnRfc3RyZnRpbWUoYnAsIGZtdCwgJnRtKTsKICAgICByZXR1 cm4gMDsKIH0KQEAgLTExNTIsNyArMTE3NCw5IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJh d3RleHRfZnVuY3Rpb24gewogICAgIHsgInBpY3RfdHlwZSIsIDAsIDAsIDAsICAgZnVuY19w aWN0X3R5cGUgfSwKICAgICB7ICJwdHMiLCAgICAgICAwLCAzLCAwLCAgIGZ1bmNfcHRzICAg ICAgfSwKICAgICB7ICJnbXRpbWUiLCAgICAwLCAxLCAnRycsIGZ1bmNfc3RyZnRpbWUgfSwK KyAgICB7ICJnbXRpbWVfbXMiLCAwLCAxLCAnTScsIGZ1bmNfc3RyZnRpbWUgfSwKICAgICB7 ICJsb2NhbHRpbWUiLCAwLCAxLCAnTCcsIGZ1bmNfc3RyZnRpbWUgfSwKKyAgICB7ICJsb2Nh bHRpbWVfbXMiLCAwLCAxLCAnbScsIGZ1bmNfc3RyZnRpbWUgfSwKICAgICB7ICJmcmFtZV9u dW0iLCAwLCAwLCAwLCAgIGZ1bmNfZnJhbWVfbnVtIH0sCiAgICAgeyAibiIsICAgICAgICAg MCwgMCwgMCwgICBmdW5jX2ZyYW1lX251bSB9LAogICAgIHsgIm1ldGFkYXRhIiwgIDEsIDIs IDAsICAgZnVuY19tZXRhZGF0YSB9LAotLSAKMi4yMC4xIChBcHBsZSBHaXQtMTE3KQoK --------------8512ADDF647FFE9B0AC0A7D1 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --------------8512ADDF647FFE9B0AC0A7D1--