* [FFmpeg-devel] [PATCH] fftools/ffprobe: fix handling parse_options() return value
@ 2023-07-26 15:31 Anton Khirnov
2023-07-26 16:14 ` James Almer
2023-07-27 19:09 ` Marton Balint
0 siblings, 2 replies; 3+ messages in thread
From: Anton Khirnov @ 2023-07-26 15:31 UTC (permalink / raw)
To: ffmpeg-devel
---
fftools/ffprobe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index a39185f6fe..81610c097b 100644
--- a/fftools/ffprobe.c
+++ b/fftools/ffprobe.c
@@ -4113,7 +4113,7 @@ int main(int argc, char **argv)
show_banner(argc, argv, options);
ret = parse_options(NULL, argc, argv, options, opt_input_file);
if (ret < 0) {
- ret = AVERROR_EXIT ? 0 : ret;
+ ret = (ret == AVERROR_EXIT) ? 0 : ret;
goto end;
}
--
2.40.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] fftools/ffprobe: fix handling parse_options() return value
2023-07-26 15:31 [FFmpeg-devel] [PATCH] fftools/ffprobe: fix handling parse_options() return value Anton Khirnov
@ 2023-07-26 16:14 ` James Almer
2023-07-27 19:09 ` Marton Balint
1 sibling, 0 replies; 3+ messages in thread
From: James Almer @ 2023-07-26 16:14 UTC (permalink / raw)
To: ffmpeg-devel
On 7/26/2023 12:31 PM, Anton Khirnov wrote:
> ---
> fftools/ffprobe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> index a39185f6fe..81610c097b 100644
> --- a/fftools/ffprobe.c
> +++ b/fftools/ffprobe.c
> @@ -4113,7 +4113,7 @@ int main(int argc, char **argv)
> show_banner(argc, argv, options);
> ret = parse_options(NULL, argc, argv, options, opt_input_file);
> if (ret < 0) {
> - ret = AVERROR_EXIT ? 0 : ret;
> + ret = (ret == AVERROR_EXIT) ? 0 : ret;
> goto end;
> }
LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] fftools/ffprobe: fix handling parse_options() return value
2023-07-26 15:31 [FFmpeg-devel] [PATCH] fftools/ffprobe: fix handling parse_options() return value Anton Khirnov
2023-07-26 16:14 ` James Almer
@ 2023-07-27 19:09 ` Marton Balint
1 sibling, 0 replies; 3+ messages in thread
From: Marton Balint @ 2023-07-27 19:09 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Wed, 26 Jul 2023, Anton Khirnov wrote:
> ---
> fftools/ffprobe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> index a39185f6fe..81610c097b 100644
> --- a/fftools/ffprobe.c
> +++ b/fftools/ffprobe.c
> @@ -4113,7 +4113,7 @@ int main(int argc, char **argv)
> show_banner(argc, argv, options);
> ret = parse_options(NULL, argc, argv, options, opt_input_file);
> if (ret < 0) {
> - ret = AVERROR_EXIT ? 0 : ret;
> + ret = (ret == AVERROR_EXIT) ? 0 : ret;
> goto end;
LGTM, thanks.
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-27 19:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-26 15:31 [FFmpeg-devel] [PATCH] fftools/ffprobe: fix handling parse_options() return value Anton Khirnov
2023-07-26 16:14 ` James Almer
2023-07-27 19:09 ` Marton Balint
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git