From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4710942819 for ; Fri, 7 Jan 2022 17:22:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6521968AC14; Fri, 7 Jan 2022 19:22:05 +0200 (EET) Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0304168A6F6 for ; Fri, 7 Jan 2022 19:21:59 +0200 (EET) Received: by mail-ua1-f47.google.com with SMTP id u6so11515376uaq.0 for ; Fri, 07 Jan 2022 09:21:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=sXX/hS/G1cBIl//V+n9Kwyqtn/nCZhSWaX/d3/LUWmU=; b=ghKRokQqLi27HuG1wGDo6VjMgAjVV88UwV67Cn4cdfJb3FHFFN1m2S4BlAul8Hv3+D XrTVAnBQvlMeq9AuoItHSlqcsKCu9PqPwPZF8nSaIYn3oAlx77QpT4v2zclTkEwyIlAJ m3HJWuh9QIMUuNcORGtPKxiebMStKTvWciZcjqIJ4nDyUUq0Qu/4dPsmUCLljZeDf01J c94v7umw1dfFLsz+CjN5bHqVeDtZWsxo6w5wq1N+245V8CxKyRFJMlcvh/w6+Wl0mUtr RynzcqjMyP/oIHEZhMgOaUoo+eKeWJ0M7fO2Pnfv4nJe9u97HfxIAUMAewOkXSe3I+2d 4+4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=sXX/hS/G1cBIl//V+n9Kwyqtn/nCZhSWaX/d3/LUWmU=; b=NIFv1XU8ZVyL4/5petJaa59KUHBE9CYDPnJyBzVLNM8qAHtj4k31wpoYLyOmQTPf2F tYDnyoq6GoGMrhocMzv4o0Bj2RkQXld40L+QYH3ZhhpkaSMgIzRRze9ZL/rJpFc5juUF WaXCAOvi2YHhuZapWp9T/KlXfOrgP8CUE9UmP2KVsxKdfgtAxczRt2KMBhG0J9JCZszO 4QV04q3gGJwd1NY5gEa34IsJqnruq2g4iD5/PvHR7y8euR6zcbKykQX/ZwpMM/sh/OH9 mFkm7dIkqHkTUVMXCDDkgv1drtzWBmUQT5n6OAoeqLKfS7g3S0CrlJlZ7nPdvobAAWBe fjOw== X-Gm-Message-State: AOAM530MJGTfjiXxOyWNS8B/fJK+ojFRS/ghHrkLO3el7I86gkKS7ffb +4Js/G+VBGx2zQMPAPeDabwcXaMURUo= X-Google-Smtp-Source: ABdhPJwfICN0Zrv0SOO0pBtJJV0qt8nz7emcggUDdE92+sIxdV4ucZVocgjlH59UxQbJSOLYP4YJUg== X-Received: by 2002:a67:df84:: with SMTP id x4mr9143813vsk.84.1641576116477; Fri, 07 Jan 2022 09:21:56 -0800 (PST) Received: from [192.168.1.55] ([191.83.210.83]) by smtp.gmail.com with ESMTPSA id h6sm3503619vkc.7.2022.01.07.09.21.55 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jan 2022 09:21:55 -0800 (PST) Message-ID: <14128dde-0bcc-7fdc-b5c0-83f1d1425059@gmail.com> Date: Fri, 7 Jan 2022 14:21:54 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220107142134.821-1-jamrial@gmail.com> <20220107142134.821-2-jamrial@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec/libdav1d: honor the requested skip_frame level X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/7/2022 1:14 PM, Hendrik Leppkes wrote: > On Fri, Jan 7, 2022 at 3:22 PM James Almer wrote: >> >> This supports dropping non-intra, non-key, or all frames. >> >> Signed-off-by: James Almer >> --- >> libavcodec/libdav1d.c | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c >> index 8e45f533cb..9252a2572d 100644 >> --- a/libavcodec/libdav1d.c >> +++ b/libavcodec/libdav1d.c >> @@ -299,6 +299,7 @@ static int libdav1d_receive_frame(AVCodecContext *c, AVFrame *frame) >> #endif >> int res; >> >> +redo: >> if (!data->sz) { >> AVPacket *const pkt = dav1d->pkt; >> >> @@ -363,6 +364,14 @@ static int libdav1d_receive_frame(AVCodecContext *c, AVFrame *frame) >> >> av_assert0(p->data[0] && p->allocator_data); >> >> + if ((c->skip_frame >= AVDISCARD_NONINTRA && (p->frame_hdr->frame_type != DAV1D_FRAME_TYPE_KEY && >> + p->frame_hdr->frame_type != DAV1D_FRAME_TYPE_INTRA)) || >> + (c->skip_frame >= AVDISCARD_NONKEY && p->frame_hdr->frame_type != DAV1D_FRAME_TYPE_KEY) || >> + c->skip_frame >= AVDISCARD_ALL) { >> + dav1d_picture_unref(p); >> + goto redo; >> + } > > Is skipping still meaningful if it doesn't actually speed up decoding? Outputting only I frames, but that's also possible using a filter, i guess. In any case, no alternative for libdav1d unless the actual library adds support for this, so I'll drop this patch. > > - Hendrik > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".