From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 72C8B4280B for ; Wed, 31 Aug 2022 00:08:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B901368BAEC; Wed, 31 Aug 2022 03:08:03 +0300 (EEST) Received: from mail-vs1-f50.google.com (mail-vs1-f50.google.com [209.85.217.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F0AE568B991 for ; Wed, 31 Aug 2022 03:07:56 +0300 (EEST) Received: by mail-vs1-f50.google.com with SMTP id c3so13094200vsc.6 for ; Tue, 30 Aug 2022 17:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=+HTlupPSHdUCiXl/YZlXji23RmlavIGDfuGyTtOkT9M=; b=Tn7sqmjYU0Av78cLLokvWEY0LGrBKpCZOc8zfsfYzdSqf/L7nC36uDln2lrBPOo510 S0gnmYnCQy5IP2kHDpfs3kiPQ2pM8VEbFLPdwVDvzPqd+KAdrXgq/xL50GaQkwFQ9u+m jXKYpC6tE2mNQXxqjisgcdF/xMn0w5Oj0CEBVC8YDtYr3lllsKrZdo5yNHH6L46SY6KQ xgL+vnsiMjQTEmLOM5qiGsTEvLMEhDZwTRTMJwFrvD05LlmazwmjOtzQJWfnfzAdnS9D XCWL3fSNeFS/DYB4mUrf2o81aFt+NPwy9zKYQ4rcNsQzK7i0UrDqZA4W8AVzQPC7IM3D ca/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=+HTlupPSHdUCiXl/YZlXji23RmlavIGDfuGyTtOkT9M=; b=i9Ip8R3J9i9ID5ywf+rbEnSNx4h96sDawPb3IyCIhzmzB0d/jwHk5tV4xJy/5y3qrR WqBbZr24YXUdUxIswPk4/DFJEaamkrBNiPnii6DQjpPfBB96oZXwgjYt2S0Ttm2hTVri hyQy4M15hryg8OXT1cQo8THfovzfpgZ44F5mOaxZMIeKy5k4Kx8A5vB0IFI+zG77yDGu Ld901je5Xw0s3wBV8IRo3ZM5maX30QMNrD2srbViVHtPlw05HOEqJta0S8jhTdx2S11B Zfs5yoOFNDghjepMMAlUT0Hh/GUNoKe9Uo+ok/xoB1ZfYpm3k+1Ajl+f5eiEKEP19vjm 4ZUg== X-Gm-Message-State: ACgBeo3VqX9XDF/vhc9yWU3EVBPuwMG76XJVEdvk9x6ST82oQ88STWN3 7kHG+4VBFZ2URmiTsG5947cOuTHVqHGt0g== X-Google-Smtp-Source: AA6agR7xWqkEvIJozZNDRcv+yZ9kZc2iu+1Kxrn/eZWn9X6GwkmNFnxia+Lt/Ee5fvQcQhXimiQ3+g== X-Received: by 2002:a05:6102:d1:b0:392:96cf:6e73 with SMTP id u17-20020a05610200d100b0039296cf6e73mr1610377vsp.19.1661904474906; Tue, 30 Aug 2022 17:07:54 -0700 (PDT) Received: from [192.168.1.15] (075-115-109-114.inf.spectrum.com. [75.115.109.114]) by smtp.gmail.com with ESMTPSA id m4-20020a1fa304000000b003743e7c87c5sm2095893vke.5.2022.08.30.17.07.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Aug 2022 17:07:53 -0700 (PDT) Message-ID: <13d8707d-df5e-dedd-6a87-b0328e8c0e01@gmail.com> Date: Tue, 30 Aug 2022 20:07:52 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220829000244.71123-1-qyot27@gmail.com> <20220829000244.71123-4-qyot27@gmail.com> From: Stephen Hutchinson In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 3/9] avformat/avisynth: add read_frameprops option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 8/30/22 7:17 PM, Andreas Rheinhardt wrote: > { "avisynth_flags", "set flags related to reading frame properties from > script (AviSynth+ v3.7.1 or higher)", OFFSET(flags), AV_OPT_TYPE_FLAGS, > {.i64 = 1}, 0, 1, AV_OPT_FLAG_DECODING_PARAM, "flags" }, > > This is wrong. It should be > { "avisynth_flags", "set flags related to reading frame properties from > script (AviSynth+ v3.7.1 or higher)", OFFSET(flags), AV_OPT_TYPE_FLAGS, > {.i64 = AVISYNTH_FRAMEPROP_FIELD_ORDER | AVISYNTH_FRAMEPROP_RANGE | > AVISYNTH_FRAMEPROP_PRIMARIES | AVISYNTH_FRAMEPROP_TRANSFER | > AVISYNTH_FRAMEPROP_MATRIX | AVISYNTH_FRAMEPROP_CHROMA_LOCATION}, 0, > INT_MAX, AV_OPT_FLAG_DECODING_PARAM, "flags" } > The default option should be removed. Users can then set the options via > avisynth_flags=+sar-range or via avisynth_flags=matrix or however they wish. > The AVISYNTH_FRAMEPROP_DEFAULT should also be removed (at least, it > should not be part of the bitfield, but you can of course add a define > (or an enum value) equivalent to the default value I used above and you > can use that for the default value above); to know whether field order > should be exported, you simply query via "if (avs->flags & > AVISYNTH_FRAMEPROP_FIELD_ORDER)". For this it is of course important > that the default value is a combination of other bits of the bitfield > and not a bit of its own. > I don't know why I didn't think to use it directly in the avisynth_flags line. Thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".