From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 653E941116 for ; Wed, 15 Jun 2022 04:09:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 21A6E68B679; Wed, 15 Jun 2022 07:09:12 +0300 (EEST) Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9AE8A68B5B7 for ; Wed, 15 Jun 2022 07:09:04 +0300 (EEST) Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4LNBd92ZjLz9sQp for ; Wed, 15 Jun 2022 06:09:01 +0200 (CEST) Message-ID: <13af508d-de1e-333c-ab47-37c43e90720d@gyani.pro> Date: Wed, 15 Jun 2022 09:38:48 +0530 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220614080937.5263-1-ffmpeg@gyani.pro> From: Gyan Doshi In-Reply-To: X-Rspamd-Queue-Id: 4LNBd92ZjLz9sQp Subject: Re: [FFmpeg-devel] [PATCH] avformat: set start_time_realtime when demuxing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2022-06-15 03:18 am, Andreas Rheinhardt wrote: > Gyan Doshi: >> Add new flag AVFMT_START_REALTIME for the couple of demuxers that set it >> internally. >> --- >> doc/APIchanges | 3 +++ >> libavformat/avformat.h | 1 + >> libavformat/demux.c | 3 +++ >> libavformat/rtsp.c | 3 ++- >> libavformat/version.h | 2 +- >> 5 files changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/doc/APIchanges b/doc/APIchanges >> index 5857e67ae6..4aa9e36777 100644 >> --- a/doc/APIchanges >> +++ b/doc/APIchanges >> @@ -14,6 +14,9 @@ libavutil: 2021-04-27 >> >> API changes, most recent first: >> >> +2022-06-xx - xxxxxxxxxx - lavf 59.26.100 - avformat.h >> + Add AVFMT_START_REALTIME flag. >> + >> 2022-06-12 - xxxxxxxxxx - lavf 59.25.100 - avio.h >> Add avio_vprintf(), similar to avio_printf() but allow to use it >> from within a function taking a variable argument list as input. >> diff --git a/libavformat/avformat.h b/libavformat/avformat.h >> index f12fa7d904..4e247d68fc 100644 >> --- a/libavformat/avformat.h >> +++ b/libavformat/avformat.h >> @@ -499,6 +499,7 @@ typedef struct AVProbeData { >> The user or muxer can override this through >> AVFormatContext.avoid_negative_ts >> */ >> +#define AVFMT_START_REALTIME 0x80000 /**< Demuxer sets start_time_realtime */ > This is incorrect: If this were merged, start_time_realtime would always > be set by libavformat; whether it is done by the generic code or by > demuxer specific code is an implementation detail and irrelevant for the > user. Given that it is also set for demuxers without this flag actually > means that libavformat lies when using a demuxer without this flag. This is moot since I'm switching to a new field but would either of these satisfy you? s/Demuxer/Format/ or /**< start_time_realtime is populated with conveyed origin wallclock timestamp */ Regards, Gyan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".