From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C15AD488CE for ; Fri, 22 Mar 2024 02:59:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F389468D565; Fri, 22 Mar 2024 04:59:29 +0200 (EET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B36EB68D541 for ; Fri, 22 Mar 2024 04:59:22 +0200 (EET) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1e00b1c2684so12921815ad.0 for ; Thu, 21 Mar 2024 19:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711076359; x=1711681159; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NISwCctwYu0Ks18COk5J9KZJUl/ftdhYf4ppeLPAIHM=; b=jpJ2bFUq8PYsTDMajXtIzpG1gsLhP7lD7OvCeFe8xkh/5dyOcNBSyc4s453CAX8cK4 fNoSFXML1rKhd3HHLMmUdJ87P3x95uU2RoLQ0kWUZt5/nYsryMZ1fLeFzUMYYRcLVphj we4VO5c0EcR51oaVv3qov00y+akUweO8KOK6pm6nbCXfkdutb+OgaMD9/lCOI2e4TBYV 2UmX4q8oQabXyXN6/e2YeoDSTJsGsCcXilEovX2hZL+WUn6kKxDxLDzTRufnlJXG1YFW W0I3JtqS7uYBWQG0K0oHuPRxvDO1kN4DHoHHvu4QZGxSaTrF7+MRw4K9NmoP8LzVf87n zGuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711076359; x=1711681159; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NISwCctwYu0Ks18COk5J9KZJUl/ftdhYf4ppeLPAIHM=; b=Y1wO8fKGCFSU1Hg2AYr+360tUWRPhF3cXqrMJZA0ZlGXZPuW2JxWEbTXH9QffKqipR AB3vVTqzwD0OzlVQGE8qEv41XTys2CuF9U2PcHDUZqBWzYho1O9V8tRpm2gYmXO2sx7g ObiqSakYSNxeYB/sDuMgHqfvRYpqBhK52uI6RXuLBJBt69sphFzi1hLiCYo45ZBsZ4+k 3k9nHxFNl+2LWxZ5Wg2RzjZeUoF/XL6lpCxUS7R1pdnex7Lj7YhnziDQzg2zavl5xVmu p8QuW7jQGe3ayxVOui5vH+NkPyPB3/8P/uZN+yIOlg0hd9S4069n2/oOMBwGFdIZJL3B dxSw== X-Gm-Message-State: AOJu0Yyj1038XcQhpM+djT3JTtH8wJ95jaEVNk3LYe5kUBOMgYU3zMWr 09H+cdmRsPqKuSef5JpdZd4QxKubC1eCOVf/R/Scdg+uStpPSQ6uJgOhyCYW X-Google-Smtp-Source: AGHT+IE6zRRuuNIPu2wPcif8jGV4w6EFx/LCY2LcAerIt3IMNQpzWXSZigdVNzPuC519fOzAvz/XDQ== X-Received: by 2002:a17:902:e542:b0:1dd:c18f:1886 with SMTP id n2-20020a170902e54200b001ddc18f1886mr1474726plf.65.1711076359153; Thu, 21 Mar 2024 19:59:19 -0700 (PDT) Received: from [192.168.0.10] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id l19-20020a170902d05300b001dcf91da5c8sm640145pll.95.2024.03.21.19.59.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Mar 2024 19:59:18 -0700 (PDT) Message-ID: <139bd591-67d2-407e-a90e-fe34ff3c576d@gmail.com> Date: Thu, 21 Mar 2024 23:59:17 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240322022525.GB6420@pb2> From: James Almer In-Reply-To: <20240322022525.GB6420@pb2> Subject: Re: [FFmpeg-devel] [RFC] Channels X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/21/2024 11:25 PM, Michael Niedermayer wrote: > Hi all > > we have code like > st->codecpar->ch_layout.nb_channels = avio_rb32(pb); > > and then somewhere there is some code that uses this by first allocating > an array and that then hits OOM > (it was this here: > map = av_calloc(nb_channels, sizeof(*channel_layout->u.map));) > > is anyone against adding a max_channels field to AVFormatContext or something > like that ? > > alternative is "wont fix" for all such cases, or maybe someone sees another way ? > > thx We have FF_SANE_NB_CHANNELS, so maybe add a check for it to mxfdec.c (Where i assume this is happening) and mov_chan.c or mov.c before continuing with such a layout. > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".