From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id CFA504D2B7 for ; Sun, 16 Nov 2025 06:57:11 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'A3VNGYALqyzmAFZEUZGsheA0R+7czdIQ4LN4lb18KMs=', expected b'GUlIAaIyipSZcly3gkfp0EmTvh1KIz6X3RWSjkW3OXU=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1763276170; h=mime-version : date : references : to : in-reply-to : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=RQWoW7vlKvBhteCehwSnd4Mg/M9rkWlGBz/j62gfdGs=; b=FAtv/7DIaIEMfOJS7Ih9+m2779ZkGlL4ON2hTOS7Ch7GFA/XMOJ1zhm4Ad1n5ihiYRK0l EAK2/C0r2RseEEeo2duHpG7g+ruceJ+mIqxptrvWfqbjYtiNukSdtFvsquFHHEVUlQlQuVL nwUnApvQvaVV6b9nXJv4TS7zyuzEeP5F/yLKTy05pavN9tM2yQN0SlFPga7X4wE+odxmrBV 26Xb34tb6C04kDSVXaZS08qTuffSJgsqd94tXb5BPoEylBP49P5HdQd1eBztWjZn7TWDguN 8SKXcBNDsGJyVk0DbG6yhD9kAVCDokkXYYlcZcTvrjpt14yE6UtJuH0DPoGw== Received: from [172.19.0.2] (unknown [172.19.0.2]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 353B268FEAC; Sun, 16 Nov 2025 08:56:10 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1763276131; b=Ld1ZVVZeEhKUeLiXfdwrTXpYnU5moJMMjZdRdWqdHUD/2g/F2VBI3rHakZ2cj74ZVh1BU Vpec5xk/+9nM/SlBCJ5WKf0pknNkszxJsUXoorfqdPHjKAIhC34mJ01tc+xsQl4hV1jUOVT kl+IOMdGpYmRGPHOkX8xq4ZdXp+8F3GxrXOn8a0X75f1v3WrK1datWXzcBnO+PwQwEx9EcF JduYNP4ya9WG9riwC5b1MfrpSLqm0j/cWSF475p67PPvhjpWgSsvfjOp3ZVfnPB9nYNb1FB WIToyVuYXMgYEwuk57KreB/MtT9A8zhA+4cHx5cKtL9rPSXjDBSFGcnju6kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1763276131; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=A3VNGYALqyzmAFZEUZGsheA0R+7czdIQ4LN4lb18KMs=; b=VpEwVZ9h0jr16Yd0yliav9DEHVU+gDdAFDURBZvlAI/y/UTAlJBMFY5uSqZPqCvbWtTpH mgl7ZHTVg37sU9OcFDT0Ih7OYRjSpEZx/Dqz+Y8x+sCwgGHYwYAGnFdhZG0P/SP3khuOdI4 /FcD7nvRA/Nl6OfIOK/z9ys1hlAVSdooRiK5aMeKGF1J5eAkEcd1I6JkNLWmBxo+vMo8ede FVFwtNYvCbN4wT1/36gcg9Os4gAQCJb1eE6SA7zRqwwBPzA0GRj/09nYnmNkCQ08XzmPd1w RKYTyVgj1DhUSkNgN2cyQC0wIzXlerlkx3NcTKD42MUPwV++o0ntB1i7897w== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=gmail.com; arc=none; dmarc=pass header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 1562B68FA6D for ; Sun, 16 Nov 2025 08:55:15 +0200 (EET) Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-b6ce6d1d3dcso2220911a12.3 for ; Sat, 15 Nov 2025 22:55:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763276099; x=1763880899; darn=ffmpeg.org; h=message-id:in-reply-to:to:references:date:subject:mime-version:from :from:to:cc:subject:date:message-id:reply-to; bh=GUlIAaIyipSZcly3gkfp0EmTvh1KIz6X3RWSjkW3OXU=; b=SM9jsV8qrbyyqJLvv+eo9rLDGLwEkSQZ3efeWWoxtOIHRbmQsCt4rZbDqdUBvla6T6 iCJIHA4BYexNXTviDWw0dLpHH9EpjNfOqyn05zEtDv5ftdebaEgK91+2txEagAeK1ng1 yNtFwpNRedByJIkedRusHWAJz4iEyX7eStwIbAgXxM/DZ4GHKPk/4edu4WBOvXwvcO7F wK8hnoyAaTkkSi7p7iNLEDdWgNf6NIcZynzlJBWzuGK9TYS01LXhIcw0dPtdYwZYLsiU G3LHt7y4YctdqAqOWaxoead2/lB9s1ZHEMZy1SDM99xVg5dFGPye1r9ZCiqSLP3ICtkB T2Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763276099; x=1763880899; h=message-id:in-reply-to:to:references:date:subject:mime-version:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GUlIAaIyipSZcly3gkfp0EmTvh1KIz6X3RWSjkW3OXU=; b=qqAHHTjj/wz88z87Zn2Dz2g0ybT04JSwdTjNPt3tkPcM7aR4TygASMs88bFcKQT7Pn JS3pC/5PFRfPB0ZFtFpkxa3Ut0xnIbRvjTTknfkPF7QY7KxOqabiFNVEipjJ9X2klxPb u7KN5T8zT6UoiHcz6vuwnj+ynkgMldcXfFN9WpaWOvqLJWS9RPs6cDtrOPP9yzsdTzRO bh3yRIRBImoscH+oS8DRszaI/j3VG9pSx5aAxuR55S3SSrf2h4Rnl6hXGN4MPkzrd9HS 7a81R7DF/P8m06N3R8PMDuUNlkLwSYNSR3EjISrQRITmi34XDg6nquIJBwQEqmsefZ+F F9fg== X-Gm-Message-State: AOJu0Yy0oXNUcHx9D6gcB804e1oaBEqkacwfyiCRqfM3kU63E6K2c16q Hn4DA3Xtkvl8RD7v6yatfYVdhAxGveRrDIrTSHU8LfgVdmowICp4rOy10L17Kg== X-Gm-Gg: ASbGncsuLdaK774YpalCVzQmy6iQP3b3wt/Tm/LJITO4y8s0InQBkdO0lXRWNgJJKyc 9P47qCc4Tu1mo5HW8Y9pfWN0UdNeAiUBGZ9R0n3vHuV/oDOSaQ0BQZLDp6sEnqTggRSMi8Ojfrc IE7PFoN8+VOy2YAmGhvsLTFZr1Gqg7xqoy1ntnhFmKoaCXjNXN4N2Hy1kbdQDtrVvX1VpnXq4Uu E8HuCT9bGg8zCudO8eA4rm+T8sjbcD/QCYZqmMBmouoCY0aXon3lHSFEV3SIXIGvCavAlfrpAAk wZM0XsxxvZRH8kL/jtvf37+pcn+q2A1umuSDZgJlWgZo9cjnAE2afPDmW2PlPc8cEh41bwto2dc GzzYeCiWf8HM78ReGdVoUb7tsDJfPY5Ibf/ksTZW9xB9eM9Bse6zhFk8z+LoTKrkD8GAeVMbb4l pG2K2X/qrYL6B2XNOSjJAQdHFUa831wHAYkA== X-Google-Smtp-Source: AGHT+IGFfK4GGwj9rlGcAmwi7ROP/1oBpLgPZlj5A1X05L7Zww0NH/NVaZmMNUQ0SX4Lwl4imr6YGA== X-Received: by 2002:a05:7300:a987:b0:2a4:3593:6464 with SMTP id 5a478bee46e88-2a4abb1c750mr4890039eec.20.1763276098297; Sat, 15 Nov 2025 22:54:58 -0800 (PST) Received: from smtpclient.apple ([23.247.137.216]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2a49db7a753sm30266304eec.6.2025.11.15.22.54.57 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Nov 2025 22:54:58 -0800 (PST) Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Date: Sun, 16 Nov 2025 14:54:44 +0800 References: <176193037214.25.14686032640135071484@2cb04c0e5124> To: FFmpeg development discussions and patches In-Reply-To: Message-Id: <12AAAEBD-B495-4A51-BEB2-6F998615996F@gmail.com> X-Mailer: Apple Mail (2.3826.700.81) Message-ID-Hash: CCR7VO2OAWLRQTGU2KEBNJIFUQONWRBY X-Message-ID-Hash: CCR7VO2OAWLRQTGU2KEBNJIFUQONWRBY X-MailFrom: SRS0=EATL=5Y=gmail.com=jacklau1222gm@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Content-Filtered-By: Mailman/MimeDel 3.3.10 X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] Re: [PATCH] avformat/whip: Fix rtp_ctx->streams access (PR #20805) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Jack Lau via ffmpeg-devel Cc: Jack Lau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: > On Nov 10, 2025, at 08:24, Michael Niedermayer via ffmpeg-devel wrote: > > Hi Kieran > > On Sat, Nov 01, 2025 at 02:37:45AM +0000, Kieran Kunhya via ffmpeg-devel wrote: >> On Fri, 31 Oct 2025, 17:06 michaelni via ffmpeg-devel, < >> ffmpeg-devel@ffmpeg.org> wrote: >> >>> PR #20805 opened by michaelni >>> URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20805 >>> Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20805.patch >>> >>> Fixes: out of array access >>> No testcase >>> >>> Found-by: Joshua Rogers with ZeroPath >>> Signed-off-by: Michael Niedermayer >>> >>> >>>> From e01eb935a6b919d0bc4361e30a0ab00ff01783af Mon Sep 17 00:00:00 2001 >>> From: Michael Niedermayer >>> Date: Fri, 31 Oct 2025 18:00:11 +0100 >>> Subject: [PATCH] avformat/whip: Fix rtp_ctx->streams access >>> >>> Fixes: out of array access >>> No testcase >>> >>> Found-by: Joshua Rogers with ZeroPath >>> Signed-off-by: Michael Niedermayer >>> --- >>> libavformat/whip.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/libavformat/whip.c b/libavformat/whip.c >>> index a11fffb9c6..6a9b208f69 100644 >>> --- a/libavformat/whip.c >>> +++ b/libavformat/whip.c >>> @@ -1592,8 +1592,8 @@ static int create_rtp_muxer(AVFormatContext *s) >>> * therefore, we deactivate the extradata detection for the RTP >>> muxer. >>> */ >>> if (s->streams[i]->codecpar->codec_id == AV_CODEC_ID_H264) { >>> - av_freep(&rtp_ctx->streams[i]->codecpar->extradata); >>> - rtp_ctx->streams[i]->codecpar->extradata_size = 0; >>> + av_freep(&rtp_ctx->streams[0]->codecpar->extradata); >>> + rtp_ctx->streams[0]->codecpar->extradata_size = 0; >>> } >>> >>> buffer = av_malloc(buffer_size); >>> >> >> Both the original code and the fix are weird. > > I agree, a better fix is welcome, Hi This PR https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20931 try to fix it Thanks for pointing this issue out Regards, Jack > but until then, this fix was approved by 3 people > including the author of teh whip code. And it fixes the out of array access > fixing the weirdness is out of the scope of this fix. > > thx > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Its not that you shouldnt use gotos but rather that you should write > readable code and code with gotos often but not always is less readable > _______________________________________________ > ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org > To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org