From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 284A34A009 for ; Fri, 17 May 2024 15:42:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AC18268D2DC; Fri, 17 May 2024 18:42:33 +0300 (EEST) Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B863268D178 for ; Fri, 17 May 2024 18:42:27 +0300 (EEST) Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a59b49162aeso453111566b.3 for ; Fri, 17 May 2024 08:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715960547; x=1716565347; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=LP7cnmX/wmXAZwesiWjqw0c5xlwfcADUSTfFQS8KupA=; b=TWhZ0RBq6iUy2Otdb2h5bnSUpQz/GZn5uC+VK5GKpMAIiDf5eWf7wDhoOoGkQsDN+j CIl5MO4R97Sh4gZ1wBlrlNnjBXcfGs8ibC49DUcef5XhdCUk+p4fVzYjVfmPhiIWRW65 I7Y4XBlYsGjpK30g9w1QmZyqft2+PYpAY88eIOjc7q1h4Z9FwJtUJ9sQVi4F+dqZqAya U6N5W0jwLw67kQoiic92PBnwCnx5F5YuQUIRVXYB6Zavoq81g4FIl4gDAcFEPnQ91rQU mY3VQPre+JizhNj/jGV3ZlYpl66o7bQBJkpDvQPVrj93GCRYwKzzUw4Ard9cNhe1yPKd WZhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715960547; x=1716565347; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LP7cnmX/wmXAZwesiWjqw0c5xlwfcADUSTfFQS8KupA=; b=H6sKCl9ZhTBs6ruayuM6xW0mt4m72TgjfO36der512LwJLB+mHq9WSKrgbmlUwS3gv MjZ6MLUCmgSvTDnGEUyewOTNAdpR9sQsveIsmYTRP3kCl/htgQXvpaXNB0W0/ZdnWZst l7Zub9lqjZwlZnboo8pMWm4D/jcADCcBy7JVQY6UC7DGVj/VQLyiQrw6en/Le9vAkIpz iFoBqUtT+Mqok92bWqOWZwPubGLhZD1yIcxVz7nANJcrgSwK96P5+v5lzVo9dRE68i70 DyINtB5vtuwfpc1IWRr2EJF6uWUSrQTx26ux84JRSdGS+TH9azLwGZFlZebDQpdQsk8R rx+A== X-Gm-Message-State: AOJu0Yw10pLuZrmlmQjqKYS+4DKaww2k1/bnDL3cyKbJA4MEOzYs+qQf XgtSLsfwkJINtelV0glQ6tEw9yCVaEOA3ml+n+C3woGho1aUHxqMohyVNQ== X-Google-Smtp-Source: AGHT+IHRm4EiCvwO2qrHN6cU7nb+v3bn8vE/GFUtebmNF6eo3nGp1Axf4QOIhAc5mgzRKjHXENpDVg== X-Received: by 2002:a17:906:5aca:b0:a59:99cb:d862 with SMTP id a640c23a62f3a-a5a2d5c9d9dmr1487687866b.39.1715960546850; Fri, 17 May 2024 08:42:26 -0700 (PDT) Received: from [192.168.178.30] (dynamic-2a01-0c22-a5bd-6600-58e8-b28e-8af1-2ac1.c22.pool.telefonica.de. [2a01:c22:a5bd:6600:58e8:b28e:8af1:2ac1]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a5ceb46c33fsm214398666b.142.2024.05.17.08.42.25 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 May 2024 08:42:26 -0700 (PDT) From: epirat07@gmail.com To: FFmpeg development discussions and patches Date: Fri, 17 May 2024 17:42:24 +0200 X-Mailer: MailMate (1.14r6022) Message-ID: <1296CAFB-CC81-442A-88D6-7CBC1E1F6C52@gmail.com> In-Reply-To: References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 3/6] avformat/tee: Constify AVDictionaryEntry* pointee where possible X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 17 May 2024, at 17:25, Andreas Rheinhardt wrote: > This is in preparation for using av_dict_iterate(). > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/tee.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavformat/tee.c b/libavformat/tee.c > index 1cbbb80dbb..87159681ed 100644 > --- a/libavformat/tee.c > +++ b/libavformat/tee.c > @@ -158,7 +158,7 @@ static int open_slave(AVFormatContext *avf, char *slave, TeeSlave *tee_slave) > { > int i, ret; > AVDictionary *options = NULL, *bsf_options = NULL; > - AVDictionaryEntry *entry; > + const AVDictionaryEntry *entry; > char *filename; > char *format = NULL, *select = NULL, *on_fail = NULL; > char *use_fifo = NULL, *fifo_options_str = NULL; > @@ -172,8 +172,9 @@ static int open_slave(AVFormatContext *avf, char *slave, TeeSlave *tee_slave) > return ret; > > #define CONSUME_OPTION(option, field, action) do { \ > - if ((entry = av_dict_get(options, option, NULL, 0))) { \ > - field = entry->value; \ > + AVDictionaryEntry *en = av_dict_get(options, option, NULL, 0); \ > + if (en) { \ > + field = en->value; \ > { action } \ > av_dict_set(&options, option, NULL, 0); \ > } \ > -- > 2.40.1 > LGTM, thanks! > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".