From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5C53B41A05 for ; Fri, 14 Jan 2022 09:28:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DF27A68B4C8; Fri, 14 Jan 2022 11:28:21 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 24CB968B481 for ; Fri, 14 Jan 2022 11:28:15 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 20E9SE0x008912-20E9SE10008912; Fri, 14 Jan 2022 11:28:14 +0200 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 9B2B3A1428; Fri, 14 Jan 2022 11:28:14 +0200 (EET) Date: Fri, 14 Jan 2022 11:28:14 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <1642150837-22960-2-git-send-email-lance.lmwang@gmail.com> Message-ID: <126c1b4-58f-69ea-ab48-f31b57f49fc7@martin.st> References: <1642070709-3104-1-git-send-email-lance.lmwang@gmail.com> <1642150837-22960-1-git-send-email-lance.lmwang@gmail.com> <1642150837-22960-2-git-send-email-lance.lmwang@gmail.com> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec/libopenh264enc: make the profile configuablable correctly X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Limin Wang Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 14 Jan 2022, lance.lmwang@gmail.com wrote: > From: Limin Wang > > d3a7bdd4ac54349aea9150a234478635d50ebd87 was based on incorrect conclusions > because we had missed to set uiProfileIdc. > > If the version of libopenh264 >= 1.8, we can't configured main profile as > expected, below is the testing cli: > > ffmpeg -y -f lavfi -i testsrc -c:v libopenh264 -profile:v main -frames:v 1 test.ts > It'll report: > [libopenh264 @ 0x5638300] Unsupported profile, select EProfileIdc PRO_BASELINE in libopenh264. Given the referenced commit, the fact that you can't use main profile with 1.8 (or high profile with older) isn't a surprise as that was part of the deliberate design in that commit, so I'm not sure if this is a good example to include. Or reword it to say that "due to the limitations set in , you weren't able to use main profile with OpenH264 1.8, or high profile with older versions". > Signed-off-by: Limin Wang > --- > libavcodec/libopenh264enc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c > index 5b5914c..8e27edb 100644 > --- a/libavcodec/libopenh264enc.c > +++ b/libavcodec/libopenh264enc.c > @@ -220,19 +220,16 @@ static av_cold int svc_encode_init(AVCodecContext *avctx) > #endif > > switch (s->profile) { > -#if OPENH264_VER_AT_LEAST(1, 8) > case FF_PROFILE_H264_HIGH: > param.iEntropyCodingModeFlag = 1; > av_log(avctx, AV_LOG_VERBOSE, "Using CABAC, " > "select EProfileIdc PRO_HIGH in libopenh264.\n"); > break; > -#else > case FF_PROFILE_H264_MAIN: > param.iEntropyCodingModeFlag = 1; > av_log(avctx, AV_LOG_VERBOSE, "Using CABAC, " > "select EProfileIdc PRO_MAIN in libopenh264.\n"); > break; > -#endif > case FF_PROFILE_H264_CONSTRAINED_BASELINE: > case FF_PROFILE_UNKNOWN: > param.iEntropyCodingModeFlag = 0; For this fallback case, I think we should set s->profile to FF_PROFILE_H264_CONSTRAINED_BASELINE or something similar (does OpenH264 work correctly with FF_PROFILE_H264_CONSTRAINED_BASELINE too, or only with FF_PROFILE_H264_BASELINE which is equal to PRO_BASELINE), as we otherwise would be setting unknown values into uiProfileIdc. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".