From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E4A6244CAF for ; Wed, 14 Dec 2022 20:14:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DDB9868BB37; Wed, 14 Dec 2022 22:14:05 +0200 (EET) Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EFBCE68BBF2 for ; Wed, 14 Dec 2022 22:13:58 +0200 (EET) Received: by mail-il1-f173.google.com with SMTP id h17so7130928ila.6 for ; Wed, 14 Dec 2022 12:13:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=M8+ImyqZjEzVw/y4E0iIELvrXmS+b/vtwTRVPsKFd4Y=; b=YJaBpLrR5bcFJzXkVMbp/oyR9X6LqVustHtSmULxfFP1s706lAbHQp7yo+DZ58qEZu zYFk57Cvnn0Y39+5GnUJiVcnR/qrk/FLpYnippha+wBEXZKwShAmTDV/Ld5zpzqOPR2I m0crLay98Em/bhBGIN/1zegz5M93qCAj4kGh6XsCtdFk9Ggl2D2fALDHjNZMHA4P5hsN 5RiSYws7l1NZ8ICPBgn+h6p7P6aFO63kJHH+qcKNg3zpdxoLzTXc+SYQ78Mb3/PpnqPW GA9MxtrfBqgu+pMNrOF52xnRy2KZYkben0xk2+VvNrn44TBVJ39iliNU7LsdStbsSdn5 GHWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M8+ImyqZjEzVw/y4E0iIELvrXmS+b/vtwTRVPsKFd4Y=; b=WEEC6YcJ4WEwGd+b7a7BncTTr/suFmrPmGiUxc7BkoTvhR1F6CFS5B0/M0/ls2xBOa 25kqMpmuexaYDFUuZvB3o0eoSr6H5dkLm2by9+2iHwvmxY6L4KPVXNMAO6EaINYWIOeb svGssmVReL+40NMXIRBHUiav5ouBiuUbTIUBW0h2eqrA8KcGipcMrh8h0aqtO4agQ2FN xpBjkawB1KlkYaqq8cLs8TCQRvMMjcopGhJH9OGVTpaY4rJcl4zGJwIs+tVxyFsnT9xm SIDTdJbPKfFbHtL9F/a5coo2GVadi0qzJCHKbr2Qbom3lZuJ6voxUgaJxQNzDvvUyBGV vcGA== X-Gm-Message-State: ANoB5png/Ev/76HcrSKt+20aMQddtk6uYR4tYY9QxhMRzW4o5LC1IQwT AksPbUyAGc7jwNSXPtPzYlM067ad4/I= X-Google-Smtp-Source: AA0mqf4PoNNylME/yyuiV1ZuzSZ6D9w0tNiG/vQUhrQtpNe/TBk7pERlnzmLzAJrkyZHTZteBYMNsw== X-Received: by 2002:a92:ca89:0:b0:300:ed0e:30bf with SMTP id t9-20020a92ca89000000b00300ed0e30bfmr13041989ilo.14.1671048837346; Wed, 14 Dec 2022 12:13:57 -0800 (PST) Received: from [192.168.1.35] (c-68-41-54-207.hsd1.mi.comcast.net. [68.41.54.207]) by smtp.gmail.com with ESMTPSA id e18-20020a022112000000b0038a06a14b37sm2044247jaa.103.2022.12.14.12.13.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Dec 2022 12:13:56 -0800 (PST) Message-ID: <124f2513-26df-7881-af50-0e25ff9b7313@gmail.com> Date: Wed, 14 Dec 2022 15:13:56 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Content-Language: en-US-large To: FFmpeg development discussions and patches References: <20221116114306.251999-1-leo.izen@gmail.com> <166972044003.4503.6154057733583441158@lain.khirnov.net> From: Leo Izen In-Reply-To: <166972044003.4503.6154057733583441158@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/pnm: avoid mirroring PFM images vertically X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/29/22 06:14, Anton Khirnov wrote: > Quoting Leo Izen (2022-11-16 12:43:06) >> PFM (aka Portable FloatMap) encodes its scanlines from bottom-to-top, >> not from top-to-bottom, unlike other NetPBM formats. Without this >> patch, FFmpeg ignores this exception and decodes/encodes PFM images >> mirrored vertically from their proper orientation. >> >> For reference, see the NetPBM tool pfmtopam, which encodes a .pam >> from a .pfm, using the correct orientation (and which FFmpeg reads >> correctly). Also compare ffplay to magick display, which shows the >> correct orientation as well. >> >> See: http://www.pauldebevec.com/Research/HDR/PFM/ and see: >> https://netpbm.sourceforge.net/doc/pfm.html for descriptions of this >> image format. >> >> Signed-off-by: Leo Izen >> --- >> libavcodec/pnmdec.c | 10 ++++++++++ >> libavcodec/pnmenc.c | 18 ++++++++++-------- >> tests/ref/lavf/gbrpf32be.pfm | 2 +- >> tests/ref/lavf/gbrpf32le.pfm | 2 +- >> tests/ref/lavf/grayf32be.pfm | 2 +- >> tests/ref/lavf/grayf32le.pfm | 2 +- >> 6 files changed, 24 insertions(+), 12 deletions(-) > > Looks reasonable, will push soonish. > I got a LGTM, can someone push this? Thanks. - Leo Izen (thebombzen) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".