From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 3D60643D97
	for <ffmpegdev@gitmailbox.com>; Wed, 10 Aug 2022 22:02:28 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E12E868B7C4;
	Thu, 11 Aug 2022 01:02:25 +0300 (EEST)
Received: from btbn.de (btbn.de [136.243.74.85])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 42A4A68B5F7
 for <ffmpeg-devel@ffmpeg.org>; Thu, 11 Aug 2022 01:02:19 +0300 (EEST)
Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id E812E2F4A4F
 for <ffmpeg-devel@ffmpeg.org>; Thu, 11 Aug 2022 00:02:18 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org;
 s=mail; t=1660168938;
 bh=OButiaj1RHStvH8rQJAqwGSMaetB7MCTf9E3FQ5+tZA=;
 h=Date:Subject:To:References:From:In-Reply-To;
 b=Qhxiwlv2KuJetZPEhsBSedUD1vMTow2WF6rvpwP36bWzklIWYqUaG9jcp4JOfwZI+
 FEIOdgY+5+h3+ASin3OYU2sXwav4Va4jwfTg/e9YQvr+cwaoPKQfA034fkF84q62N5
 ZV//ZqVmtk+bsYS+sFLw8x7om5g/TpaletRrJ86ctHU4vbb2Ud//iC+FEjXWMiqnyn
 GQVzamoGAnO1EWfEENDQjdGLalCgEFS0t/GRpHqRnoay9CHaLrkLHb8y5CBj8X///T
 tWCjGPob/W2RawZwQKIbX8nFeJLpq3QEbQynTTwG2sAZsyJjtwqE7UBEbkrcn4rHuA
 n0suJv9sAY02w==
Message-ID: <120c0de5-deb3-a966-b98e-d4cdd1e744ca@rothenpieler.org>
Date: Thu, 11 Aug 2022 00:02:18 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.2
Content-Language: en-US
To: ffmpeg-devel@ffmpeg.org
References: <20220810204712.3123-1-timo@rothenpieler.org>
 <20220810204712.3123-10-timo@rothenpieler.org>
 <DB6PR0101MB2214663E27E5EB887406FE038F659@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com>
From: Timo Rothenpieler <timo@rothenpieler.org>
In-Reply-To: <DB6PR0101MB2214663E27E5EB887406FE038F659@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com>
Subject: Re: [FFmpeg-devel] [PATCH 10/11] swscale: add SwsContext parameter
 to input functions
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/120c0de5-deb3-a966-b98e-d4cdd1e744ca@rothenpieler.org/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On 10.08.2022 23:55, Andreas Rheinhardt wrote:
> Don't you need to update the assembly, too? (Do we support anything x86
> where the callee has to clean up the stack?)

We concluded on IRC that that's not neccesary.
The assembly is pretty hard written to be cdecl, in which the caller 
cleans up the stack.

I tried adding the parameter there, and broke it in the process.
But fate still passes and the assembly isn't suddenly gonna change 
calling convention.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".