From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E5E584035A for ; Sun, 18 Jun 2023 21:56:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EF86D68BF5A; Mon, 19 Jun 2023 00:56:19 +0300 (EEST) Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AF72B68AC01 for ; Mon, 19 Jun 2023 00:56:13 +0300 (EEST) Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-3f8b0649010so8575001cf.0 for ; Sun, 18 Jun 2023 14:56:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687125372; x=1689717372; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mXB75d+J63rXENlaTAwE5ZB/pkkDTE3Zfa8RG1gIVD8=; b=Dhe1QyYngemnvbGS9HMCCBrX33XuuyNr2bYJxUzJhSdbhHzDVVjkzd+r6DRBYd/XAM AeRB6D7F4xbj0HTtorl5PzLcJJGm8t6H2thGSQcYrRyDbw0LUMpyo9sdaoSz/mEewvXD Lss8CizqOSmme7WrhTwBTNGOg16jsjktQ3ArYeKqzBVKEmZyD7o3KgbFAC8QeXJrOdW+ F6PljB79xqSn4vVuVcxiujcSA4sDNYpd+qEj4Jq1RU869JwnuxHaKo7ajwMTerg6KSE7 wrvUSfPWTtShjt0ly94j8/hJ78IKoDgxXYp8Pb0TMvo1wDrhsAUcZpmCrV/mL0X5ucKR fEOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687125372; x=1689717372; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mXB75d+J63rXENlaTAwE5ZB/pkkDTE3Zfa8RG1gIVD8=; b=YdO9uTLAhij18v4Ha5SWgNSxZUV5aH4MwpSBP1wPjRoez6kRacYd5ZYsOxoNUFr+TA KDpGATr6eA/TOTtpst2YB7/eKPD3lMgSlfSGlY0dHhz8VnJtB2U6F00hxL06e+6iiyVj 70pew2pWHHVzH0znhujY26Df/6qz1i7Mh83ywWfNH2P7VfOUzs/TrXvNtb6Pd6R6QXlS 21iFGIuLoNCBaVP2/O0XN5ABQ6jV9X0yPEh7XPQundHvUO8WZoIu8T2leQrcHDmcKWlD A4qqq9To3RiNDK4J/BPbVvMsVe/wMdRrRDbLkeObMzVZe1MiJaIMga3wHhCDVAy2tEC+ yd3A== X-Gm-Message-State: AC+VfDznO0MwYltEGnv6E9zwCzuYafK6q4s+uhTlLjdOq6Qk+heF0TGA MFRkD8V8QxtsJp7Xp+XnIbKItPi+jiw= X-Google-Smtp-Source: ACHHUZ7lPWjoRhcv11NBAhlqP+CtYLY6jGezJKL0bQbUecNFQRVve5JavsvICTzbmT2iHZ6nde78/g== X-Received: by 2002:ac8:7fca:0:b0:3f9:c9f3:67b0 with SMTP id b10-20020ac87fca000000b003f9c9f367b0mr12491035qtk.5.1687125372212; Sun, 18 Jun 2023 14:56:12 -0700 (PDT) Received: from [172.16.103.28] (c-73-144-192-57.hsd1.mi.comcast.net. [73.144.192.57]) by smtp.gmail.com with ESMTPSA id ca22-20020a05622a1f1600b003f6c9f8f0a8sm389023qtb.68.2023.06.18.14.56.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Jun 2023 14:56:11 -0700 (PDT) Message-ID: <12007edc-dc9f-d8e8-4fe5-4fb901785737@gmail.com> Date: Sun, 18 Jun 2023 17:56:09 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230618215021.3044-1-michael@niedermayer.cc> From: Leo Izen In-Reply-To: <20230618215021.3044-1-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 1/6] avformat/jpegxl_anim_dec: Perform operations in a different order X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/18/23 17:50, Michael Niedermayer wrote: > Fixes: OOM > Fixes: 59802/clusterfuzz-testcase-minimized-ffmpeg_dem_JPEGXL_ANIM_fuzzer-5681765466112000 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavformat/jpegxl_anim_dec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/jpegxl_anim_dec.c b/libavformat/jpegxl_anim_dec.c > index 6ea6c46d8f..c62b596f76 100644 > --- a/libavformat/jpegxl_anim_dec.c > +++ b/libavformat/jpegxl_anim_dec.c > @@ -227,7 +227,7 @@ static int jpegxl_anim_read_packet(AVFormatContext *s, AVPacket *pkt) > if (ctx->initial && size < ctx->initial->size) > size = ctx->initial->size; > > - if ((ret = av_new_packet(pkt, size) < 0)) > + if ((ret = av_new_packet(pkt, size)) < 0) > return ret; > > if (ctx->initial) { Pushed the first patch, I maintain this code and it LGTM. I left others pending. - Leo Izen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".