Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Raphaël Zumer" <raphael.zumer@vimeo.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [RFC] [PATCH] avcodec/codec_par: Keep format channel layout if specified
Date: Tue, 25 Jul 2023 15:37:21 -0400
Message-ID: <117ddb25-255e-984b-88f6-0bbb566be472@vimeo.com> (raw)
In-Reply-To: <169031118925.26513.5879912182026565782@lain.khirnov.net>

Thanks for the reply; I wasn't looking to merge the RFC as-is, but rather to figure out the preferred approach, and most importantly make sure that there is no fundamental disagreement on suppressing codec-level metadata in situations where it conflicts with format-level.

I will see which of the alternative implementations comes out cleaner (*probably* a separate function due to the multiple call locations) and either send a v2 RFC patch or separate set later.

Raphaël Zumer

On 7/25/23 14:53, Anton Khirnov wrote:
> Quoting Vittorio Giovara
>> Any comments on this patch? If no objections I'd like to push it at the end
>> of the week
> Sorry, not acceptable. This is the wrong place to do it.
>
> AVCodecParameters is a dumb container for parameters. It MUST NOT make
> any assumptions about who calls it or for what purpose. The caller tells
> it to copy data - it copies data.
>
> Sadly I don't have the time to think about this in depth right now (ask
> me again in 3 weeks or so), but some potential alternatives:
> * handle this explicitly in the caller
> * add a new function, say avcodec_parameters_update(), perhaps with a
>    flags parameter controlling how exactly is the update to be performed;
>    not entirely sure this generalizes well enough
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2023-07-25 19:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-15 14:51 Raphaël Zumer
2023-07-25 17:27 ` Vittorio Giovara
2023-07-25 18:53   ` Anton Khirnov
2023-07-25 19:37     ` Raphaël Zumer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=117ddb25-255e-984b-88f6-0bbb566be472@vimeo.com \
    --to=raphael.zumer@vimeo.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git