From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 84A8F440B2 for ; Thu, 25 Aug 2022 17:39:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5047868B9A3; Thu, 25 Aug 2022 20:39:51 +0300 (EEST) Received: from mail-vk1-f181.google.com (mail-vk1-f181.google.com [209.85.221.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0551968B93E for ; Thu, 25 Aug 2022 20:39:45 +0300 (EEST) Received: by mail-vk1-f181.google.com with SMTP id j4so10332094vki.0 for ; Thu, 25 Aug 2022 10:39:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=GZLlUaXbmIomcD1P/pCghHwg8ajh+atbmuaMs0AmUy4=; b=jQcHMJanccX0Vlfb7cfwGpJTlHaX/fJjUIOw4sh1rWjDybZox0pAsLNkunMsWtl+no uYRM0ccGxnahUkezi7H+kXAAlZqedHxV/R/x10a1Ywp7pb5fxMA1jDtyW6+pYJhjH6EK bOxjiG48MX5QYFW5WEJ0UFNmYMbS1xFPsj9wPoRPvlCtXhshIGOerqrKHJhoH7QtkfHL tPqtf2K+PFxgoEyKSZmLEVKXiNROiy9ikby3OzFfPg086GG324q9Qc8ZTYnREZV3uxfO qDu0yJs0/idzuWv2oRTgReSaO9uBOJWNz4FvXOgj6gw2B7k/VMJzKv2KOZ8QeghKd617 Z7Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=GZLlUaXbmIomcD1P/pCghHwg8ajh+atbmuaMs0AmUy4=; b=mRxwjtAugYuOfNi6D9rxxY9eV/EPWqnokPAt5IyRBe4dT+9UYArUjxbpTW/TKyTqlT OyzRR6Wn1ur5L6r8kWCcAlggUGsmofBSHEhh7pIK0Ck4wj33x71zfSJ3ouR+wEnZjpAY QnR775s/9jlH3+ODFPydzXQNiHYXrZg1/1rueKZyUfp0V7aqrUKxYNtPthr0RCcwAWUt i2nIT4x2FmLnJhGnQCS8Hh9+dyeg1VaUtBhi/uKf352fFnpP4AI0sh6uijQo4PiwWGcr dY9s7e2ZK5W21ya3twYHamkCjFBQH3o0AFasKBCCPPtYojiupIkXXtOb041dqDMIApaS yy1Q== X-Gm-Message-State: ACgBeo2lDev2FED1LNYhGc4W+lPijb9g46GiWazDlcKsQcl0iTa0BSUZ cWtiNs4xkXw4QZMCGBz+uIF7ezr90h0= X-Google-Smtp-Source: AA6agR5JE5ONXwaiC6PTRbx3MfD6hKn+xSuoim0c67kS3iljl+94vaYxs1lTBX/PVTBbxhhbkNBg5g== X-Received: by 2002:a05:6122:d86:b0:37d:3fe:df43 with SMTP id bc6-20020a0561220d8600b0037d03fedf43mr1969471vkb.15.1661449183102; Thu, 25 Aug 2022 10:39:43 -0700 (PDT) Received: from [192.168.0.13] ([191.97.187.183]) by smtp.gmail.com with ESMTPSA id b134-20020a1fb28c000000b0038ca654efa6sm7069793vkf.19.2022.08.25.10.39.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Aug 2022 10:39:42 -0700 (PDT) Message-ID: <11620435-fb87-7dba-f761-411bb0bb683b@gmail.com> Date: Thu, 25 Aug 2022 14:39:42 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220825171618.1264-1-jamrial@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: add init cleanup flag X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 8/25/2022 2:34 PM, James Zern wrote: > On Thu, Aug 25, 2022 at 10:16 AM James Almer wrote: >> >> Signed-off-by: James Almer >> --- >> There doesn't seem to be any proper API to check if an encoder is open. >> > > true. > >> libavcodec/libaomenc.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> > > lgtm. Will apply, thanks. > >> diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c >> index 485f554165..fb9a6ff8b2 100644 >> --- a/libavcodec/libaomenc.c >> +++ b/libavcodec/libaomenc.c >> @@ -400,7 +400,7 @@ static av_cold int aom_free(AVCodecContext *avctx) >> #if defined(AOM_CTRL_AV1E_GET_NUM_OPERATING_POINTS) && \ >> defined(AOM_CTRL_AV1E_GET_SEQ_LEVEL_IDX) && \ >> defined(AOM_CTRL_AV1E_GET_TARGET_SEQ_LEVEL_IDX) >> - if (!(avctx->flags & AV_CODEC_FLAG_PASS1)) { >> + if (ctx->encoder->iface && !(avctx->flags & AV_CODEC_FLAG_PASS1)) { > > This check is fine, though the codec control call should fail if iface is null. > >> int num_operating_points; >> int levels[32]; >> int target_levels[32]; >> @@ -1544,6 +1544,7 @@ FFCodec ff_libaom_av1_encoder = { >> FF_CODEC_ENCODE_CB(aom_encode), >> .close = aom_free, >> .caps_internal = FF_CODEC_CAP_NOT_INIT_THREADSAFE | >> + FF_CODEC_CAP_INIT_CLEANUP | >> FF_CODEC_CAP_AUTO_THREADS, >> .defaults = defaults, >> .init_static_data = av1_init_static, >> -- >> 2.37.2 >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".