From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2E1CB42703 for ; Tue, 22 Mar 2022 19:38:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 94DC168B177; Tue, 22 Mar 2022 21:38:01 +0200 (EET) Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 76A0B68A8A0 for ; Tue, 22 Mar 2022 21:37:55 +0200 (EET) Received: by mail-qt1-f181.google.com with SMTP id bp39so3596394qtb.6 for ; Tue, 22 Mar 2022 12:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=ecu7p3EQDbHYl9+IvHQv50Oe3z84LZdOZidDnEbNBWM=; b=L6uqMRAXuedSLg3gg7B0wKKyyFKGEPL54DrIeHPcWy0/Q4RRcUfask3klGduNS6J7k lQvc5o2HPvy+jHxPe36r6TSqtngSQhGTSLcTCx4m7+/9GkL8ecMjvVLalmSX4ErwgUHs SMVAA1MyqtslHiw+LrocngiG1BAsC/lYlPZfIhWmwr6TJjaSZYj/sgBIT7bGe1TvFiay pxoin9kFhD15Omp0z16JHI7xEO06DHf+gtzwIhBKbjziIEPCcU6KInaIl2RL+DjlljEi QNFWxHg2NHwfI1GhZeWDs29lG1JeGQUvFxpSD09c0NdNaUoXN2JJvrDVVQs7rGRz+fZz jK6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=ecu7p3EQDbHYl9+IvHQv50Oe3z84LZdOZidDnEbNBWM=; b=dgb6CwXLvYEtz/KPU3QwrVCjtKbdYZtT3WsxXYO/ORxDVH7/6qVT37OLrzj72GZ/Uv wWAeMHVHlxFnKGMWsOhSmzkEiu468wUGJvHnfRhKjh98bJbESFJyxVTIbQUKTNoxi2JC Jngz9m73hmvCt8O6DqrFgEFPO3s+N07IpxEkg2obC6A/bVI/Nu+NMLrtvt+k76+0B2OZ vEhi6a5gwmlDHui2VHi6jpZ9qdPlN+Ksr2sP82oIDPjXYyHOfr8cOaFFDjphA7E7Ugvr L7ijtSQzfWUsJAhXHaUmqDNLeA60T6wd0CITVeQSsR2X/55lQGJlAh61V4LtSlYcPZov PicQ== X-Gm-Message-State: AOAM53360/fnZA6dtMnNT1b/dnBWlN/qUzYT8sFPwKtt79q9VzfxQEah zmCmsH0sHJK76OuUdu2HqJJ7IeflcC0= X-Google-Smtp-Source: ABdhPJzMDGxpWlTepUIshbkVNgvG5mQBLK560StRvpwbS5JcUQVy/R9vqAd7VQIURAjTQdtkYZsthw== X-Received: by 2002:a05:622a:1743:b0:2e1:f657:a415 with SMTP id l3-20020a05622a174300b002e1f657a415mr19238748qtk.7.1647977874000; Tue, 22 Mar 2022 12:37:54 -0700 (PDT) Received: from [192.168.1.35] (c-68-41-54-207.hsd1.mi.comcast.net. [68.41.54.207]) by smtp.gmail.com with ESMTPSA id y66-20020a37af45000000b0067dc0fc539fsm9645101qke.86.2022.03.22.12.37.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Mar 2022 12:37:53 -0700 (PDT) Message-ID: <11245a2d-f6b6-f247-db28-80621b547f2c@gmail.com> Date: Tue, 22 Mar 2022 15:37:53 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US-large To: ffmpeg-devel@ffmpeg.org References: <20220319172645.82718-1-leo.izen@gmail.com> <20220319172645.82718-3-leo.izen@gmail.com> From: Leo Izen In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v7 3/5] avcodec/libjxl: add Jpeg XL encoding via libjxl X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/22/22 11:35, Lynne wrote: > 19 Mar 2022, 18:26 by leo.izen@gmail.com: > >> This commit adds encoding support to libavcodec >> for Jpeg XL images via the external library libjxl. >> --- >> configure | 3 +- >> libavcodec/Makefile | 1 + >> libavcodec/allcodecs.c | 1 + >> libavcodec/libjxlenc.c | 386 +++++++++++++++++++++++++++++++++++++++++ >> 4 files changed, 390 insertions(+), 1 deletion(-) >> create mode 100644 libavcodec/libjxlenc.c >> > I can't accept this as-is, so NAK. > > The coding style needs to be fixed. > And you must remove the sneaky MAINTAINERS change to get yourself > push access. We made that against the rules, which you've clearly read > before submitting the patchset, right? > > Then I'll spare time to look at it and merge it myself. What's wrong with the coding style? Could you please be more specific? I did read the rules on https://ffmpeg.org/developers.html and I believe I followed them all. As for the MAINTAINERS change, this is not a sneaky way to gain push access. I specifically do not want push access. In fact, a discussion about this already occurred on IRC, and the conclusion was that I could be added to the list without gaining push access as I do not want it. Thanks, Leo Izen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".