Re: [FFmpeg-devel] [PATCH v7 3/5] avcodec/libjxl: add Jpeg XL encoding via libjxl

[Leo Izen <leo.izen@gmail.com>]

On 3/22/22 11:35, Lynne wrote:
> 19 Mar 2022, 18:26 by leo.izen@gmail.com:
>
>> This commit adds encoding support to libavcodec
>> for Jpeg XL images via the external library libjxl.
>> ---
>>   configure              |   3 +-
>>   libavcodec/Makefile    |   1 +
>>   libavcodec/allcodecs.c |   1 +
>>   libavcodec/libjxlenc.c | 386 +++++++++++++++++++++++++++++++++++++++++
>>   4 files changed, 390 insertions(+), 1 deletion(-)
>>   create mode 100644 libavcodec/libjxlenc.c
>>
> I can't accept this as-is, so NAK.
>
> The coding style needs to be fixed.
> And you must remove the sneaky MAINTAINERS change to get yourself
> push access. We made that against the rules, which you've clearly read
> before submitting the patchset, right?
>
> Then I'll spare time to look at it and merge it myself.

What's wrong with the coding style? Could you please be more specific? I 
did read the rules on https://ffmpeg.org/developers.html and I believe I 
followed them all.

As for the MAINTAINERS change, this is not a sneaky way to gain push 
access. I specifically do not want push access. In fact, a discussion 
about this already occurred on IRC, and the conclusion was that I could 
be added to the list without gaining push access as I do not want it.

Thanks,
Leo Izen


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".