From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1082542BAE for ; Sat, 30 Apr 2022 19:26:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 19D0068B37D; Sat, 30 Apr 2022 22:26:03 +0300 (EEST) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9D2C268B379 for ; Sat, 30 Apr 2022 22:25:56 +0300 (EEST) Received: by mail-wm1-f48.google.com with SMTP id n32-20020a05600c3ba000b00393ea7192faso6478509wms.2 for ; Sat, 30 Apr 2022 12:25:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=FN4pJgJwsemSWZC3EsvW2GWlYONPkO+urOPS7pEUfnU=; b=PKjiKSHIDxdSCqEabZ8JLz/sX1IrKYuREi6skzunY3IQYYaAdUSZPLjP03GY8W7uoW SMM4qsi/z2wXq8ELH5zwU/KtxXY1i3Wtf1Wp8xD7cABLrtDYnmPdLFWElgfe/1ylQYBo hz8s1Q4G3kBot0QQrKLwOma74+hnqzOjhKLxD4qikT5zHTSRwG+KlQceDaNwkLoudEKe aPvsx3kQ2tNT6BQoe9xc01MC2FAzb6RX+NMKi0wuoDsbJpoasmZ0I/1Y03G97hnA6F4H juDgs5QOd3BcTYDfw7N+RtHfYNioOPjeHJp0TBpY7Kedy32VN9S0EGKXVFjYbI+AzrOw mEug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=FN4pJgJwsemSWZC3EsvW2GWlYONPkO+urOPS7pEUfnU=; b=aVnLPatmj3iUFq/sjCcU6JERkeXcUrWaKPOlGkkSqV+s494C4jR8ZjthJDOWaqOEVE fxQvTYjA/6ycEU+ldamHw3AT+UOhiP9LNyadT9IwetLdJPZHMdRtr2kdKrXWe8GrO5Ya 8D1HK20D9VIeJxIaC9BozcfuOxHDWFgECAg+LOsnHB0wthg/0KWgfhlpLbu/PeeSIuI5 DclK1N9wMELEh5aZKQar3P6r6KCeOrsfrOUYls27NEPxTfiq23TmXWcICMyIStOr3dKN 8Jyrm8yCX+mbEjM7TKAlDLvNFE+DbV5ZDHiFDP1iMjz1+zqAxWv6AGeStlMy2nj1/N5z U98w== X-Gm-Message-State: AOAM530St6wjLlE/525U3fk9MPzrvmEEA64j7iXltp+bJ7QGj0egv6wH eXCNLn9Y4XA4eQfjskvLbpHpeLkq1y/8h6Va X-Google-Smtp-Source: ABdhPJw0HsM7r6pecoeHurCBh8uhuo4d9JFuXAvgT4KKeY40yfWQDU9alPNBJfdSC2ivuCZ3+m9dCg== X-Received: by 2002:a05:600c:1992:b0:392:916d:2168 with SMTP id t18-20020a05600c199200b00392916d2168mr4623392wmq.50.1651346756043; Sat, 30 Apr 2022 12:25:56 -0700 (PDT) Received: from [192.168.0.11] (cpc91222-cmbg18-2-0-cust46.5-4.cable.virginm.net. [81.106.30.47]) by smtp.gmail.com with ESMTPSA id m21-20020a05600c461500b003942a244f42sm2328771wmo.27.2022.04.30.12.25.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Apr 2022 12:25:54 -0700 (PDT) Message-ID: <111defba-5c26-ddf6-8c50-406bc18cccd2@jkqxz.net> Date: Sat, 30 Apr 2022 20:25:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220424101409.95486-1-zane@zanevaniperen.com> <20220424101409.95486-6-zane@zanevaniperen.com> <02a9b3be-e7a0-6283-188a-6033fde862b5@jkqxz.net> From: Mark Thompson In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v2 5/7] avcodec/cbs_sei: refactor to use avutil/uuid X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 30/04/2022 18:53, Pierre-Anthony Lemieux wrote: > On Sat, Apr 30, 2022 at 10:31 AM Mark Thompson wrote: >> >> On 24/04/2022 11:14, Zane van Iperen wrote: >>> From: Pierre-Anthony Lemieux >>> >>> --- >>> libavcodec/cbs_sei.h | 3 ++- >>> libavcodec/vaapi_encode_h264.c | 8 ++++---- >>> 2 files changed, 6 insertions(+), 5 deletions(-) >>> >>> diff --git a/libavcodec/cbs_sei.h b/libavcodec/cbs_sei.h >>> index c7a7a95be0..67c6e6cbbd 100644 >>> --- a/libavcodec/cbs_sei.h >>> +++ b/libavcodec/cbs_sei.h >>> @@ -23,6 +23,7 @@ >>> #include >>> >>> #include "libavutil/buffer.h" >>> +#include "libavutil/uuid.h" >>> >>> #include "cbs.h" >>> #include "sei.h" >>> @@ -41,7 +42,7 @@ typedef struct SEIRawUserDataRegistered { >>> } SEIRawUserDataRegistered; >>> >>> typedef struct SEIRawUserDataUnregistered { >>> - uint8_t uuid_iso_iec_11578[16]; >>> + AVUUID uuid_iso_iec_11578; >>> uint8_t *data; >>> AVBufferRef *data_ref; >>> size_t data_length; >> >> This feels like a step backwards? The syntax template files are explicitly relying on this being uint8_t[16], so giving it a different name is confusing. > > What/where are the syntax template files? (It's included twice by cbs_h2645.c for read/write with different macro setups.) - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".