Re: [FFmpeg-devel] [PATCH] avcodec/aac/aacdec_usac: remove unnecessary cast

[Lynne via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

[-- Attachment #1.1.1.1: Type: text/plain, Size: 989 bytes --]

On 03/06/2024 01:14, James Almer wrote:
> Fixes "libavcodec/aac/aacdec_usac.c(543): error C2440: 'type cast': cannot convert from 'GetBitContext' to 'GetBitContext'"
> from msvc.

That's a very weird error. Why would they not permit casts of the same type?

> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>   libavcodec/aac/aacdec_usac.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c
> index 00ec74718b..c76d72d7a7 100644
> --- a/libavcodec/aac/aacdec_usac.c
> +++ b/libavcodec/aac/aacdec_usac.c
> @@ -540,7 +540,7 @@ static int decode_spectrum_and_dequant_ac(AACDecContext *s, float coef[1024],
>       c = ff_aac_ac_map_process(state, reset, N);
>   
>       /* Backup reader for rolling back by 14 bits at the end */
> -    gb2 = (GetBitContext)*gb;
> +    gb2 = *gb;
>       gb_count = get_bits_count(&gb2);
>   
>       for (i = 0; i < len/2; i++) {

LGTM, tnx

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".