From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AD97D4A89D for ; Mon, 17 Jun 2024 19:02:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 05FF168D791; Mon, 17 Jun 2024 22:02:36 +0300 (EEST) Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B94B168D178 for ; Mon, 17 Jun 2024 22:02:29 +0300 (EEST) Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a6f11a2d18aso616683366b.2 for ; Mon, 17 Jun 2024 12:02:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718650948; x=1719255748; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iSVgVGfGA4Yb9kvcFed8n/V/hsTgvg18fky53TXJl34=; b=ev/4vg1R/eko0FKsx2axn3xxd7OlCAzpyI1ziP/LYg0L80qhYvCbIdeeJts1fe6PgJ Mn6bdzzvBuBX8fqlHp/bE7c9nQxMuMjAr7ZVMo0kUpSTN3H115Nq8lPcEVGnh7iCp/CQ e7npoYN8gbekrdYmzpxipHOgcJnY53csBkiHG2Xxi3Kv9WnmBgykCVd0/l2g0ttEjQ9s mNCuXZbkrK4oQnVZqWts+Ucwhm5FUF0cEpeaCfJH91h4jtTxYcJlWDCRU7am3gUBRf3X D4wbJwwZHwtQDCKpAiqoUOAcRfeHqigZ0d0N7ZEdkbqyAD4eUyC6DUljwQ0k83CuXoaS 8g3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718650948; x=1719255748; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iSVgVGfGA4Yb9kvcFed8n/V/hsTgvg18fky53TXJl34=; b=Bp/XIl/Lq2YkYVJo6C8EpZGuwi9xbKF5lJhLEZqt7GQOVndx/zhabRpu+z4SdaXfDj l930bG4CoImQSLSA0wrQxZ9wcQ65c+iECp3kqkleWDg5JjrhpL0+8WMOpnQqVKUmbIFE DBA76jGHqcb/+rssFgIoQO9kzvIQV95XbC/v9bcLCxCFDDO1YAPcVnIrfvJP/vtgn1tp viFly3QqcfkYbQtYixDziYkKUDY5bFINaNoQjTqzyfpbqD2tly/lbtuTKEZ3EG6QlOJy COskYNQTFbM4s//5UedySi7eJnNelJp3S79xVmtEgr/TyjDoknHfnhIlaNOXsqi0kMK5 3rdA== X-Gm-Message-State: AOJu0YwmhgU7OhU92qysHSlMk6t0k3fDHpOvuz9we0nbuYnvK27FpQir fPPv9WzyD4ONPOle5dvxFkqqub5Mq1q6MMQPMgNdsGA5zPxpFUjRlq+tHA== X-Google-Smtp-Source: AGHT+IEEVqKMTxHSL32J0TrFoYHM0aj5/ogukfWW2xWlkaQ4bVeOe/N04rNNrMTnvxS0OYGiIqanSw== X-Received: by 2002:a17:907:1605:b0:a6f:6ec0:554c with SMTP id a640c23a62f3a-a6f6ec058ffmr563986366b.20.1718650948032; Mon, 17 Jun 2024 12:02:28 -0700 (PDT) Received: from [192.168.1.106] (0540dce9.skybroadband.com. [5.64.220.233]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-a6f56db5b3asm543033466b.52.2024.06.17.12.02.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jun 2024 12:02:27 -0700 (PDT) Message-ID: <10d45dd4-cc76-4eab-9292-34ba4fcdef33@gmail.com> Date: Mon, 17 Jun 2024 20:02:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: ffmpeg-devel@ffmpeg.org References: <20240617134141.224614-1-derek.buitenhuis@gmail.com> <20240617134141.224614-3-derek.buitenhuis@gmail.com> <361003f7-6234-4803-9089-5d4b69b537df@gmail.com> From: Derek Buitenhuis In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v2 2/5] avutil/stereo3d: Fill out stereo info provided by Vision Pro files X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/17/2024 7:09 PM, James Almer wrote: > No, it's av_d2q(), av_q2d(), and av_rescale() as needed. Same as we do > for Mastering Display and Ambient Viewing Environment Metadata. > The reason to use AVRational is that in this specific spec the values > have a denominator of 10000, but in others it doesn't need to, allowing > for more precise values (Matroska would store it as a double, in fact). This is unfortunate. Possibly we should add some util func for this case, as it's a case I know I've personally hit more than once (with bugs caused by lossy roundtrip) in my own code - I ended up manually using num/den in the end. > So we shouldn't define our API for one specific implementation but > rather in a generic way that should accommodate to any potential > implementation. I think we already did the former with a Google > implementation (x.y fixed point values), and i want to avoid doing it again. Will send a v3 set using AVRational, then. - Derek _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".