From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 041DC49443 for ; Thu, 11 Apr 2024 12:35:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2847768D0F6; Thu, 11 Apr 2024 15:35:48 +0300 (EEST) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3224268BA5C for ; Thu, 11 Apr 2024 15:35:42 +0300 (EEST) Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-5cf2d73a183so530010a12.1 for ; Thu, 11 Apr 2024 05:35:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712838939; x=1713443739; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=2Fddl7YriPfwVUbI1i/BFaU53qAatG2mPFRjHDj+jAk=; b=BGMhDkoTBSlZF9JfbEge5USDY5FMUnrFZMznztBEknR0fGQVNL5/HVed8xCd+MYFZ/ AX2GglTidMA0/x9IxWdfi9sBLxPjjh5wTsd6WMhQFWFyRNoVGDM8tiY3VEnthk+1BJBL QRg+fjgGlQRxhOSsd/o+SsbwDko121E7dCtyE4lYEPAzkMlmC0X/UEfsuvYajP0Fan1Y dkCB9mKsCDtsk9GxCO9YJ7+b3d4CFw3oeUIhMHzbYjo8iK3vXQFgO4StyncWDDLemZiJ 6YyudJVet34TiRINdqDBR5AFBW0sSiepbgxqe4V3EHCdRJVncB27hxYd/aPdbMWLKxYo 84Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712838939; x=1713443739; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2Fddl7YriPfwVUbI1i/BFaU53qAatG2mPFRjHDj+jAk=; b=KtEGdQ2rgFdf+scsVVOhSmg9UgnXMxcQ9cj0wnM9BAVhQsnN9RyG8Ev3/jaZkEHS3k /l12j5/IrFJoL5bB5uoqvceRl0Yq1VB1L6sP1QKSBWHzOUQRsBq64+SREAWBJD21ANHz C5Z6JLOUOuktoUKYMCAUTLuMnCAp8celoEAxMM/QEmIUi4R410cwCRJ/iWeqLbD7kV6D DbjHsUa05MFwsy6Go49+C087pjM+0LMP/v7RHSSaPF9X4LN5PdiZVkp7mEaSzpdhzAct CV/P7r2aexfx6RquxXoQW0wOv0VI5tlQb2YR1uTphe/LWESNUfSp8jUfdkyjWrwzhGUv Qwcg== X-Gm-Message-State: AOJu0Ywh/JMkPFhThBYsg4CbnhdSEc9cAdx+9hmDBnB3aAhzIYY+nSnp a/1MeNPACFM4Zh9Z1++wjkUsCPbZkBb0QZHQ5surRIvX81ZVmKaWs5RNHA== X-Google-Smtp-Source: AGHT+IHRZ4PJCvSdDvnJa6h7ezqeqoveuxQ7QB8Ry0sLh5GNTHVZdgOFNvY/pr+uq+duOVfh3WCfhw== X-Received: by 2002:a17:90b:8cb:b0:2a5:3c66:25a8 with SMTP id ds11-20020a17090b08cb00b002a53c6625a8mr3462302pjb.15.1712838938573; Thu, 11 Apr 2024 05:35:38 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id v7-20020a17090a778700b002a51a01f447sm2723971pjk.49.2024.04.11.05.35.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Apr 2024 05:35:38 -0700 (PDT) Message-ID: <10d1bd4f-674b-4202-8b28-7fb02235c6df@gmail.com> Date: Thu, 11 Apr 2024 09:35:37 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240410133118.28144-1-anton@khirnov.net> <20240410133118.28144-10-anton@khirnov.net> Content-Language: en-US From: James Almer In-Reply-To: <20240410133118.28144-10-anton@khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 10/10] lavc/hevc_ps: compactify ShortTermRPS X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/10/2024 10:31 AM, Anton Khirnov wrote: > Do not use larger fields than needed, use size-1 bitfields for flags. > > Reduces sizeof(HEVCSPS) by 1280 bytes. > --- > libavcodec/hevc_ps.c | 6 +++--- > libavcodec/hevc_ps.h | 19 +++++++++++-------- > libavcodec/vulkan_hevc.c | 2 +- > 3 files changed, 15 insertions(+), 12 deletions(-) > > diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c > index 76fe507e7b..7b486ce0af 100644 > --- a/libavcodec/hevc_ps.c > +++ b/libavcodec/hevc_ps.c > @@ -143,11 +143,11 @@ int ff_hevc_decode_short_term_rps(GetBitContext *gb, AVCodecContext *avctx, > for (i = 0; i <= rps_ridx->num_delta_pocs; i++) { > used[k] = get_bits1(gb); > > - rps->use_delta_flag = 0; > + rps->use_delta = 0; > if (!used[k]) > - rps->use_delta_flag = get_bits1(gb); > + rps->use_delta = get_bits1(gb); > > - if (used[k] || rps->use_delta_flag) { > + if (used[k] || rps->use_delta) { > if (i < rps_ridx->num_delta_pocs) > delta_poc = delta_rps + rps_ridx->delta_poc[i]; > else > diff --git a/libavcodec/hevc_ps.h b/libavcodec/hevc_ps.h > index 92b85115f7..a8d07aa1b2 100644 > --- a/libavcodec/hevc_ps.h > +++ b/libavcodec/hevc_ps.h > @@ -70,16 +70,19 @@ typedef struct HEVCHdrParams { > } HEVCHdrParams; > > typedef struct ShortTermRPS { > - uint8_t rps_predict; > - unsigned int delta_idx; > - uint8_t use_delta_flag; > - uint8_t delta_rps_sign; > - unsigned int abs_delta_rps; > - unsigned int num_negative_pics; > - int num_delta_pocs; > - int rps_idx_num_delta_pocs; > int32_t delta_poc[32]; > uint32_t used; > + > + uint8_t delta_idx; > + uint8_t num_negative_pics; > + uint8_t num_delta_pocs; > + uint8_t rps_idx_num_delta_pocs; > + > + uint16_t abs_delta_rps; > + unsigned delta_rps_sign:1; Wont the compiler add two bytes of padding if you put this here? > + > + unsigned rps_predict:1; > + unsigned use_delta:1; > } ShortTermRPS; > > typedef struct HEVCWindow { > diff --git a/libavcodec/vulkan_hevc.c b/libavcodec/vulkan_hevc.c > index c2b65fc201..b109475194 100644 > --- a/libavcodec/vulkan_hevc.c > +++ b/libavcodec/vulkan_hevc.c > @@ -359,7 +359,7 @@ static void set_sps(const HEVCSPS *sps, int sps_idx, > .delta_rps_sign = sps->st_rps[i].delta_rps_sign, > }, > .delta_idx_minus1 = sps->st_rps[i].delta_idx - 1, > - .use_delta_flag = sps->st_rps[i].use_delta_flag, > + .use_delta_flag = sps->st_rps[i].use_delta, > .abs_delta_rps_minus1 = sps->st_rps[i].abs_delta_rps - 1, > .used_by_curr_pic_flag = 0x0, > .used_by_curr_pic_s0_flag = 0x0, _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".