From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CCAB14750D for ; Sun, 10 Sep 2023 15:16:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6102368C8E6; Sun, 10 Sep 2023 18:16:19 +0300 (EEST) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 15653680A6D for ; Sun, 10 Sep 2023 18:16:13 +0300 (EEST) Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-401da71b83cso41039615e9.2 for ; Sun, 10 Sep 2023 08:16:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694358972; x=1694963772; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=8HTObG/Dwic7730CZm2QpmCveOZRSN/mx2gglJGktIU=; b=dFbsXq3LRxJYWGOGvTXNvRO9k8ti8EJSR20NdJDJA4n7RouTdrOt+JCob7elQZbVBR aHn2PWj5vzdzHtQl36jlHRzP1q3EWu+5t6wNhqvX8ycNhXUWrTeEkpwqMBqOjzyCHWZu XPJFpEYN9/rmMEkVHUIx7I3Or0Pgp0bY1gJ2n0aNFtM7/3NkS6cRYsokTWdeLOiV8ewJ pT8+JTPh0/Hm9a5AGH6p93piKmeNfS6wOfLzGq3XnMRydkfXTh90PKqcn19GYrxT8AsL bbWPJBF9vpemmDSAUFZxksyf3goFk7C3Gezaq4AGsBmcH3cTHb0RfbmB9iNCb0zvl5IZ 8Uiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694358972; x=1694963772; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=8HTObG/Dwic7730CZm2QpmCveOZRSN/mx2gglJGktIU=; b=QUWBc/t1iS+d5ORt8Ox/2Kh0+/nECAXrsDLIHYsONoUDiuc9phOa3MhEeDVTOzzQS5 S7TEv/AmsHHKuVOFmWiEfvPjuiUPOTmtS8eCvRAbCwOk1DGtxuUJFxmQkT54cJemByLn /NrjD9wDtuSFOz3p2zCpvFi2QKvm00PO2dVIJPs1ElEPCWmsOHDGF34wqQn1ozl4d3Z+ ibCpiTqYgg6i6j3JwmaUgThMLiA7P3kqQJ+6eCSgzF/Tn+EWAglWqSuUe9iVwhqHTGxb O4ERzddg75iofHWf7Zy9e1t9OXH0A9OHI27oURaq/2mj2HjfW7UymxeJJPKKsmybwM+n +WRQ== X-Gm-Message-State: AOJu0YwIXzL0mNRE2V1fLxj1/i9nWkGExL9oSo/Jjt4aY2c+8R9QXGM9 E/HbV43zh3Y5G3oTot+9H3MJsWyOAaY= X-Google-Smtp-Source: AGHT+IHioEsP0GIwRjOowitXEehwgRUwTSaw9wkkyMa8ZjrmGaSddtmCCKCPNZidXlJu2d1HrFnTXQ== X-Received: by 2002:a05:600c:24c:b0:402:ea6a:c955 with SMTP id 12-20020a05600c024c00b00402ea6ac955mr5927949wmj.8.1694358971993; Sun, 10 Sep 2023 08:16:11 -0700 (PDT) Received: from [192.168.1.106] (33bf2829.skybroadband.com. [51.191.40.41]) by smtp.googlemail.com with ESMTPSA id n8-20020a7bcbc8000000b003fe29f6b61bsm7400541wmi.46.2023.09.10.08.16.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Sep 2023 08:16:11 -0700 (PDT) Message-ID: <1095d893-3b4e-f133-4f62-9d04b9e30296@gmail.com> Date: Sun, 10 Sep 2023 16:16:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 To: ffmpeg-devel@ffmpeg.org References: <20230910150100.11249-2-llyyr.public@gmail.com> From: Derek Buitenhuis In-Reply-To: <20230910150100.11249-2-llyyr.public@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] hevc_ps: fix cpb_cnt_minus1 initialization and fixed_rate check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 9/10/2023 4:00 PM, llyyr wrote: > Fixes: fc429d785e9e24c5520ce716d4bc3b5547e581eb > > cpb_cnt was initialized to 1 before > fc429d785e9e24c5520ce716d4bc3b5547e581eb, so cpb_cnt_minus1 should be > initialized to 0 instead of 1. > > Since we split fixed_rate into a general flag and a within_cvs_flag now, > check for both in conditional. > --- > libavcodec/hevc_ps.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Should be two commits, I think. Also, cpb_cnt_minus1 is being passed to decode_sublayer_hrd() below, and needs a +1 there. - Derek _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".