From: Derek Buitenhuis <derek.buitenhuis@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] hevc_ps: fix cpb_cnt_minus1 initialization and fixed_rate check
Date: Sun, 10 Sep 2023 16:16:10 +0100
Message-ID: <1095d893-3b4e-f133-4f62-9d04b9e30296@gmail.com> (raw)
In-Reply-To: <20230910150100.11249-2-llyyr.public@gmail.com>
On 9/10/2023 4:00 PM, llyyr wrote:
> Fixes: fc429d785e9e24c5520ce716d4bc3b5547e581eb
>
> cpb_cnt was initialized to 1 before
> fc429d785e9e24c5520ce716d4bc3b5547e581eb, so cpb_cnt_minus1 should be
> initialized to 0 instead of 1.
>
> Since we split fixed_rate into a general flag and a within_cvs_flag now,
> check for both in conditional.
> ---
> libavcodec/hevc_ps.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Should be two commits, I think.
Also, cpb_cnt_minus1 is being passed to decode_sublayer_hrd() below, and needs
a +1 there.
- Derek
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-09-10 15:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-10 15:00 llyyr
2023-09-10 15:16 ` Derek Buitenhuis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1095d893-3b4e-f133-4f62-9d04b9e30296@gmail.com \
--to=derek.buitenhuis@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git