From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 3/5] avcodec/av1dec: Use ProgressFrames
Date: Sat, 20 Apr 2024 17:22:35 -0300
Message-ID: <10878f4a-aa34-47c5-b7d3-b20d381d5204@gmail.com> (raw)
In-Reply-To: <AS8P250MB0744DEFE4DC7B0B12D4B40FD8F0D2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
On 4/19/2024 1:07 PM, Andreas Rheinhardt wrote:
> AV1 can put a frame into multiple reference slots;
> up until now, this involved creating a new reference
> to the underlying AVFrame; therefore av1_frame_ref()
> could fail.
> This commit changes this by using the ProgressFrame API
> to share the underlying AVFrames.
>
> (Hint: vaapi_av1_surface_id() checked whether the AV1Frames
> contained in the AV1DecContext were NULL or not (of course
> they were not); this has been changed to actually check for
> whether said AV1Frame is blank or not.)
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> 1. The AV1 patches are basically untested (apart from FATE and
> compilation). Could someone please test them?
I tested this and patch 4/5 with d3d11/12, cuda and vulkan. No issues.
Can't test vaapi.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-04-20 20:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 15:58 [FFmpeg-devel] [PATCH 1/5] avcodec/progressframe: Explain how unnamed union can simplify accesses Andreas Rheinhardt
2024-04-19 16:07 ` [FFmpeg-devel] [PATCH 2/5] avcodec/hevcdec: Use union for AVFrame* and ProgressFrame Andreas Rheinhardt
2024-04-19 16:07 ` [FFmpeg-devel] [PATCH 3/5] avcodec/av1dec: Use ProgressFrames Andreas Rheinhardt
2024-04-20 20:22 ` James Almer [this message]
2024-04-19 16:07 ` [FFmpeg-devel] [PATCH 4/5] avcodec/av1dec: Make av1_frame_replace() out of av1_frame_ref() Andreas Rheinhardt
2024-04-19 16:07 ` [FFmpeg-devel] [PATCH 5/5] avcodec/vaapi_av1: Use ProgressFrames Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10878f4a-aa34-47c5-b7d3-b20d381d5204@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git