* [FFmpeg-devel] [PATCH v2] checkasm/v210enc.c: Use checkasm_check()
@ 2025-03-26 10:30 Martin Storsjö
2025-04-01 9:36 ` Martin Storsjö
0 siblings, 1 reply; 3+ messages in thread
From: Martin Storsjö @ 2025-03-26 10:30 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Kieran Kunhya
From: Kieran Kunhya <kierank@obe.tv>
This gives more informative printouts if the tests fail,
if checkasm is run with "-v".
Signed-off-by: Martin Storsjö <martin@martin.st>
---
tests/checkasm/v210enc.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/tests/checkasm/v210enc.c b/tests/checkasm/v210enc.c
index 9fb8321c25..106f00c851 100644
--- a/tests/checkasm/v210enc.c
+++ b/tests/checkasm/v210enc.c
@@ -72,11 +72,10 @@
randomize_buffers(mask); \
call_ref(y0 + y_offset, u0 + uv_offset, v0 + uv_offset, dst0, width); \
call_new(y1 + y_offset, u1 + uv_offset, v1 + uv_offset, dst1, width); \
- if (memcmp(y0, y1, BUF_SIZE * sizeof(type)) \
- || memcmp(u0, u1, BUF_SIZE * sizeof(type) / 2) \
- || memcmp(v0, v1, BUF_SIZE * sizeof(type) / 2) \
- || memcmp(dst0, dst1, width * 8 / 3)) \
- fail(); \
+ checkasm_check(type, y0, 0, y1, 0, BUF_SIZE, 1, "y"); \
+ checkasm_check(type, u0, 0, u1, 0, BUF_SIZE / 2, 1, "u"); \
+ checkasm_check(type, v0, 0, v1, 0, BUF_SIZE / 2, 1, "v"); \
+ checkasm_check(uint8_t, dst0, 0, dst1, 0, width * 8 / 3, 1, "dst"); \
bench_new(y1 + y_offset, u1 + uv_offset, v1 + uv_offset, dst1, width); \
} \
} while (0)
--
2.39.5 (Apple Git-154)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2] checkasm/v210enc.c: Use checkasm_check()
2025-03-26 10:30 [FFmpeg-devel] [PATCH v2] checkasm/v210enc.c: Use checkasm_check() Martin Storsjö
@ 2025-04-01 9:36 ` Martin Storsjö
2025-04-01 15:33 ` Martin Storsjö
0 siblings, 1 reply; 3+ messages in thread
From: Martin Storsjö @ 2025-04-01 9:36 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Kieran Kunhya
On Wed, 26 Mar 2025, Martin Storsjö wrote:
> From: Kieran Kunhya <kierank@obe.tv>
>
> This gives more informative printouts if the tests fail,
> if checkasm is run with "-v".
>
> Signed-off-by: Martin Storsjö <martin@martin.st>
> ---
> tests/checkasm/v210enc.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/tests/checkasm/v210enc.c b/tests/checkasm/v210enc.c
> index 9fb8321c25..106f00c851 100644
> --- a/tests/checkasm/v210enc.c
> +++ b/tests/checkasm/v210enc.c
> @@ -72,11 +72,10 @@
> randomize_buffers(mask); \
> call_ref(y0 + y_offset, u0 + uv_offset, v0 + uv_offset, dst0, width); \
> call_new(y1 + y_offset, u1 + uv_offset, v1 + uv_offset, dst1, width); \
> - if (memcmp(y0, y1, BUF_SIZE * sizeof(type)) \
> - || memcmp(u0, u1, BUF_SIZE * sizeof(type) / 2) \
> - || memcmp(v0, v1, BUF_SIZE * sizeof(type) / 2) \
> - || memcmp(dst0, dst1, width * 8 / 3)) \
> - fail(); \
> + checkasm_check(type, y0, 0, y1, 0, BUF_SIZE, 1, "y"); \
> + checkasm_check(type, u0, 0, u1, 0, BUF_SIZE / 2, 1, "u"); \
> + checkasm_check(type, v0, 0, v1, 0, BUF_SIZE / 2, 1, "v"); \
> + checkasm_check(uint8_t, dst0, 0, dst1, 0, width * 8 / 3, 1, "dst"); \
> bench_new(y1 + y_offset, u1 + uv_offset, v1 + uv_offset, dst1, width); \
> } \
> } while (0)
> --
> 2.39.5 (Apple Git-154)
Will push soon unless there are objections.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2] checkasm/v210enc.c: Use checkasm_check()
2025-04-01 9:36 ` Martin Storsjö
@ 2025-04-01 15:33 ` Martin Storsjö
0 siblings, 0 replies; 3+ messages in thread
From: Martin Storsjö @ 2025-04-01 15:33 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Kieran Kunhya
On Tue, 1 Apr 2025, Martin Storsjö wrote:
> On Wed, 26 Mar 2025, Martin Storsjö wrote:
>
>> From: Kieran Kunhya <kierank@obe.tv>
>>
>> This gives more informative printouts if the tests fail,
>> if checkasm is run with "-v".
>>
>> Signed-off-by: Martin Storsjö <martin@martin.st>
>> ---
>> tests/checkasm/v210enc.c | 9 ++++-----
>> 1 file changed, 4 insertions(+), 5 deletions(-)
>>
>> diff --git a/tests/checkasm/v210enc.c b/tests/checkasm/v210enc.c
>> index 9fb8321c25..106f00c851 100644
>> --- a/tests/checkasm/v210enc.c
>> +++ b/tests/checkasm/v210enc.c
>> @@ -72,11 +72,10 @@
>> randomize_buffers(mask);
>> \
>> call_ref(y0 + y_offset, u0 + uv_offset, v0 + uv_offset, dst0,
>> width); \
>> call_new(y1 + y_offset, u1 + uv_offset, v1 + uv_offset, dst1,
>> width); \
>> - if (memcmp(y0, y1, BUF_SIZE * sizeof(type))
>> \
>> - || memcmp(u0, u1, BUF_SIZE * sizeof(type) / 2)
>> \
>> - || memcmp(v0, v1, BUF_SIZE * sizeof(type) / 2)
>> \
>> - || memcmp(dst0, dst1, width * 8 / 3))
>> \
>> - fail();
>> \
>> + checkasm_check(type, y0, 0, y1, 0, BUF_SIZE, 1,
>> "y"); \
>> + checkasm_check(type, u0, 0, u1, 0, BUF_SIZE / 2, 1,
>> "u"); \
>> + checkasm_check(type, v0, 0, v1, 0, BUF_SIZE / 2, 1,
>> "v"); \
>> + checkasm_check(uint8_t, dst0, 0, dst1, 0, width * 8 / 3, 1,
>> "dst"); \
>> bench_new(y1 + y_offset, u1 + uv_offset, v1 + uv_offset, dst1,
>> width); \
>> }
>> \
>> } while (0)
>> --
>> 2.39.5 (Apple Git-154)
>
> Will push soon unless there are objections.
Pushed.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-01 15:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-26 10:30 [FFmpeg-devel] [PATCH v2] checkasm/v210enc.c: Use checkasm_check() Martin Storsjö
2025-04-01 9:36 ` Martin Storsjö
2025-04-01 15:33 ` Martin Storsjö
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git