From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DC7F5408FA for ; Fri, 24 Dec 2021 03:52:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3074668B279; Fri, 24 Dec 2021 05:52:02 +0200 (EET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 97A9768B26F for ; Fri, 24 Dec 2021 05:51:54 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640317919; x=1671853919; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=PL7t8JaGO8fYjlt2AUwAYkMHwcnPsPtGJDT8U0zyDSg=; b=DJWGUXn+t0RUFS2aAL+RnLZ74Vh8RIOp4KtzfxRKb/5YD7CuO3PsxpDu ZHco3BQrRtYs4QUXzzdw9gvqOX6z8XJsRKxMlHoS4ZzusZn9Y8vQ5Vnz4 obw/He7yhlzFFzpkckZPeqPq4JTLlyCrnqLQRNyQgjz0rtQ+R5Wa8AKPV +fWv6vWnuGdLkY67D0K5LpcFXwecr0vRdJWCM146u3EgIue7+634dNwls 9aA9yWOS3+ygotO2CdDa9kzkpOmKVKePdwRkK17HrGH7ZjaneMHitEwiR wzfLN5FdVpFzoUZvirEVOpQAIDmeJLbDP2WMq1qeJsEfyJB47QsPzQYV2 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10207"; a="238459814" X-IronPort-AV: E=Sophos;i="5.88,231,1635231600"; d="scan'208";a="238459814" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Dec 2021 19:51:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,231,1635231600"; d="scan'208";a="485273717" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP; 23 Dec 2021 19:51:52 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 23 Dec 2021 19:51:52 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 23 Dec 2021 19:51:52 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 23 Dec 2021 19:51:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QhV1AyqbRcqXIr0adM6NJXdEoigDjF4L2LONth07uT8yeIGLjCu9v4OxbFPlXdmnMb0sRZEmD5bY1uwBd4N93up2BQW+USHNcI8i2UDpYbAa5PwQQG1hRBvxdWCvFE/sMh8SrQpN+PoKVH1sl88hjBqDISKlK6jGeLc2J3cnOSXTrOI9xi/jg70LDITGFPCq0139K0ma7U0/Sh/A5/ug0SK1Xie/qV93k8IRb4bvVQR8mimcl7iIe7z8zk2PEHVrSjYmEdj9X8yzK+5AIQugfwArRP0btdolaUdRtwXrXLgNTlKFdgkO1BHvgsesB2PcBuOJg7rq4H3w+nJPsbT72w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PL7t8JaGO8fYjlt2AUwAYkMHwcnPsPtGJDT8U0zyDSg=; b=CTyHa2BTtOEAELNIaXBSFUe0LEjwUv5AXl8Ry07BhZqjpi2kwYQKW5R86oSJjIi302QWSG2Na3hAjCkSNzIB7V5iTVOgCbbfgtJ5nqbdHoHPuG43t/fb/jcvdMCnjf1H9sSoIeRppBkcd9qavlNMCPHy/CIEBT1m9DMSxcwFW3zzzS0CO4bRRhpjKF62vakjbwPhG8kmPSmcqkTNb4zqJT77qxAwGd8g3XlXzGUY2iohOoh22NvI6QSBPpPRmc6juE9wf9BzvphoA01bJhP0BVxUa0+pzT5m3Zc3VMyelW1GeBtOewM1Kzu8326kYINmSuxJlDnUllKUk7IlcmleWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BN6PR11MB1299.namprd11.prod.outlook.com (2603:10b6:404:49::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19; Fri, 24 Dec 2021 03:51:50 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::bcfc:ceef:cd03:dd16]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::bcfc:ceef:cd03:dd16%3]) with mapi id 15.20.4801.023; Fri, 24 Dec 2021 03:51:50 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" , "andreas.rheinhardt@outlook.com" Thread-Topic: [FFmpeg-devel] [PATCH 08/11] avcodec/tests/avcodec: Check codec caps for consistency Thread-Index: AQHXsWKqYCSqRgfOLUGG2ozi7GqhY6xBdOgAgAAB8gCAAAaWAIAABuQAgAAMDoA= Date: Fri, 24 Dec 2021 03:51:50 +0000 Message-ID: <0fefb5ff08e57e9782563bf13a17b9e6ed7b46c7.camel@intel.com> References: <420d12e0288d42515f1f8dae75c2a70e561084da.camel@intel.com> In-Reply-To: Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 11211c68-8f8a-426b-e72b-08d9c690b7a5 x-ms-traffictypediagnostic: BN6PR11MB1299:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ObmUok/HnkEhbGDJsEBZl7OV0VDFwYZ4jIglloTSoAAGAUVAisIy2WmvXXKjBDiEB0Imu3Ddr4DVedtlnH+b/Fm0ewkyMklqaMzTLcfxWzjku2vipx/zHNuCLovOVL6pJgzdp8gwA+xx9u58kMDoad8M95FIozp4Lzc2u9mtAsIgjWA6r7DiMzITytAhQOmkWoL6LquPkCyijdw7hlx2923qH8Qr3bOK/c+mW+EKFj1tarLFZpook5XpKwXBLb8a+8tXRQHYYVXVF5LPUkytFPAfz8VRB0P0Y2NGlJaeUEq3cCvbbpMyDYU0rP2VEuU3pkzKgqsjW62amaEaWhdnfZhR5d98HB8Yn4Hx2MLG2q0s6NVzRQh87qV6mUHNBRF8+L0XQBpF9reYfFMaN2FSd56LHZyBcOJpHzq/xnnrn53LpwKJegGzy3QgYcXUBuuBxA95Uo5WhI9FeOYcHUbVdtEpJGnBiVu5CUJBtqu3kzllVZRpToQAKbFGHGj8xOZ5S83c/oYxSpjnWyZMbBkcwQk/qeLjCkuVRp7SHCFbyRN5mbqdcs0ROiq5AGRJ0VbHImTDVNBe2NeAMrgv8ie8YA3b9q4KbXbf/3lumlseKrc7Cp4T2jW6hj8I8/49YlOi6h2nmfY270/jgNL8nt7fWw/skHF5zRrk8U8SkC0RIdJ+pG/6cLKr4OsYxh+kqWCLeBe9+03kJNaOLTsZqwXu/KMm0rXO6MCTNb6ptPUkeMS6+p57dILbGFM8qqebnSv/bZm0y+1pgeGcxRgo9hHxi+Wp9Cxfi0aOu4h3lYKkJw07Yj6ioGoirl4z38yMMPuVcYkuGoz/WV+EW4lk/tVu/iATuZT9cUgiBikTHMBqJds= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(82960400001)(83380400001)(66446008)(122000001)(186003)(5660300002)(8936002)(6486002)(2906002)(8676002)(66476007)(64756008)(76116006)(66556008)(86362001)(2616005)(4001150100001)(91956017)(66946007)(508600001)(38070700005)(71200400001)(36756003)(966005)(6512007)(6506007)(38100700002)(26005)(316002)(110136005)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MzgrNndHc1IydWFibU40V2NhM3VlbGVhRnpWdjU2Z0ZBcDBSTWVnMitHL0ZR?= =?utf-8?B?ZUo4T0FyQlpnMWZKb0grUnlJcWY3bmRlZGlTZ2xHUjJSQm5Sb2VZRDRaTWFj?= =?utf-8?B?ckFHWWttZ1lFV1ZsYkN3RjJFQ1V2Q2lPakdodC9iNVA5N2lkRHlUdEU5ZWM4?= =?utf-8?B?bTFQdXpQbjJoSzI5MmwzdVUzdnpiL21wWE9QdFhwbXJXTXg5THd3eGV1cTVZ?= =?utf-8?B?MnZteXFZTWh1Y0xjWmtaVFVOQ3BIbFdCWW9MVkowY3BVQlRrTnFpK1lNOXox?= =?utf-8?B?T1BtbzM3VDRzRXJXYUxaNlNOWk1VWjYvNjBpTnljRHA1ZTdRR0N0Tmg5NUQr?= =?utf-8?B?MnZuVGdVakxLdy9IbGNrY3AxcUVEVm03dlUyZk96VWNqYmc4dnBpWFFtYmtN?= =?utf-8?B?RTB2V1JpNld6NjZKcFRzTXBRRnhWSW8rOU5rOExxQ0VvNTIvNVZvRnA0czZw?= =?utf-8?B?YTE3Z2RYd3dIcGw0ZWk0Sm1vekpOQzJveTJBYjB4TWVFanZtSU1CZkYwVGRa?= =?utf-8?B?cTN2Tk0vM3o0OXhNRE1obFdNWEE3TWt5d3EzNHVRN1h0cmdzN3drbm0yM2FG?= =?utf-8?B?eE5ZOGx3RktGNW5IK0RTdlBQM05DWThVUTFVaXgvVmJISmY0WlpqNjk4ekN4?= =?utf-8?B?RWE5QlRnVCt1c0hPSm13RUFtaFo2aU5OcWs2ME9vZ3lSZkxYRUcwSW9OOVY5?= =?utf-8?B?Mkc5SmNLbDB0bEh2Q1dTL00vTU9tbzFqUVZpcTdDd21YRDdlOU1qYVl2N2g4?= =?utf-8?B?Qi9qMnp4MWhvZ1hObWk2UjJUeTNTNUlUUU42UW9HSmhWbFIxK1lTd1NXRm03?= =?utf-8?B?bGlQbjRjOHJWbWxaRk8xazJSdHJ4bG9taWs2azFiaDFuWEZqdktHeXl1Sy9U?= =?utf-8?B?anhHZ2tYejh5RXplOEd0bXVDZUltdnRoTXBKRlk2YXplUEwxR3EzUmR2dDBj?= =?utf-8?B?NFhrYkk0clF5VUx0MHJjNWR5ODgrak5XaVVVN2szWjVLNzVKdzRBd0ZJSVcv?= =?utf-8?B?NFdQdVVla3RXb0pmMElXdVIxdzVQZFZLY3d5NFk1TU1nYkNSdWxyemlpSSti?= =?utf-8?B?cnB0bGF5azBCSTVveHRMbzAvRUJsWS9jZjlzejRGb1hxSkIxL0tOUmlkWFBr?= =?utf-8?B?NkxOYTJWWldMbWU3Qk1IWnJ2UGszTzd5b0lSNlVLQWdOemwxd3VzUUZ4QjFx?= =?utf-8?B?U0NhS3hNRldvNzE0SGN2NGsxRUwrTjhwQUh4RmJDQXlreFgybFpLN1RSL2JZ?= =?utf-8?B?SmpuNDdxN0FCVHNTZ1RVUkJDbXljbWo3WS9FSTdpaUtydzEzMTBWektoa2tw?= =?utf-8?B?dm5XNGszL3daaVkxTFB4U3RuQTNKUkFJY3NBaFNIV2o4QmtGNWJmc21qTmFk?= =?utf-8?B?c0JKNWpRN2RycEUzWnljNE5jZDc1UGdpYXluYW1XUU9iWEc1bnFCL1Z2SW1m?= =?utf-8?B?M0JVK05VMkpJVmg3VitwZzN3WFd5ZmE5NW5VSkEwVVBGOUdtNUFlSnAvQmxZ?= =?utf-8?B?ZzRQYVEySThOaWxqOFRPM081VnVnanVTYmJYTGlYWHJzVFVWaE84TjI4QUpi?= =?utf-8?B?NS9VckdHSXZWSG9PUVV6ZkpQUXN5V3F4RW1GcDBFRXZDdWIyT0JJOUVRZ1g5?= =?utf-8?B?dVp2UTdSQ044T09sVklnQXNXZW5RVVpUelF6eUdKSlhPSFdLT0RCdzZqM1NQ?= =?utf-8?B?SjQ5Y09mV29RbkZZQTFTcXdQaW5BOVQvVkhsZGdmb0xIWEg1VldmNUkwWDZa?= =?utf-8?B?Tk1oL2lTaTRVWVpsN1RvQnAveVdkSmJqWjdZeW1qekpYMmZWejhuc3VwU2VJ?= =?utf-8?B?VmVmNXo4U3NsNVBOOG5hMTFSR0dPbEdJUThyZDdTS01JRDI5dkIrcmpSY3RW?= =?utf-8?B?eG9ENlN1UklJZmkzd20xM2xtZTB4T05PUUJDM1B0RTNwbnF3YUNJdWpab1Zj?= =?utf-8?B?S3ZMZ0hMa3RmYmJKdjhSOEtWcHJzQ3JWb2tOa0RKZHJsZkhHUWYxRGtsdFhP?= =?utf-8?B?Y2RQWW8zT1dFRUVMUzE1ektxdkZUbXNpT3hSeTdjdk5pd2VIYkxHOG5OQ2Js?= =?utf-8?B?Ym9iUDJsclRIVjNldFJOV1RsTGYxSldyOG9RV2huREFUUW9KaDJqNXBpc2lY?= =?utf-8?B?UmtidE44WW9RaHZyeERZQ09nMzMrcVRQaTlRcS9IRFpYT3I2ZmRMRlVXV21W?= =?utf-8?Q?zGJRk/MtGO9XjpnqXAtNAKE=3D?= Content-ID: <374F2462A46CAB458D82E2D7C65A3A31@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11211c68-8f8a-426b-e72b-08d9c690b7a5 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Dec 2021 03:51:50.6766 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HMESS8qeaxkdL9V0WLgTbR0YSQcXZUVJr7EYGS3WmrEAjBE0pPP/BTsYRWgHolsJ3+3OrG1H8AKwEL3o3VPVsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1299 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH 08/11] avcodec/tests/avcodec: Check codec caps for consistency X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 2021-12-24 at 04:08 +0100, Andreas Rheinhardt wrote: > Xiang, Haihao: > > On Fri, 2021-12-24 at 03:20 +0100, Andreas Rheinhardt wrote: > > > Xiang, Haihao: > > > > On Fri, 2021-09-24 at 18:37 +0200, Andreas Rheinhardt wrote: > > > > > Signed-off-by: Andreas Rheinhardt > > > > > --- > > > > > libavcodec/tests/avcodec.c | 38 > > > > > ++++++++++++++++++++++++++++++++++++++ > > > > > 1 file changed, 38 insertions(+) > > > > > > > > > > diff --git a/libavcodec/tests/avcodec.c b/libavcodec/tests/avcodec.c > > > > > index 5512ae99f7..e26315c368 100644 > > > > > --- a/libavcodec/tests/avcodec.c > > > > > +++ b/libavcodec/tests/avcodec.c > > > > > @@ -19,6 +19,7 @@ > > > > > #include "libavutil/opt.h" > > > > > #include "libavcodec/codec.h" > > > > > #include "libavcodec/codec_desc.h" > > > > > +#include "libavcodec/internal.h" > > > > > > > > > > static const char *get_type_string(enum AVMediaType type) > > > > > { > > > > > @@ -78,11 +79,26 @@ int main(void){ > > > > > if (codec->channel_layouts || codec->sample_fmts || > > > > > codec->supported_samplerates) > > > > > ERR("Non-audio codec %s has audio-only fields > > > > > set\n"); > > > > > + if (codec->capabilities & (AV_CODEC_CAP_SMALL_LAST_FRAME > > > > > | > > > > > + AV_CODEC_CAP_CHANNEL_CONF > > > > > | > > > > > + AV_CODEC_CAP_VARIABLE_FRAME_SI > > > > > ZE)) > > > > > + ERR("Non-audio codec %s has audio-only capabilities > > > > > set\n"); > > > > > } > > > > > if (codec->type != AVMEDIA_TYPE_VIDEO) { > > > > > if (codec->pix_fmts || codec->supported_framerates) > > > > > ERR("Non-video codec %s has audio-only fields > > > > > set\n"); > > > > > + if (codec->caps_internal & FF_CODEC_CAP_EXPORTS_CROPPING) > > > > > + ERR("Non-video codec %s exports cropping\n"); > > > > > } > > > > > + if (codec->caps_internal & FF_CODEC_CAP_SLICE_THREAD_HAS_MF > > > > > && > > > > > + !(codec->capabilities & AV_CODEC_CAP_SLICE_THREADS)) > > > > > + ERR("Codec %s wants mainfunction despite not being " > > > > > + "slice-threading capable"); > > > > > + if (codec->caps_internal & FF_CODEC_CAP_AUTO_THREADS && > > > > > + !(codec->capabilities & (AV_CODEC_CAP_FRAME_THREADS | > > > > > + AV_CODEC_CAP_SLICE_THREADS | > > > > > + AV_CODEC_CAP_OTHER_THREADS))) > > > > > + ERR("Codec %s has private-only threading support\n"); > > > > > > > > > > is_decoder = av_codec_is_decoder(codec); > > > > > is_encoder = av_codec_is_encoder(codec); > > > > > @@ -103,6 +119,19 @@ int main(void){ > > > > > ret = 1; > > > > > } > > > > > } > > > > > + if (codec->caps_internal & > > > > > (FF_CODEC_CAP_ALLOCATE_PROGRESS | > > > > > + FF_CODEC_CAP_SETS_PKT_DTS | > > > > > + FF_CODEC_CAP_SKIP_FRAME_FILL_ > > > > > PARA > > > > > M | > > > > > + FF_CODEC_CAP_EXPORTS_CROPPING > > > > > | > > > > > + FF_CODEC_CAP_SETS_FRAME_PROPS > > > > > ) || > > > > > + codec->capabilities & (AV_CODEC_CAP_AVOID_PROBING | > > > > > + AV_CODEC_CAP_CHANNEL_CONF | > > > > > + AV_CODEC_CAP_DRAW_HORIZ_BAND > > > > > | > > > > > + AV_CODEC_CAP_SUBFRAMES)) > > > > > + ERR("Encoder %s has decoder-only capabilities > > > > > set\n"); > > > > > + if (codec->capabilities & AV_CODEC_CAP_FRAME_THREADS && > > > > > + codec->capabilities & AV_CODEC_CAP_ENCODER_FLUSH) > > > > > + ERR("Frame-threaded encoder %s claims to support > > > > > flushing\n"); > > > > > > > > I didn't see such requirement in codec.h and wonder why the two flags > > > > can't > > > > coexist, could you please provide a little more explanation ? > > > > > > > > > > The only reason for this is that it is not implemented to flush an > > > encoder that uses frame threads. > > > (Do you have any specific encoder in mind?) > > > > Thanks for the answer. > > > > ( There is a patch ( > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/1564549538-25724-1-git-send-email-linjie.fu@intel.com/ > > ) to support variable resolution encode, and the revised version ( > > https://github.com/intel-media-ci/cartwheel-ffmpeg/blob/master/patches/0011-fftools-ffmpeg-support-variable-resolution-encode.patch > > , which is not sent to ML yet) added AV_CODEC_CAP_ENCODER_FLUSH to > > ff_rawvideo_encoder, and recently AV_CODEC_CAP_FRAME_THREADS was added to > > ff_rawvideo_encoder in FFmpeg, so this error was triggered in testing) > > > > BRs > > Haihao > > > > 1. AV_CODEC_CAP_ENCODER_FLUSH has actually been added for encoders for > which closing and reopening is prohibitively expensive; the rawvideo > encoder is the exact opposite of this. > 2. The unimplemented frame-threaded part of flushing an encoder is > roughly as follows: Wait until all the worker threads have finished > encoding what they have and discard the result. > 3. I don't know whether it is desired to update the values set during > init based upon the new parameters. If so, the update_thread_context > would need to be repurposed, but this is probably more complicated than > simply adding flushing to frame threaded encoders. > Thanks for the reply, we'll take these into account. BRs Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".