From: "Tomas Härdin" <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 4/6] avformat/mov: parse ISO-14496-12 ChannelLayout
Date: Fri, 24 Feb 2023 10:42:06 +0100
Message-ID: <0fe66e6e2d6eaa39f4d2b77d09a04d915d651732.camel@haerdin.se> (raw)
In-Reply-To: <tencent_96272E38BF9664CD28A03D4D874FE3556007@qq.com>
fre 2023-02-24 klockan 20:25 +0800 skrev Zhao Zhili:
> + if (!layout) {
> + uint8_t positions[64] = {};
Is there a maximum number of channels defined somewhere? stsd supports
up to 65535.
> + // stream carries objects
> + if (stream_structure & 2) {
> + int obj_count = avio_r8(pb);
> + av_log(c->fc, AV_LOG_TRACE, "'chnl' with object_count %d\n",
> obj_count);
> + }
> +
> + avio_seek(pb, end, SEEK_SET);
I feel we should complain loudly if there's bytes not accounted for, at
least when (stream_structure & 2) == 0
The rest I can't say much about
/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-02-24 9:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230224122523.143571-1-quinkblack@foxmail.com>
2023-02-24 12:25 ` [FFmpeg-devel] [PATCH 1/6] avformat/movenc: add PCM in mp4 support Zhao Zhili
2023-02-24 9:41 ` Tomas Härdin
2023-02-24 18:29 ` Zhao Zhili
2023-02-24 12:25 ` [FFmpeg-devel] [PATCH 2/6] avformat/mov: fix ISO/IEC 23003-5 support Zhao Zhili
2023-02-24 9:41 ` Tomas Härdin
2023-02-24 12:25 ` [FFmpeg-devel] [PATCH 3/6] avformat/isom_tags: remove ipcm from movaudio_tags Zhao Zhili
2023-02-24 9:42 ` Tomas Härdin
2023-02-24 12:25 ` [FFmpeg-devel] [PATCH 4/6] avformat/mov: parse ISO-14496-12 ChannelLayout Zhao Zhili
2023-02-24 9:42 ` Tomas Härdin [this message]
2023-02-24 18:37 ` Zhao Zhili
2023-02-24 13:49 ` Jan Ekström
2023-02-25 4:31 ` Zhao Zhili
2023-10-31 3:15 ` Zhao Zhili
2023-10-31 3:15 ` Zhao Zhili
2023-02-24 12:25 ` [FFmpeg-devel] [PATCH 5/6] avformat/movenc: write ChannelLayout box for PCM Zhao Zhili
2023-02-24 9:42 ` Tomas Härdin
2023-02-24 12:25 ` [FFmpeg-devel] [PATCH 6/6] fate/mov: add PCM in mp4 test Zhao Zhili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fe66e6e2d6eaa39f4d2b77d09a04d915d651732.camel@haerdin.se \
--to=git@haerdin.se \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git