From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 473824B9EB for ; Mon, 8 Jul 2024 17:56:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1D51F68DCA5; Mon, 8 Jul 2024 20:56:08 +0300 (EEST) Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AD51168D787 for ; Mon, 8 Jul 2024 20:56:01 +0300 (EEST) Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-71871d5e087so2916080a12.1 for ; Mon, 08 Jul 2024 10:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720461358; x=1721066158; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=htU6N3cT3dRpFyfeovmTJkgIfoI68+jpMkP6L8zlRm8=; b=NB67G77aszBHw5jigzWWR2OPIYjPUXXnJdAHp19ed6stp9QUrj9Ck7fXCuJvBhPeeN iruScH5JPyj5/FmvB5lDuPAs8e5h2WcGD5y7gheqtPzr+0WG9dZc1sJzkt6JL0gnjkLu humYiZDGxFjjYg2msNWoYg0hsTveDRPIEp/l8NGRM5HBXkrFbStBL5R39rLnYRXxfy2n RmY+rvCtvL4pOnzZq51khZdZR5inC+IDitybAPKCw/fYsPy4icCf3CIAP/Ngp1K8R4HP VtxDrCOrBGf/eCuKeOSS01DIIxIoSGnxg68ADeqDo4lmYlEJzGn7obhdP94vtY8ua09Y DfHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720461358; x=1721066158; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=htU6N3cT3dRpFyfeovmTJkgIfoI68+jpMkP6L8zlRm8=; b=Dy25Z6AT2pi32e0LfWhGGF/czLUb4wbo441+xl/ramPnF3LyN2A2jGjlteRDbk6+kn 5Bf+uGN6Kxf8AgigYj+hzJVO0O7B5JT2CMZs0Au/TD5c8Yp5HPJfPknAWOL3yIaNoZcz IqEMwsC7yWd025fV3qvu4nCvkdlKDX093gGf0RmEqHo/CDfar5BFjFLdcsFyQM/tHjvC 2Dama5XIDOWAr2gEmKVTfE7Tb+xzJQKSKRArW9pBMRKDK7aCZcyzrXGpp22c2i6Jzc7h 0sOaNsBR1zIud6XtFqtyWgOZzeXof3orWsYnv6xtllOKVh3Q7Q4zptcccZHWxh/pk6cH en1A== X-Gm-Message-State: AOJu0YxlHH5AHe4ubHtA7HIoId1eFT13siLq97BzxZrhaGic2A6CZbcG RokgygaOobWm6xyTDrP8K6KxjhC8fW6edB1VIwyFejBuz0B38ObwGWhMoA== X-Google-Smtp-Source: AGHT+IFm8e38DE/dkDUE3oKw6e2PW3mPNaTRHlVUJ3v8FxEQlADctg4+WekR0YeeTQpzVNMyzi76Vg== X-Received: by 2002:a05:6a20:12cb:b0:1c2:8951:7e6a with SMTP id adf61e73a8af0-1c2984c9e21mr142529637.39.1720461358255; Mon, 08 Jul 2024 10:55:58 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c99a92c1ffsm8563661a91.9.2024.07.08.10.55.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jul 2024 10:55:57 -0700 (PDT) Message-ID: <0ed62782-2ff9-496b-b576-721e2a670f08@gmail.com> Date: Mon, 8 Jul 2024 14:55:58 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 3/4] avformat/matroskaenc: Only write useful cropping values X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/8/2024 2:52 PM, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/matroskaenc.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c > index 4b91283119..a98d33abf3 100644 > --- a/libavformat/matroskaenc.c > +++ b/libavformat/matroskaenc.c > @@ -1799,10 +1799,14 @@ static int mkv_write_track_video(AVFormatContext *s, MatroskaMuxContext *mkv, > return AVERROR(EINVAL); > } > > - ebml_writer_add_uint(&writer, MATROSKA_ID_VIDEOPIXELCROPB, bottom); > - ebml_writer_add_uint(&writer, MATROSKA_ID_VIDEOPIXELCROPT, top); > - ebml_writer_add_uint(&writer, MATROSKA_ID_VIDEOPIXELCROPL, left); > - ebml_writer_add_uint(&writer, MATROSKA_ID_VIDEOPIXELCROPR, right); > + if (bottom) > + ebml_writer_add_uint(&writer, MATROSKA_ID_VIDEOPIXELCROPB, bottom); > + if (top) > + ebml_writer_add_uint(&writer, MATROSKA_ID_VIDEOPIXELCROPT, top); > + if (left) > + ebml_writer_add_uint(&writer, MATROSKA_ID_VIDEOPIXELCROPL, left); > + if (right) > + ebml_writer_add_uint(&writer, MATROSKA_ID_VIDEOPIXELCROPR, right); > > cropped_width -= left + right; > cropped_height -= top + bottom; LGTM. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".